diff mbox series

l2fwd-crypto: align private data size to cache size

Message ID 20210223061307.22765-1-hemant.agrawal@nxp.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series l2fwd-crypto: align private data size to cache size |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues
ci/iol-testing fail Testing issues

Commit Message

Hemant Agrawal Feb. 23, 2021, 6:13 a.m. UTC 
  From: Gagandeep Singh <g.singh@nxp.com>

L2fwd-crypto is passing 24b private data size while packet
pool creation. This patch aligns that private data size
to cache line size for better performance results.

Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
 app/proc-info/main.c         | 2 +-
 examples/l2fwd-crypto/main.c | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Akhil Goyal April 5, 2021, 6:52 p.m. UTC | #1 
L2fwd-crypto is passing 24b private data size while packet
pool creation. This patch aligns that private data size
to cache line size for better performance results.

Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
 app/proc-info/main.c         | 2 +-
 examples/l2fwd-crypto/main.c | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

I believe proc-info change is added by mistake in this patch.
Please fix this.
diff mbox series

Patch

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index b9587f7de..2ca685f86 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1406,7 +1406,7 @@  main(int argc, char **argv)
 	/* If no port mask was specified, then show non-owned ports */
 	if (enabled_port_mask == 0) {
 		RTE_ETH_FOREACH_DEV(i)
-			enabled_port_mask = 1ul << i;
+			enabled_port_mask |= 1ul << i;
 	}
 
 	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 656b14036..23a398043 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -2711,7 +2711,8 @@  main(int argc, char **argv)
 
 	/* create the mbuf pool */
 	l2fwd_pktmbuf_pool = rte_pktmbuf_pool_create("mbuf_pool", NB_MBUF, 512,
-			sizeof(struct rte_crypto_op),
+			RTE_ALIGN(sizeof(struct rte_crypto_op),
+				RTE_CACHE_LINE_SIZE),
 			RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id());
 	if (l2fwd_pktmbuf_pool == NULL)
 		rte_exit(EXIT_FAILURE, "Cannot create mbuf pool\n");