[v2,3/3] net/ice: disable ice DDP package on Windows
Checks
Commit Message
Disable loading of external DDP package as it is not
supported on Windows.
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
---
drivers/net/ice/ice_ethdev.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On Wed, Mar 10, 2021 at 05:58:48PM -0800, Pallavi Kadam wrote:
> Disable loading of external DDP package as it is not
> supported on Windows.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
Acked-by: Jie Zhou <jizh@microsoft.com>
> ---
> drivers/net/ice/ice_ethdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
On 3/11/2021 1:58 AM, Pallavi Kadam wrote:
> Disable loading of external DDP package as it is not
> supported on Windows.
>
Should this be documented in driver documentation as Windows support limitation?
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
<...>
On 3/26/2021 4:53 AM, Ferruh Yigit wrote:
> On 3/11/2021 1:58 AM, Pallavi Kadam wrote:
>> Disable loading of external DDP package as it is not
>> supported on Windows.
>>
>
> Should this be documented in driver documentation as Windows support
> limitation?
We have mentioned about it in Windows prerequisite section.
Yes, we can include it in the Windows limitation section as well. Will
add it in v3.
>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>
> <...>
>
>
@@ -1652,6 +1652,7 @@ ice_pf_setup(struct ice_pf *pf)
* Extract device serial number from PCIe Configuration Space and
* determine the pkg file path according to the DSN.
*/
+#ifndef RTE_EXEC_ENV_WINDOWS
static int
ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
{
@@ -1689,6 +1690,7 @@ ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
strncpy(pkg_file, ICE_PKG_FILE_DEFAULT, ICE_MAX_PKG_FILENAME_SIZE);
return 0;
}
+#endif
enum ice_pkg_type
ice_load_pkg_type(struct ice_hw *hw)
@@ -1714,6 +1716,7 @@ ice_load_pkg_type(struct ice_hw *hw)
return package_type;
}
+#ifndef RTE_EXEC_ENV_WINDOWS
static int ice_load_pkg(struct rte_eth_dev *dev)
{
struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -1785,6 +1788,7 @@ static int ice_load_pkg(struct rte_eth_dev *dev)
rte_free(buf);
return err;
}
+#endif
static void
ice_base_queue_get(struct ice_pf *pf)
@@ -2065,6 +2069,7 @@ ice_dev_init(struct rte_eth_dev *dev)
return -EINVAL;
}
+#ifndef RTE_EXEC_ENV_WINDOWS
ret = ice_load_pkg(dev);
if (ret) {
if (ad->devargs.safe_mode_support == 0) {
@@ -2077,6 +2082,7 @@ ice_dev_init(struct rte_eth_dev *dev)
"Entering Safe Mode");
ad->is_safe_mode = 1;
}
+#endif
PMD_INIT_LOG(INFO, "FW %d.%d.%05d API %d.%d",
hw->fw_maj_ver, hw->fw_min_ver, hw->fw_build,