[v4] net/iavf: fix wrong RSS hash update
Checks
Commit Message
This patch change judgment statements to disable RSS for vf
when users need to disable RSS or RSS hash function configured
is not supported.
Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")
Cc: stable@dpdk.org
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
v4: clear existing RSS when rss_hf = 0.
v3: fix the same issue for both pf and vf.
---
drivers/net/iavf/iavf_ethdev.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
Comments
On 3/15/2021 12:59 AM, Wenjun Wu wrote:
> This patch change judgment statements to disable RSS for vf
> when users need to disable RSS or RSS hash function configured
> is not supported.
>
> Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
>
> ---
> v4: clear existing RSS when rss_hf = 0.
> v3: fix the same issue for both pf and vf.
Applied to dpdk-next-net-intel.
@@ -1250,8 +1250,17 @@ iavf_dev_rss_hash_update(struct rte_eth_dev *dev,
if (ret)
return ret;
- if (rss_conf->rss_hf == 0)
+ if (rss_conf->rss_hf == 0) {
+ vf->rss_hf = 0;
+ ret = iavf_set_hena(adapter, 0);
+
+ /* It is a workaround, temporarily allow error to be returned
+ * due to possible lack of PF handling for hena = 0.
+ */
+ if (ret)
+ PMD_DRV_LOG(WARNING, "fail to clean existing RSS, lack PF support");
return 0;
+ }
if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) {
/* Clear existing RSS. */