net/vmxnet3: build on Windows
Checks
Commit Message
Remove OS restriction and update release notes.
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
DPDK-kmods patch: http://patchwork.dpdk.org/patch/88046/
doc/guides/rel_notes/release_21_05.rst | 2 ++
drivers/net/vmxnet3/meson.build | 6 ------
2 files changed, 2 insertions(+), 6 deletions(-)
Comments
On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> Remove OS restriction and update release notes.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Build looks good, but I wonder if anyone tested the driver on Windows.
Yong,
Do you have any plan to test the driver on Windows, should we wait your ack?
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Date: Tuesday, March 23, 2021 at 9:11 AM
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> Remove OS restriction and update release notes.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Build looks good, but I wonder if anyone tested the driver on Windows.
Yong,
Do you have any plan to test the driver on Windows, should we wait your ack?
Ferruh,
Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
Yong
2021-03-23 17:13 (UTC+0000), Yong Wang:
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Date: Tuesday, March 23, 2021 at 9:11 AM
> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
> Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>
> On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> > Remove OS restriction and update release notes.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Build looks good, but I wonder if anyone tested the driver on Windows.
>
> Yong,
>
> Do you have any plan to test the driver on Windows, should we wait your ack?
>
> Ferruh,
>
> Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
For the record, I tested the following setup with Windows Server 2019 in QEMU
(-device vmxnet3) before submitting the patch:
[ping ] [ ] [ ping]
[OS ] [ dpdk-skeleton ] [ OS]
[virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
[Debian VM] [ Windows VM ] [Debian VM]
Debian VMs successfully ping'd each other with Windows forwarding.
-----Original Message-----
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Date: Wednesday, March 24, 2021 at 10:50 AM
To: Yong Wang <yongwang@vmware.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
2021-03-23 17:13 (UTC+0000), Yong Wang:
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Date: Tuesday, March 23, 2021 at 9:11 AM
> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
> Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>
> On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> > Remove OS restriction and update release notes.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Build looks good, but I wonder if anyone tested the driver on Windows.
>
> Yong,
>
> Do you have any plan to test the driver on Windows, should we wait your ack?
>
> Ferruh,
>
> Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
For the record, I tested the following setup with Windows Server 2019 in QEMU
(-device vmxnet3) before submitting the patch:
[ping ] [ ] [ ping]
[OS ] [ dpdk-skeleton ] [ OS]
[virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
[Debian VM] [ Windows VM ] [Debian VM]
Debian VMs successfully ping'd each other with Windows forwarding.
Thanks Dmitri for the testing results. It will be good if you can try some basic tcp/udp traffic as well.
Acked-by: Yong Wang <yongwang@vmware.com>
On 3/24/2021 6:32 PM, Yong Wang wrote:
>
> -----Original Message-----
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Date: Wednesday, March 24, 2021 at 10:50 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>
> 2021-03-23 17:13 (UTC+0000), Yong Wang:
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Date: Tuesday, March 23, 2021 at 9:11 AM
> > To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
> > Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
> >
> > On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> > > Remove OS restriction and update release notes.
> > >
> > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >
> > Build looks good, but I wonder if anyone tested the driver on Windows.
> >
> > Yong,
> >
> > Do you have any plan to test the driver on Windows, should we wait your ack?
> >
> > Ferruh,
> >
> > Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
>
> For the record, I tested the following setup with Windows Server 2019 in QEMU
> (-device vmxnet3) before submitting the patch:
>
> [ping ] [ ] [ ping]
> [OS ] [ dpdk-skeleton ] [ OS]
> [virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
> [Debian VM] [ Windows VM ] [Debian VM]
>
> Debian VMs successfully ping'd each other with Windows forwarding.
>
> Thanks Dmitri for the testing results. It will be good if you can try some basic tcp/udp traffic as well.
>
> Acked-by: Yong Wang <yongwang@vmware.com>
>
Applied to dpdk-next-net/main, thanks.
Added the above test detail to commit log for record.
@@ -55,6 +55,8 @@ New Features
Also, make sure to start the actual text at the margin.
=======================================================
+* **Enabled vmxnet3 PMD on Windows.**
+
Removed Items
-------------
@@ -1,12 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
-if is_windows
- build = false
- reason = 'not supported on Windows'
- subdir_done()
-endif
-
sources += files(
'vmxnet3_ethdev.c',
'vmxnet3_rxtx.c',