[1/4] common/mlx5: add missing SPDX tag for windows headers

Message ID 20210316210027.37213-2-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series Cleanup last remaining SPDX issues |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger March 16, 2021, 9 p.m. UTC
  These files were added without requires SPDX headers.

Fixes: 7525ebd8ebb0 ("common/mlx5: add glue functions on Windows")
Cc: talshn@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/mlx5/windows/mlx5_win_defs.h | 4 ++--
 drivers/common/mlx5/windows/mlx5_win_ext.h  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
  

Comments

Tal Shnaiderman March 17, 2021, 9:15 a.m. UTC | #1
> Subject: [PATCH 1/4] common/mlx5: add missing SPDX tag for windows
> headers
> 
> External email: Use caution opening links or attachments
> 
> 
> These files were added without requires SPDX headers.
> 
> Fixes: 7525ebd8ebb0 ("common/mlx5: add glue functions on Windows")
> Cc: talshn@nvidia.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/common/mlx5/windows/mlx5_win_defs.h | 4 ++--
> drivers/common/mlx5/windows/mlx5_win_ext.h  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h
> b/drivers/common/mlx5/windows/mlx5_win_defs.h
> index 8a1c2c5af94f..47bfc907e7d3 100644
> --- a/drivers/common/mlx5/windows/mlx5_win_defs.h
> +++ b/drivers/common/mlx5/windows/mlx5_win_defs.h
> @@ -1,7 +1,7 @@
> -/*
> +/* SPDX-License-Identifier: BSD-3-Clause
>   * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
> - *
>   */
> +
>  #ifndef __MLX5_WIN_DEFS_H__
>  #define __MLX5_WIN_DEFS_H__
> 
> diff --git a/drivers/common/mlx5/windows/mlx5_win_ext.h
> b/drivers/common/mlx5/windows/mlx5_win_ext.h
> index 60610df6b250..b5d4484a1366 100644
> --- a/drivers/common/mlx5/windows/mlx5_win_ext.h
> +++ b/drivers/common/mlx5/windows/mlx5_win_ext.h
> @@ -1,7 +1,7 @@
> -/*
> +/* SPDX-License-Identifier: BSD-3-Clause
>   * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
> - *
>   */
> +
>  #ifndef __MLX5_WIN_ETX_H__
>  #define __MLX5_WIN_ETX_H__
> 
> --
> 2.30.2

Thanks Stephen,

Doesn't this patch needs to cc stable as well since those files were added in 21.02?

Acked-by: Tal Shnaiderman <talshn@nvidia.com>
  
Thomas Monjalon May 19, 2021, 8:36 a.m. UTC | #2
> > These files were added without requires SPDX headers.
> > 
> > Fixes: 7525ebd8ebb0 ("common/mlx5: add glue functions on Windows")
> > Cc: talshn@nvidia.com
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > -/*
> > +/* SPDX-License-Identifier: BSD-3-Clause
> >   * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
> > - *
> >   */
> > +
> >  #ifndef __MLX5_WIN_ETX_H__
> >  #define __MLX5_WIN_ETX_H__
> > 
> > --
> > 2.30.2
> 
> Thanks Stephen,
> 
> Doesn't this patch needs to cc stable as well since those files were added in 21.02?
> 
> Acked-by: Tal Shnaiderman <talshn@nvidia.com>

Yes will add stable while applying.
  

Patch

diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers/common/mlx5/windows/mlx5_win_defs.h
index 8a1c2c5af94f..47bfc907e7d3 100644
--- a/drivers/common/mlx5/windows/mlx5_win_defs.h
+++ b/drivers/common/mlx5/windows/mlx5_win_defs.h
@@ -1,7 +1,7 @@ 
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
- *
  */
+
 #ifndef __MLX5_WIN_DEFS_H__
 #define __MLX5_WIN_DEFS_H__
 
diff --git a/drivers/common/mlx5/windows/mlx5_win_ext.h b/drivers/common/mlx5/windows/mlx5_win_ext.h
index 60610df6b250..b5d4484a1366 100644
--- a/drivers/common/mlx5/windows/mlx5_win_ext.h
+++ b/drivers/common/mlx5/windows/mlx5_win_ext.h
@@ -1,7 +1,7 @@ 
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (C) Mellanox Technologies, Ltd. 2001-2020.
- *
  */
+
 #ifndef __MLX5_WIN_ETX_H__
 #define __MLX5_WIN_ETX_H__