| Message ID | 20210316085832.942481-1-andrew.rybchenko@oktetlabs.ru (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38F39A054F; Tue, 16 Mar 2021 09:58:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E004B242862; Tue, 16 Mar 2021 09:58:39 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 8894C4069F for <dev@dpdk.org>; Tue, 16 Mar 2021 09:58:38 +0100 (CET) Received: by shelob.oktetlabs.ru (Postfix, from userid 122) id 46BC17F5D6; Tue, 16 Mar 2021 11:58:38 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD autolearn=no autolearn_force=no version=3.4.2 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 846077F4A0; Tue, 16 Mar 2021 11:58:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 846077F4A0 Authentication-Results: shelob.oktetlabs.ru/846077F4A0; dkim=none; dkim-atps=neutral From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org Date: Tue, 16 Mar 2021 11:58:24 +0300 Message-Id: <20210316085832.942481-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru> References: <20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 0/8] common/sfc_efx: prepare to introduce vDPA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
common/sfc_efx: prepare to introduce vDPA driver
|
|
Message
Andrew Rybchenko
March 16, 2021, 8:58 a.m. UTC
Update base driver to provide functionality required by vDPA driver. Factor out helper functions to be shared by net and vDPA drivers. v4: - fix Copyright year v3: - one more attempt to fix windows build breakage v2: - fix windows build breakage - do not build common/sfc_efx in the case of windows - remove undefined efx_virtio_* functions from version.map (since EFSYS_OPT_VIRTIO is disabled) Vijay Kumar Srivastava (6): common/sfc_efx/base: add virtio build dependency common/sfc_efx/base: add support to get virtio features common/sfc_efx/base: add support to verify virtio features common/sfc_efx: add support to get the device class net/sfc: skip driver probe for incompatible device class drivers: add common driver API to get efx family Vijay Srivastava (2): common/sfc_efx/base: add base virtio support for vDPA common/sfc_efx/base: add API to get VirtQ doorbell offset doc/guides/nics/sfc_efx.rst | 8 + drivers/common/meson.build | 2 +- drivers/common/sfc_efx/base/efx.h | 142 ++++++++ drivers/common/sfc_efx/base/efx_check.h | 9 + drivers/common/sfc_efx/base/efx_impl.h | 42 +++ drivers/common/sfc_efx/base/efx_virtio.c | 340 ++++++++++++++++++ drivers/common/sfc_efx/base/meson.build | 2 + drivers/common/sfc_efx/base/rhead_impl.h | 37 ++ drivers/common/sfc_efx/base/rhead_virtio.c | 379 +++++++++++++++++++++ drivers/common/sfc_efx/efsys.h | 2 + drivers/common/sfc_efx/meson.build | 6 + drivers/common/sfc_efx/sfc_efx.c | 105 ++++++ drivers/common/sfc_efx/sfc_efx.h | 44 +++ drivers/common/sfc_efx/version.map | 3 + drivers/meson.build | 1 + drivers/net/sfc/sfc.c | 61 +--- drivers/net/sfc/sfc.h | 1 + drivers/net/sfc/sfc_ethdev.c | 7 + drivers/net/sfc/sfc_kvargs.c | 1 + 19 files changed, 1134 insertions(+), 58 deletions(-) create mode 100644 drivers/common/sfc_efx/base/efx_virtio.c create mode 100644 drivers/common/sfc_efx/base/rhead_virtio.c create mode 100644 drivers/common/sfc_efx/sfc_efx.h
Comments
On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: > Update base driver to provide functionality required by vDPA driver. > > Factor out helper functions to be shared by net and vDPA drivers. > > v4: > - fix Copyright year > > v3: > - one more attempt to fix windows build breakage > > v2: > - fix windows build breakage - do not build common/sfc_efx in the case > of windows > - remove undefined efx_virtio_* functions from version.map (since > EFSYS_OPT_VIRTIO is disabled) > > Vijay Kumar Srivastava (6): > common/sfc_efx/base: add virtio build dependency > common/sfc_efx/base: add support to get virtio features > common/sfc_efx/base: add support to verify virtio features > common/sfc_efx: add support to get the device class > net/sfc: skip driver probe for incompatible device class > drivers: add common driver API to get efx family > > Vijay Srivastava (2): > common/sfc_efx/base: add base virtio support for vDPA > common/sfc_efx/base: add API to get VirtQ doorbell offset > The driver adds vDPA support, I believe it worth mentioning in the driver documentation and in the release notes, can you please send a new version with documentation updates?
On 3/16/21 2:26 PM, Ferruh Yigit wrote: > On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: >> Update base driver to provide functionality required by vDPA driver. >> >> Factor out helper functions to be shared by net and vDPA drivers. >> >> v4: >> - fix Copyright year >> >> v3: >> - one more attempt to fix windows build breakage >> >> v2: >> - fix windows build breakage - do not build common/sfc_efx in the case >> of windows >> - remove undefined efx_virtio_* functions from version.map (since >> EFSYS_OPT_VIRTIO is disabled) >> >> Vijay Kumar Srivastava (6): >> common/sfc_efx/base: add virtio build dependency >> common/sfc_efx/base: add support to get virtio features >> common/sfc_efx/base: add support to verify virtio features >> common/sfc_efx: add support to get the device class >> net/sfc: skip driver probe for incompatible device class >> drivers: add common driver API to get efx family >> >> Vijay Srivastava (2): >> common/sfc_efx/base: add base virtio support for vDPA >> common/sfc_efx/base: add API to get VirtQ doorbell offset >> > > The driver adds vDPA support, I believe it worth mentioning in the > driver documentation and in the release notes, can you please send a > new version with documentation updates? No, no. It is just preparations to introduce the vDPA driver. vDPA drier will be added in a subsequent patches and I'll ensure that it is mentioned in release notes etc.
On 3/16/2021 11:30 AM, Andrew Rybchenko wrote: > On 3/16/21 2:26 PM, Ferruh Yigit wrote: >> On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: >>> Update base driver to provide functionality required by vDPA driver. >>> >>> Factor out helper functions to be shared by net and vDPA drivers. >>> >>> v4: >>> - fix Copyright year >>> >>> v3: >>> - one more attempt to fix windows build breakage >>> >>> v2: >>> - fix windows build breakage - do not build common/sfc_efx in the case >>> of windows >>> - remove undefined efx_virtio_* functions from version.map (since >>> EFSYS_OPT_VIRTIO is disabled) >>> >>> Vijay Kumar Srivastava (6): >>> common/sfc_efx/base: add virtio build dependency >>> common/sfc_efx/base: add support to get virtio features >>> common/sfc_efx/base: add support to verify virtio features >>> common/sfc_efx: add support to get the device class >>> net/sfc: skip driver probe for incompatible device class >>> drivers: add common driver API to get efx family >>> >>> Vijay Srivastava (2): >>> common/sfc_efx/base: add base virtio support for vDPA >>> common/sfc_efx/base: add API to get VirtQ doorbell offset >>> >> >> The driver adds vDPA support, I believe it worth mentioning in the >> driver documentation and in the release notes, can you please send a >> new version with documentation updates? > > No, no. It is just preparations to introduce the vDPA driver. > vDPA drier will be added in a subsequent patches and I'll > ensure that it is mentioned in release notes etc. > Got it, that answers a few of unused functions too.. Please be sure to document.
On 3/16/2021 11:32 AM, Ferruh Yigit wrote: > On 3/16/2021 11:30 AM, Andrew Rybchenko wrote: >> On 3/16/21 2:26 PM, Ferruh Yigit wrote: >>> On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: >>>> Update base driver to provide functionality required by vDPA driver. >>>> >>>> Factor out helper functions to be shared by net and vDPA drivers. >>>> >>>> v4: >>>> - fix Copyright year >>>> >>>> v3: >>>> - one more attempt to fix windows build breakage >>>> >>>> v2: >>>> - fix windows build breakage - do not build common/sfc_efx in the case >>>> of windows >>>> - remove undefined efx_virtio_* functions from version.map (since >>>> EFSYS_OPT_VIRTIO is disabled) >>>> >>>> Vijay Kumar Srivastava (6): >>>> common/sfc_efx/base: add virtio build dependency >>>> common/sfc_efx/base: add support to get virtio features >>>> common/sfc_efx/base: add support to verify virtio features >>>> common/sfc_efx: add support to get the device class >>>> net/sfc: skip driver probe for incompatible device class >>>> drivers: add common driver API to get efx family >>>> >>>> Vijay Srivastava (2): >>>> common/sfc_efx/base: add base virtio support for vDPA >>>> common/sfc_efx/base: add API to get VirtQ doorbell offset >>>> >>> >>> The driver adds vDPA support, I believe it worth mentioning in the >>> driver documentation and in the release notes, can you please send a >>> new version with documentation updates? >> >> No, no. It is just preparations to introduce the vDPA driver. >> vDPA drier will be added in a subsequent patches and I'll >> ensure that it is mentioned in release notes etc. >> > > Got it, that answers a few of unused functions too.. Please be sure to document. I mean with coming patches, where appropriate.
On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: > Update base driver to provide functionality required by vDPA driver. > > Factor out helper functions to be shared by net and vDPA drivers. > > v4: > - fix Copyright year > > v3: > - one more attempt to fix windows build breakage > > v2: > - fix windows build breakage - do not build common/sfc_efx in the case > of windows > - remove undefined efx_virtio_* functions from version.map (since > EFSYS_OPT_VIRTIO is disabled) > > Vijay Kumar Srivastava (6): > common/sfc_efx/base: add virtio build dependency > common/sfc_efx/base: add support to get virtio features > common/sfc_efx/base: add support to verify virtio features > common/sfc_efx: add support to get the device class > net/sfc: skip driver probe for incompatible device class > drivers: add common driver API to get efx family > > Vijay Srivastava (2): > common/sfc_efx/base: add base virtio support for vDPA > common/sfc_efx/base: add API to get VirtQ doorbell offset > Series applied to dpdk-next-net/main, thanks.