mbox series

[v2,0/8] common/sfc_efx: prepare to introduce vDPA driver

Message ID 20210315135823.605774-1-andrew.rybchenko@oktetlabs.ru (mailing list archive)
Headers
Series common/sfc_efx: prepare to introduce vDPA driver |

Message

Andrew Rybchenko March 15, 2021, 1:58 p.m. UTC 
  Update base driver to provide functionality required by vDPA driver.

Factor out helper functions to be shared by net and vDPA drivers.

v2:
 - fix windows build breakage - do not build common/sfc_efx in the case
   of windows
 - remove undefined efx_virtio_* functions from version.map (since
   EFSYS_OPT_VIRTIO is disabled)

Vijay Kumar Srivastava (6):
  common/sfc_efx/base: add virtio build dependency
  common/sfc_efx/base: add support to get virtio features
  common/sfc_efx/base: add support to verify virtio features
  common/sfc_efx: add support to get the device class
  net/sfc: skip driver probe for incompatible device class
  drivers: add common driver API to get efx family

Vijay Srivastava (2):
  common/sfc_efx/base: add base virtio support for vDPA
  common/sfc_efx/base: add API to get VirtQ doorbell offset

 doc/guides/nics/sfc_efx.rst                |   8 +
 drivers/common/meson.build                 |   2 +-
 drivers/common/sfc_efx/base/efx.h          | 142 ++++++++
 drivers/common/sfc_efx/base/efx_check.h    |   9 +
 drivers/common/sfc_efx/base/efx_impl.h     |  42 +++
 drivers/common/sfc_efx/base/efx_virtio.c   | 340 ++++++++++++++++++
 drivers/common/sfc_efx/base/meson.build    |   2 +
 drivers/common/sfc_efx/base/rhead_impl.h   |  37 ++
 drivers/common/sfc_efx/base/rhead_virtio.c | 379 +++++++++++++++++++++
 drivers/common/sfc_efx/efsys.h             |   2 +
 drivers/common/sfc_efx/meson.build         |   5 +
 drivers/common/sfc_efx/sfc_efx.c           | 105 ++++++
 drivers/common/sfc_efx/sfc_efx.h           |  44 +++
 drivers/common/sfc_efx/version.map         |   3 +
 drivers/meson.build                        |   1 +
 drivers/net/sfc/sfc.c                      |  61 +---
 drivers/net/sfc/sfc.h                      |   1 +
 drivers/net/sfc/sfc_ethdev.c               |   7 +
 drivers/net/sfc/sfc_kvargs.c               |   1 +
 19 files changed, 1133 insertions(+), 58 deletions(-)
 create mode 100644 drivers/common/sfc_efx/base/efx_virtio.c
 create mode 100644 drivers/common/sfc_efx/base/rhead_virtio.c
 create mode 100644 drivers/common/sfc_efx/sfc_efx.h

Comments

Ferruh Yigit March 15, 2021, 3:54 p.m. UTC | #1 
On 3/15/2021 1:58 PM, Andrew Rybchenko wrote:
> Update base driver to provide functionality required by vDPA driver.
> 
> Factor out helper functions to be shared by net and vDPA drivers.
> 
> v2:
>   - fix windows build breakage - do not build common/sfc_efx in the case
>     of windows
>   - remove undefined efx_virtio_* functions from version.map (since
>     EFSYS_OPT_VIRTIO is disabled)
> 
> Vijay Kumar Srivastava (6):
>    common/sfc_efx/base: add virtio build dependency
>    common/sfc_efx/base: add support to get virtio features
>    common/sfc_efx/base: add support to verify virtio features
>    common/sfc_efx: add support to get the device class
>    net/sfc: skip driver probe for incompatible device class
>    drivers: add common driver API to get efx family
> 
> Vijay Srivastava (2):
>    common/sfc_efx/base: add base virtio support for vDPA
>    common/sfc_efx/base: add API to get VirtQ doorbell offset
> 

build still fails for windows,
http://mails.dpdk.org/archives/test-report/2021-March/182539.html

I guess it is missing, "build=false":
   if is_windows
  +       build=false
          subdir_done()
   endif
Andrew Rybchenko March 16, 2021, 7:25 a.m. UTC | #2 
On 3/15/21 6:54 PM, Ferruh Yigit wrote:
> On 3/15/2021 1:58 PM, Andrew Rybchenko wrote:
>> Update base driver to provide functionality required by vDPA driver.
>>
>> Factor out helper functions to be shared by net and vDPA drivers.
>>
>> v2:
>>   - fix windows build breakage - do not build common/sfc_efx in the case
>>     of windows
>>   - remove undefined efx_virtio_* functions from version.map (since
>>     EFSYS_OPT_VIRTIO is disabled)
>>
>> Vijay Kumar Srivastava (6):
>>    common/sfc_efx/base: add virtio build dependency
>>    common/sfc_efx/base: add support to get virtio features
>>    common/sfc_efx/base: add support to verify virtio features
>>    common/sfc_efx: add support to get the device class
>>    net/sfc: skip driver probe for incompatible device class
>>    drivers: add common driver API to get efx family
>>
>> Vijay Srivastava (2):
>>    common/sfc_efx/base: add base virtio support for vDPA
>>    common/sfc_efx/base: add API to get VirtQ doorbell offset
>>
>
> build still fails for windows,
> http://mails.dpdk.org/archives/test-report/2021-March/182539.html
>
> I guess it is missing, "build=false":
>   if is_windows
>  +       build=false
>          subdir_done()
>   endif
>

Looks like fixed in v3. At least Intel compilation test is OK now.

Thanks,
Andrew.