Message ID | 20210312181720.242252-1-thomas@monjalon.net (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CE77A0547; Fri, 12 Mar 2021 19:17:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D226C1608CE; Fri, 12 Mar 2021 19:17:28 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 713891608CB for <dev@dpdk.org>; Fri, 12 Mar 2021 19:17:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id F15ED5C017C; Fri, 12 Mar 2021 13:17:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 12 Mar 2021 13:17:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=iKOmyFdMwHNjo 2u9FvpEDMZUbj7HBRAJ25YXhNSCU9U=; b=E4VkWGIES+gZYbgMyb+vVLl+aRsN8 MkJ5h2VCBEeUwffUczbGmco0OMkij3tqjy1Cvpk+rSRl52Tdsis8g81Xe8Rq+Sz+ AS8MqNQcRnzM6vk1ZN7jiRC74x4r0MpXDNflJlXrFXs28iYO6aV5aOvq+7rUJa0V OAbzkgmZliaQh1SwNWMGuBdVGgf3pybWDxwBW2F3hbHLlZ42JrxI2x+3sOwDMwzG 8MVPSaNtO+IKVRPW/vaqZsfJkO5V3hQhPCpa3ujjCv5vtlQLxhyub16XOjnY3nlF Uz046hHXuBxTDiffUBwu+HENiIaYnpDggJLwAffJ/v5HfgLwgXwq4vVJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=iKOmyFdMwHNjo2u9FvpEDMZUbj7HBRAJ25YXhNSCU9U=; b=N1flkDww UtrZfgkvt7tZz+M6xXVR4ne/ZzjCmxXNsjZE3dT+G9rCITke14H7xHiGelaD2WYF r6MZWDRyj++wlHe3m8q6ypdthNixK5iwAOUllkR8MvqLVP3dxQMZ4sfeGoXUqSux oQC7TLeDKGVc30s7J7b67BuO9FijV/1ncN4272XGaH8FFC4OhlXeu6xgHjQq8BAO 1wmf1+HvUN9bf4NNrXxxPdTm085pNExQEhZyc9QMtwKhwEcHSZvHEHBUymn0jHaY gUWM/TWxN/RJupkoU2pNY/f6XV9eSQD28OpW2rVWPUraORX58i0GBYpEqPo+QPLp 1n5GBpg2FTO8uw== X-ME-Sender: <xms:NrBLYKpgUpV6ye3qfmv6g-c3PKbT1pcWvm5SUhDRVX8W6af6gSbePQ> <xme:NrBLYIoAmme4rwa30xqHDLv70a3JRAqJdTSlu8WHUfU6BvnZhjonFVC4MR1eqexZv srSzE7SEe27S4ELxw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvvddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdehgfeivdejgedtve ehfefhteelfefgieevgfffveefjeegtdfguedthedtgeevnecukfhppeejjedrudefgedr vddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:NrBLYPOOppuK7V5CorzgLKTQUGqvLpPyPs1dBOtJVH3EMnLsMY4PzQ> <xmx:NrBLYJ6bQLHgxWbMnKMb86Go3_RW8iw-6YLjdVboOPWmllnkoRuVpQ> <xmx:NrBLYJ76PTpWLgLGfe0bV221TEORqzq2_MZ7K6HzUO6cUnxw1gMaCQ> <xmx:NrBLYLQ8KLVljyx4mBaS-z54ahc4Z7fHB7eAO1FC8PHoHwlwQ6k8Ow> Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BF5B3240054; Fri, 12 Mar 2021 13:17:25 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: david.marchand@redhat.com, bruce.richardson@intel.com, mb@smartsharesystems.com Date: Fri, 12 Mar 2021 19:17:09 +0100 Message-Id: <20210312181720.242252-1-thomas@monjalon.net> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210309233116.1934666-1-thomas@monjalon.net> References: <20210309233116.1934666-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 00/11] improve options help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
improve options help
|
|
Message
Thomas Monjalon
March 12, 2021, 6:17 p.m. UTC
The main intent of this series is to provide a nice help for the --log-level option. More patches are added to improve options help in general. v3: - fix use of RTE_LOG_MAX - accept (with warning) log level higher than RTE_LOG_MAX v2: - fix use of the new macro RTE_LOG_MAX in level parsing - improve parameters type and name while moving functions Thomas Monjalon (11): eal: explain argv behaviour during init eal: improve options usage text eal: use macros for help option eal: move private log functions eal: introduce maximum log level macro eal: catch invalid log level number eal: add log level help app: fix exit messages app: hook in EAL usage help app/regex: fix usage text app/testpmd: fix usage text app/pdump/main.c | 2 + app/proc-info/main.c | 2 + app/test-acl/main.c | 2 + app/test-bbdev/main.c | 3 +- app/test-compress-perf/comp_perf_options.h | 2 + .../comp_perf_options_parse.c | 10 +-- app/test-compress-perf/main.c | 3 +- app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 10 +-- app/test-crypto-perf/main.c | 3 +- app/test-fib/main.c | 8 ++ app/test-flow-perf/main.c | 63 ++++++++-------- app/test-pmd/parameters.c | 34 ++------- app/test-pmd/testpmd.c | 2 + app/test-pmd/testpmd.h | 1 + app/test-regex/main.c | 10 +-- app/test-sad/main.c | 7 ++ lib/librte_eal/common/eal_common_log.c | 50 ++++++++----- lib/librte_eal/common/eal_common_options.c | 73 ++++++++++++------- lib/librte_eal/common/eal_log.h | 32 ++++++++ lib/librte_eal/common/eal_private.h | 29 -------- lib/librte_eal/freebsd/eal.c | 10 +-- lib/librte_eal/include/rte_eal.h | 2 + lib/librte_eal/include/rte_log.h | 12 +++ lib/librte_eal/linux/eal.c | 17 +++-- lib/librte_eal/linux/eal_log.c | 4 +- lib/librte_eal/version.map | 3 + lib/librte_eal/windows/eal.c | 15 ++-- lib/librte_eal/windows/eal_log.c | 6 +- 29 files changed, 243 insertions(+), 174 deletions(-) create mode 100644 lib/librte_eal/common/eal_log.h
Comments
On Fri, Mar 12, 2021 at 07:17:09PM +0100, Thomas Monjalon wrote: > The main intent of this series is to provide a nice help > for the --log-level option. > More patches are added to improve options help in general. > > > v3: > - fix use of RTE_LOG_MAX > - accept (with warning) log level higher than RTE_LOG_MAX > v2: > - fix use of the new macro RTE_LOG_MAX in level parsing > - improve parameters type and name while moving functions > > Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
On 3/15/21 12:40 PM, Bruce Richardson wrote: > On Fri, Mar 12, 2021 at 07:17:09PM +0100, Thomas Monjalon wrote: >> The main intent of this series is to provide a nice help >> for the --log-level option. >> More patches are added to improve options help in general. >> >> >> v3: >> - fix use of RTE_LOG_MAX >> - accept (with warning) log level higher than RTE_LOG_MAX >> v2: >> - fix use of the new macro RTE_LOG_MAX in level parsing >> - improve parameters type and name while moving functions >> >> > Series-acked-by: Bruce Richardson <bruce.richardson@intel.com> > Series-acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>