diff mbox series

eal: fix return value comment

Message ID ed36dfebff28a0988e457e29256c2dc422b64064.1591434690.git.wangyunjian@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series eal: fix return value comment |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing warning Testing issues
ci/checkpatch success coding style OK

Commit Message

Yunjian Wang June 6, 2020, 9:17 a.m. UTC 
  From: Yunjian Wang <wangyunjian@huawei.com>

Fix few comments and add detailed comments for return value.

Fixes: 279b581c897d ("vfio: expose functions")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 lib/librte_eal/include/rte_vfio.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Burakov, Anatoly Feb. 9, 2021, 1:51 p.m. UTC | #1 
On 06-Jun-20 10:17 AM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> Fix few comments and add detailed comments for return value.
> 
> Fixes: 279b581c897d ("vfio: expose functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
David Marchand March 3, 2021, 8:44 a.m. UTC | #2 
On Tue, Feb 9, 2021 at 2:52 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
> On 06-Jun-20 10:17 AM, wangyunjian wrote:
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > Fix few comments and add detailed comments for return value.
> >
> > Fixes: 279b581c897d ("vfio: expose functions")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/librte_eal/include/rte_vfio.h b/lib/librte_eal/include/rte_vfio.h
index 20ed8c4..15172bf 100644
--- a/lib/librte_eal/include/rte_vfio.h
+++ b/lib/librte_eal/include/rte_vfio.h
@@ -156,7 +156,7 @@  int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
  *   kernel module name.
  *
  * @return
- *   !0 if true.
+ *   1 if true.
  *   0 otherwise.
  */
 int rte_vfio_is_enabled(const char *modname);
@@ -168,8 +168,9 @@  int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
  * an error on BSD.
  *
  * @return
- *   !0 if true.
- *   0 otherwise.
+ *   1 if true.
+ *   0 if false.
+ *   <0 for errors
  */
 int rte_vfio_noiommu_is_enabled(void);