Message ID | 20210108082127.1061538-1-ruifeng.wang@arm.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0253A0524; Fri, 8 Jan 2021 09:21:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFF4B140E55; Fri, 8 Jan 2021 09:21:49 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 3BD4A140D48 for <dev@dpdk.org>; Fri, 8 Jan 2021 09:21:48 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7B3531B; Fri, 8 Jan 2021 00:21:47 -0800 (PST) Received: from net-arm-n1amp-01.shanghai.arm.com (net-arm-n1amp-01.shanghai.arm.com [10.169.208.220]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 27B053F70D; Fri, 8 Jan 2021 00:21:44 -0800 (PST) From: Ruifeng Wang <ruifeng.wang@arm.com> To: Cc: dev@dpdk.org, nd@arm.com, vladimir.medvedkin@intel.com, jerinj@marvell.com, drc@linux.vnet.ibm.com, honnappa.nagarahalli@arm.com, Ruifeng Wang <ruifeng.wang@arm.com> Date: Fri, 8 Jan 2021 08:21:22 +0000 Message-Id: <20210108082127.1061538-1-ruifeng.wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | lpm lookupx4 fixes | |
Message
Ruifeng Wang
Jan. 8, 2021, 8:21 a.m. UTC
This series fixed bug in lpm4 vector lookup implementations. When more than 256 tbl8 groups are created, lookupx4 could retrieve next hop data from wrong group. The bug is there since next_hop field was expanded from 8-bit to 24-bit, and inherited by other implementations. Also updated test case to improve coverage to detect such failure. Ruifeng Wang (4): lpm: fix vector lookup for Arm lpm: fix vector lookup for x86 lpm: fix vector lookup for ppc64 test/lpm: improve coverage on tbl8 app/test/test_lpm.c | 22 ++++++++++++++-------- lib/librte_lpm/rte_lpm_altivec.h | 8 ++++---- lib/librte_lpm/rte_lpm_neon.h | 8 ++++---- lib/librte_lpm/rte_lpm_sse.h | 8 ++++---- 4 files changed, 26 insertions(+), 20 deletions(-)
Comments
On Fri, Jan 8, 2021 at 9:22 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote: > > This series fixed bug in lpm4 vector lookup implementations. > When more than 256 tbl8 groups are created, lookupx4 could > retrieve next hop data from wrong group. > The bug is there since next_hop field was expanded from > 8-bit to 24-bit, and inherited by other implementations. This is a single issue: I would squash those 3 patches as a single patch (with 3 Fixes: tags). > > Also updated test case to improve coverage to detect such > failure. > > Ruifeng Wang (4): > lpm: fix vector lookup for Arm > lpm: fix vector lookup for x86 > lpm: fix vector lookup for ppc64 > test/lpm: improve coverage on tbl8 Reviews please?
Hi Ruifeng, LGTM, Thanks! On 08/01/2021 08:21, Ruifeng Wang wrote: > This series fixed bug in lpm4 vector lookup implementations. > When more than 256 tbl8 groups are created, lookupx4 could > retrieve next hop data from wrong group. > The bug is there since next_hop field was expanded from > 8-bit to 24-bit, and inherited by other implementations. > > Also updated test case to improve coverage to detect such > failure. > > Ruifeng Wang (4): > lpm: fix vector lookup for Arm > lpm: fix vector lookup for x86 > lpm: fix vector lookup for ppc64 > test/lpm: improve coverage on tbl8 > > app/test/test_lpm.c | 22 ++++++++++++++-------- > lib/librte_lpm/rte_lpm_altivec.h | 8 ++++---- > lib/librte_lpm/rte_lpm_neon.h | 8 ++++---- > lib/librte_lpm/rte_lpm_sse.h | 8 ++++---- > 4 files changed, 26 insertions(+), 20 deletions(-) > Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Wednesday, January 13, 2021 10:53 PM > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Vladimir Medvedkin > <vladimir.medvedkin@intel.com>; Bruce Richardson > <bruce.richardson@intel.com> > Cc: dev <dev@dpdk.org>; nd <nd@arm.com>; jerinj@marvell.com; David > Christensen <drc@linux.vnet.ibm.com>; Honnappa Nagarahalli > <Honnappa.Nagarahalli@arm.com> > Subject: Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes > > On Fri, Jan 8, 2021 at 9:22 AM Ruifeng Wang <ruifeng.wang@arm.com> > wrote: > > > > This series fixed bug in lpm4 vector lookup implementations. > > When more than 256 tbl8 groups are created, lookupx4 could retrieve > > next hop data from wrong group. > > The bug is there since next_hop field was expanded from 8-bit to > > 24-bit, and inherited by other implementations. > > This is a single issue: I would squash those 3 patches as a single patch (with 3 > Fixes: tags). I split the patch for review purpose. It is OK to squash them into a single one on merge. Thank you. > > > > > Also updated test case to improve coverage to detect such failure. > > > > Ruifeng Wang (4): > > lpm: fix vector lookup for Arm > > lpm: fix vector lookup for x86 > > lpm: fix vector lookup for ppc64 > > test/lpm: improve coverage on tbl8 > > Reviews please? > > > -- > David Marchand