Message ID | 20201127101514.47329-1-ruifeng.wang@arm.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AFF4A0524; Fri, 27 Nov 2020 11:15:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2FABC930; Fri, 27 Nov 2020 11:15:33 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 9E609C90C for <dev@dpdk.org>; Fri, 27 Nov 2020 11:15:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 119FC1516; Fri, 27 Nov 2020 02:15:29 -0800 (PST) Received: from net-arm-kp920-01.shanghai.arm.com (net-arm-kp920-01.shanghai.arm.com [10.169.210.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5CD3E3F71F; Fri, 27 Nov 2020 02:15:27 -0800 (PST) From: Ruifeng Wang <ruifeng.wang@arm.com> To: Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com, Ruifeng Wang <ruifeng.wang@arm.com> Date: Fri, 27 Nov 2020 18:15:12 +0800 Message-Id: <20201127101514.47329-1-ruifeng.wang@arm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201127080903.26817-1-ruifeng.wang@arm.com> References: <20201127080903.26817-1-ruifeng.wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/2] gcc build fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | gcc build fix | |
Message
Ruifeng Wang
Nov. 27, 2020, 10:15 a.m. UTC
This series fixed issues found when building project with Gcc '-O0' option. Ruifeng Wang (2): eal/arm: fix gcc build for optimization level 0 net/igc: fix gcc build for optimization level 0 drivers/net/igc/base/meson.build | 3 ++- lib/librte_eal/arm/include/rte_atomic_64.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
Comments
27/11/2020 11:15, Ruifeng Wang: > This series fixed issues found when building project > with Gcc '-O0' option. > > Ruifeng Wang (2): > eal/arm: fix gcc build for optimization level 0 > net/igc: fix gcc build for optimization level 0 No comment on the v2? Ruifeng, why nobody was Cc'ed? You don't want reviews? I am not going to accept such last minute fix if there is no strong proof this v2 is good.
> -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Friday, November 27, 2020 9:36 PM > To: Ruifeng Wang <Ruifeng.Wang@arm.com> > Cc: dev@dpdk.org; Honnappa Nagarahalli > <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; jerinj@marvell.com; > bruce.richardson@intel.com; ferruh.yigit@intel.com; Vimal Chungath > <vcchunga@amazon.com>; hemant.agrawal@nxp.com; > konstantin.ananyev@intel.com > Subject: Re: [dpdk-dev] [PATCH v2 0/2] gcc build fix > > 27/11/2020 11:15, Ruifeng Wang: > > This series fixed issues found when building project with Gcc '-O0' > > option. > > > > Ruifeng Wang (2): > > eal/arm: fix gcc build for optimization level 0 > > net/igc: fix gcc build for optimization level 0 > > No comment on the v2? > Ruifeng, why nobody was Cc'ed? You don't want reviews? Just used get-maintainer.sh to get Cc list. I should have added more people. > > I am not going to accept such last minute fix if there is no strong proof this v2 > is good. v2 1/2 patch has issue on earlier version Clang (eg. clang-6). I think we should continue with v1 approach. >