mbox series

[v2,0/6] update dpdk-setup.sh

Message ID 20201126141832.2277628-1-ferruh.yigit@intel.com (mailing list archive)
Headers
Series update dpdk-setup.sh |

Message

Ferruh Yigit Nov. 26, 2020, 2:18 p.m. UTC 
  This is an effort to update the dpdk-setup.sh script and keep it one
more year until whole functionality of it is replaced.

Other option is to remove it completely, please comment.

v2:
* Documentation updated

Ferruh Yigit (6):
  usertools/setup: remove make based build
  usertools/setup: remove inserting custom kernel modules
  usertools/setup: remove running built applications
  usertools/setup: remove hugepage functions
  usertools/setup: fix loading vfio module
  usertools/setup: move removal target to 21.11

 doc/guides/faq/faq.rst               |   4 +-
 doc/guides/linux_gsg/quick_start.rst | 247 ++------------------
 doc/guides/rel_notes/deprecation.rst |   2 +-
 usertools/dpdk-setup.sh              | 332 ++-------------------------
 4 files changed, 41 insertions(+), 544 deletions(-)

Comments

David Marchand Nov. 26, 2020, 4:30 p.m. UTC | #1 
On Thu, Nov 26, 2020 at 3:19 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> This is an effort to update the dpdk-setup.sh script and keep it one
> more year until whole functionality of it is replaced.
>
> Other option is to remove it completely, please comment.

I would simply remove this script.

Binding devices can be done with either driverctl (which is available
in most distributions) and dpdk-devbind.py (which a Howto already in
the doc).


As for permissions, what this script is doing is scary.
I would prefer users don't rely on this:
usertools/dpdk-setup.sh:        sudo chmod a+x /dev/vfio
usertools/dpdk-setup.sh:        sudo chmod 0666 /dev/vfio/*

OVS uses a udev rule for non root support:
https://github.com/openvswitch/ovs/blob/master/rhel/usr_lib_udev_rules.d_91-vfio.rules
We could describe this in the DPDK documentation.