Message ID | cover.1606229937.git.tredaelli@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EA37A04B1; Tue, 24 Nov 2020 16:14:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 371E2C928; Tue, 24 Nov 2020 16:14:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id CD127C910 for <dev@dpdk.org>; Tue, 24 Nov 2020 16:14:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606230866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HlxM9DFc0iq775sKRWKrdVbMCMbLeW9ELw8mbwrK2Uo=; b=FTmKon6kcb3qWjCNZEMX5uy9D+PHDE8L90sIX1ckPVqyW+1FsDUkZjtbrQvI0Cor6gmETf oJejiU9QM1eVFYR/JnC3ZGqJDdkQbQPz4mtmb3M2kJP2HoC5zhqkTR450AJFRW/6iwTmg8 Ta7dah3m3hV8xn7zFdEteQyXtS20w2E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-1AnbpbjUNpCvIxGCJVTO_g-1; Tue, 24 Nov 2020 10:14:24 -0500 X-MC-Unique: 1AnbpbjUNpCvIxGCJVTO_g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 651C48712F1; Tue, 24 Nov 2020 15:14:23 +0000 (UTC) Received: from localhost.localdomain (dhcp19-189-130.ntdv.lab.eng.bos.redhat.com [10.19.189.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3940A60873; Tue, 24 Nov 2020 15:14:22 +0000 (UTC) From: Timothy Redaelli <tredaelli@redhat.com> To: Anatoly Burakov <anatoly.burakov@intel.com> Cc: bruce.richardson@intel.com, dev@dpdk.org, stable@dpdk.org Date: Tue, 24 Nov 2020 16:14:13 +0100 Message-Id: <cover.1606229937.git.tredaelli@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=tredaelli@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Fix shared lib detection on Fedora/CentOS/RHEL
|
|
Message
Timothy Redaelli
Nov. 24, 2020, 3:14 p.m. UTC
Currently eal only tries to find shared lib by looking for .so files, but on Fedora, CentOS and RHEL the .so file is not installed by dpdk package, but it's only installed by dpdk-devel package, since .so files should not be necessary in order to run a program [1]. This series fix that by checking for .so.ABI_VERSION that should be available on any linux distribution. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Timothy Redaelli (2): eal: fix shared lib mode detection eal: fix loading of shared libs from driver plugin directories lib/librte_eal/common/eal_common_options.c | 9 ++++++--- lib/librte_eal/common/meson.build | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-)
Comments
On 11/24/20 4:14 PM, Timothy Redaelli wrote: > Currently eal only tries to find shared lib by looking for .so files, > but on Fedora, CentOS and RHEL the .so file is not installed by dpdk > package, but it's only installed by dpdk-devel package, since .so files > should not be necessary in order to run a program [1]. > > This series fix that by checking for .so.ABI_VERSION that should be > available on any linux distribution. > > [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages > > Timothy Redaelli (2): > eal: fix shared lib mode detection > eal: fix loading of shared libs from driver plugin directories > > lib/librte_eal/common/eal_common_options.c | 9 ++++++--- > lib/librte_eal/common/meson.build | 2 ++ > 2 files changed, 8 insertions(+), 3 deletions(-) > Looks good to me. For the series: Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime
> -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Timothy Redaelli > Sent: Tuesday, November 24, 2020 5:14 PM > To: Anatoly Burakov <anatoly.burakov@intel.com> > Cc: bruce.richardson@intel.com; dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 0/2] Fix shared lib detection on > Fedora/CentOS/RHEL > Tested-by: Ali Alnubani <alialnu@nvidia.com> Thanks, Ali
24/11/2020 16:13, Timothy Redaelli: > Currently eal only tries to find shared lib by looking for .so files, > but on Fedora, CentOS and RHEL the .so file is not installed by dpdk > package, but it's only installed by dpdk-devel package, since .so files > should not be necessary in order to run a program [1]. > > This series fix that by checking for .so.ABI_VERSION that should be > available on any linux distribution. > > [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages > > Timothy Redaelli (2): > eal: fix shared lib mode detection > eal: fix loading of shared libs from driver plugin directories This is very late to fix such core behaviour, but it has been well reviewed and tested: Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: David Marchand <david.marchand@redhat.com> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com> Tested-by: Ali Alnubani <alialnu@nvidia.com> Applied, thanks