ethdev: fix eCPRI header generic data field

Message ID 1606134581-10742-1-git-send-email-viacheslavo@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series ethdev: fix eCPRI header generic data field |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing warning Testing issues
ci/travis-robot success Travis build: passed

Commit Message

Slava Ovsiienko Nov. 23, 2020, 12:29 p.m. UTC
  There was a typo in eCPRI header definition.

Fixes: d164c609e70b ("ethdev: add eCPRI key fields to flow API")
Cc: stable@dpdk.org

Reported-by: Rani Sharoni <ranish@nvidia.com>
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 lib/librte_net/rte_ecpri.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Bing Zhao Nov. 23, 2020, 12:46 p.m. UTC | #1
Thanks a lot~

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Monday, November 23, 2020 8:30 PM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Rani Sharoni
> <ranish@nvidia.com>; ferruh.yigit@intel.com; Bing Zhao
> <bingz@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] ethdev: fix eCPRI header generic data field
> 
> There was a typo in eCPRI header definition.
> 
> Fixes: d164c609e70b ("ethdev: add eCPRI key fields to flow API")
> Cc: stable@dpdk.org
> 
> Reported-by: Rani Sharoni <ranish@nvidia.com>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  lib/librte_net/rte_ecpri.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_net/rte_ecpri.h b/lib/librte_net/rte_ecpri.h
> index d1c4838..1cbd6d8 100644
> --- a/lib/librte_net/rte_ecpri.h
> +++ b/lib/librte_net/rte_ecpri.h
> @@ -167,7 +167,7 @@ struct rte_ecpri_combined_msg_hdr {
>  		struct rte_ecpri_msg_iq_data type0;
>  		struct rte_ecpri_msg_bit_seq type1;
>  		struct rte_ecpri_msg_rtc_ctrl type2;
> -		struct rte_ecpri_msg_bit_seq type3;
> +		struct rte_ecpri_msg_gen_data type3;
>  		struct rte_ecpri_msg_rm_access type4;
>  		struct rte_ecpri_msg_delay_measure type5;
>  		struct rte_ecpri_msg_remote_reset type6;
> --
> 1.8.3.1

Reviewed-by: Bing Zhao <bingz@nvidia.com>
  
Ferruh Yigit Nov. 23, 2020, 2:39 p.m. UTC | #2
On 11/23/2020 12:46 PM, Bing Zhao wrote:
> Thanks a lot~
> 
>> -----Original Message-----
>> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>> Sent: Monday, November 23, 2020 8:30 PM
>> To: dev@dpdk.org
>> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Rani Sharoni
>> <ranish@nvidia.com>; ferruh.yigit@intel.com; Bing Zhao
>> <bingz@nvidia.com>; stable@dpdk.org
>> Subject: [PATCH] ethdev: fix eCPRI header generic data field
>>
>> There was a typo in eCPRI header definition.
>>
>> Fixes: d164c609e70b ("ethdev: add eCPRI key fields to flow API")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Rani Sharoni <ranish@nvidia.com>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>> ---
>>   lib/librte_net/rte_ecpri.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_net/rte_ecpri.h b/lib/librte_net/rte_ecpri.h
>> index d1c4838..1cbd6d8 100644
>> --- a/lib/librte_net/rte_ecpri.h
>> +++ b/lib/librte_net/rte_ecpri.h
>> @@ -167,7 +167,7 @@ struct rte_ecpri_combined_msg_hdr {
>>   		struct rte_ecpri_msg_iq_data type0;
>>   		struct rte_ecpri_msg_bit_seq type1;
>>   		struct rte_ecpri_msg_rtc_ctrl type2;
>> -		struct rte_ecpri_msg_bit_seq type3;
>> +		struct rte_ecpri_msg_gen_data type3;
>>   		struct rte_ecpri_msg_rm_access type4;
>>   		struct rte_ecpri_msg_delay_measure type5;
>>   		struct rte_ecpri_msg_remote_reset type6;
>> --
>> 1.8.3.1
> 
> Reviewed-by: Bing Zhao <bingz@nvidia.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Thomas Monjalon Nov. 26, 2020, 12:15 a.m. UTC | #3
> >> There was a typo in eCPRI header definition.
> >>
> >> Fixes: d164c609e70b ("ethdev: add eCPRI key fields to flow API")
> >> Cc: stable@dpdk.org
> >>
> >> Reported-by: Rani Sharoni <ranish@nvidia.com>
> >> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > 
> > Reviewed-by: Bing Zhao <bingz@nvidia.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
  

Patch

diff --git a/lib/librte_net/rte_ecpri.h b/lib/librte_net/rte_ecpri.h
index d1c4838..1cbd6d8 100644
--- a/lib/librte_net/rte_ecpri.h
+++ b/lib/librte_net/rte_ecpri.h
@@ -167,7 +167,7 @@  struct rte_ecpri_combined_msg_hdr {
 		struct rte_ecpri_msg_iq_data type0;
 		struct rte_ecpri_msg_bit_seq type1;
 		struct rte_ecpri_msg_rtc_ctrl type2;
-		struct rte_ecpri_msg_bit_seq type3;
+		struct rte_ecpri_msg_gen_data type3;
 		struct rte_ecpri_msg_rm_access type4;
 		struct rte_ecpri_msg_delay_measure type5;
 		struct rte_ecpri_msg_remote_reset type6;