Message ID | 1605871656-51819-1-git-send-email-oulijun@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40120A04DD; Fri, 20 Nov 2020 12:28:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C142C8DE; Fri, 20 Nov 2020 12:27:31 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 8FAB7C884 for <dev@dpdk.org>; Fri, 20 Nov 2020 12:27:26 +0100 (CET) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CcvQg1xRKz7057 for <dev@dpdk.org>; Fri, 20 Nov 2020 19:27:07 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Fri, 20 Nov 2020 19:27:14 +0800 From: Lijun Ou <oulijun@huawei.com> To: <ferruh.yigit@intel.com> CC: <dev@dpdk.org>, <linuxarm@huawei.com> Date: Fri, 20 Nov 2020 19:27:32 +0800 Message-ID: <1605871656-51819-1-git-send-email-oulijun@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 0/4] hns3 fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | hns3 fixes | |
Message
Lijun Ou
Nov. 20, 2020, 11:27 a.m. UTC
Here series are fixes for hns3 PMD driver. Chengchang Tang (1): net/hns3: fix unused queues with not disabled Huisong Li (1): net/hns3: fix segment fault with the multi-TC Lijun Ou (1): net/hns3: adjust printing MAC addresses in log Min Hu (Conor) (1): net/hns3: fix FEC state query drivers/net/hns3/hns3_dcb.c | 6 +++ drivers/net/hns3/hns3_ethdev.c | 91 +++++++++++++++++++++++---------------- drivers/net/hns3/hns3_ethdev.h | 2 + drivers/net/hns3/hns3_ethdev_vf.c | 32 +++++++------- drivers/net/hns3/hns3_rxtx.c | 35 +++++++++++---- 5 files changed, 106 insertions(+), 60 deletions(-)
Comments
On 11/20/2020 11:27 AM, Lijun Ou wrote: > Here series are fixes for hns3 PMD driver. > > Chengchang Tang (1): > net/hns3: fix unused queues with not disabled > > Huisong Li (1): > net/hns3: fix segment fault with the multi-TC > > Lijun Ou (1): > net/hns3: adjust printing MAC addresses in log > > Min Hu (Conor) (1): > net/hns3: fix FEC state query > Hi Lijun, How critical these fixes are? We have -rc5 today, and release this Wednesday, so these will be last minute fixes, if these are not critical I suggest postponing to next release and fixes can be backported from there to LTS.
Hi,Ferruh the first and second patch are critical.
On 11/20/2020 2:58 PM, oulijun wrote: < Moved to the bottom, please do not top post > >> >> -------------------------------------------------------------------------------- >> >> 欧丽军 >> Mobile:+86-18899774289 <tel:+86-18899774289> >> Email:oulijun@huawei.com <mailto:oulijun@huawei.com> >> >> >> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>> >> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>> >> *抄送: *dev<dev@dpdk.org <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com >> <mailto:linuxarm@huawei.com>> >> *主题: *Re: [PATCH 0/4] hns3 fixes >> *时间: *2020-11-20 22:39:13 >> >> On 11/20/2020 11:27 AM, Lijun Ou wrote: >>> Here series are fixes for hns3 PMD driver. >>> >>> Chengchang Tang (1): >>> net/hns3: fix unused queues with not disabled >>> >>> Huisong Li (1): >>> net/hns3: fix segment fault with the multi-TC >>> >>> Lijun Ou (1): >>> net/hns3: adjust printing MAC addresses in log >>> >>> Min Hu (Conor) (1): >>> net/hns3: fix FEC state query >>> >> >> Hi Lijun, >> >> How critical these fixes are? >> We have -rc5 today, and release this Wednesday, so these will be last minute >> fixes, if these are not critical I suggest postponing to next release and fixes >> can be backported from there to LTS. > > Hi,Ferruh > the first and second patch are critical. > OK, lets target first two patches for this release and defer rest.
On 11/20/2020 3:38 PM, Ferruh Yigit wrote: > On 11/20/2020 2:58 PM, oulijun wrote: > > < Moved to the bottom, please do not top post > > >>> >>> -------------------------------------------------------------------------------- >>> >>> 欧丽军 >>> Mobile:+86-18899774289 <tel:+86-18899774289> >>> Email:oulijun@huawei.com <mailto:oulijun@huawei.com> >>> >>> >>> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>> >>> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>> >>> *抄送: *dev<dev@dpdk.org <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com >>> <mailto:linuxarm@huawei.com>> >>> *主题: *Re: [PATCH 0/4] hns3 fixes >>> *时间: *2020-11-20 22:39:13 >>> >>> On 11/20/2020 11:27 AM, Lijun Ou wrote: >>>> Here series are fixes for hns3 PMD driver. >>>> >>>> Chengchang Tang (1): >>>> net/hns3: fix unused queues with not disabled >>>> >>>> Huisong Li (1): >>>> net/hns3: fix segment fault with the multi-TC >>>> >>>> Lijun Ou (1): >>>> net/hns3: adjust printing MAC addresses in log >>>> >>>> Min Hu (Conor) (1): >>>> net/hns3: fix FEC state query >>>> >>> >>> Hi Lijun, >>> >>> How critical these fixes are? >>> We have -rc5 today, and release this Wednesday, so these will be last minute >>> fixes, if these are not critical I suggest postponing to next release and fixes >>> can be backported from there to LTS. > > > > Hi,Ferruh > > the first and second patch are critical. > > > > OK, lets target first two patches for this release and defer rest. 1/4 & 2/4 applied to dpdk-next-net/main, thanks. 3/4 & 4/4 deferred to next release and patchwork status updated accordingly.
在 2020/11/20 23:38, Ferruh Yigit 写道: > On 11/20/2020 2:58 PM, oulijun wrote: > > < Moved to the bottom, please do not top post > > >>> >>> -------------------------------------------------------------------------------- >>> >>> >>> 欧丽军 >>> Mobile:+86-18899774289 <tel:+86-18899774289> >>> Email:oulijun@huawei.com <mailto:oulijun@huawei.com> >>> >>> >>> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com >>> <mailto:ferruh.yigit@intel.com>> >>> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>> >>> *抄送: *dev<dev@dpdk.org >>> <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com >>> <mailto:linuxarm@huawei.com>> >>> *主题: *Re: [PATCH 0/4] hns3 fixes >>> *时间: *2020-11-20 22:39:13 >>> >>> On 11/20/2020 11:27 AM, Lijun Ou wrote: >>>> Here series are fixes for hns3 PMD driver. >>>> >>>> Chengchang Tang (1): >>>> net/hns3: fix unused queues with not disabled >>>> >>>> Huisong Li (1): >>>> net/hns3: fix segment fault with the multi-TC >>>> >>>> Lijun Ou (1): >>>> net/hns3: adjust printing MAC addresses in log >>>> >>>> Min Hu (Conor) (1): >>>> net/hns3: fix FEC state query >>>> >>> >>> Hi Lijun, >>> >>> How critical these fixes are? >>> We have -rc5 today, and release this Wednesday, so these will be last >>> minute >>> fixes, if these are not critical I suggest postponing to next release >>> and fixes >>> can be backported from there to LTS. > > > > Hi,Ferruh > > the first and second patch are critical. > > > > OK, lets target first two patches for this release and defer rest. > . Hi, Ferruh Yigit Do I directly send a patchv2 package containing the two repaired patches or send a new patchset package? Thanks. Lijun Ou >
On 12/7/2020 2:54 PM, oulijun wrote: > > > 在 2020/11/20 23:38, Ferruh Yigit 写道: >> On 11/20/2020 2:58 PM, oulijun wrote: >> >> < Moved to the bottom, please do not top post > >> >>>> >>>> -------------------------------------------------------------------------------- >>>> >>>> >>>> 欧丽军 >>>> Mobile:+86-18899774289 <tel:+86-18899774289> >>>> Email:oulijun@huawei.com <mailto:oulijun@huawei.com> >>>> >>>> >>>> *发件人: *Ferruh Yigit<ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>> >>>> *收件人: *oulijun<oulijun@huawei.com <mailto:oulijun@huawei.com>> >>>> *抄送: *dev<dev@dpdk.org >>>> <mailto:dev@dpdk.org>>;Linuxarm<linuxarm@huawei.com >>>> <mailto:linuxarm@huawei.com>> >>>> *主题: *Re: [PATCH 0/4] hns3 fixes >>>> *时间: *2020-11-20 22:39:13 >>>> >>>> On 11/20/2020 11:27 AM, Lijun Ou wrote: >>>>> Here series are fixes for hns3 PMD driver. >>>>> >>>>> Chengchang Tang (1): >>>>> net/hns3: fix unused queues with not disabled >>>>> >>>>> Huisong Li (1): >>>>> net/hns3: fix segment fault with the multi-TC >>>>> >>>>> Lijun Ou (1): >>>>> net/hns3: adjust printing MAC addresses in log >>>>> >>>>> Min Hu (Conor) (1): >>>>> net/hns3: fix FEC state query >>>>> >>>> >>>> Hi Lijun, >>>> >>>> How critical these fixes are? >>>> We have -rc5 today, and release this Wednesday, so these will be last minute >>>> fixes, if these are not critical I suggest postponing to next release and fixes >>>> can be backported from there to LTS. >> > >> > Hi,Ferruh >> > the first and second patch are critical. >> > >> >> OK, lets target first two patches for this release and defer rest. >> . > Hi, Ferruh Yigit > Do I directly send a patchv2 package containing the two repaired patches or > send a new patchset package? > Hi Lijun, Sending a v2 with two patches is better, it enables us to see the history of patches and comments to previous version easier. > Thanks. > Lijun Ou >>