eal/windows: add stub for rte_intr_free_epoll_fd
Checks
Commit Message
Linux epoll mechanism is not implemented in Windows.
Add stub similarly to freeBSD.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> Linux epoll mechanism is not implemented in Windows.
>
> Add stub similarly to freeBSD.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> index 6c64a48f34..6f7a1c7acc 100644
> --- a/lib/librte_eal/windows/eal_interrupts.c
> +++ b/lib/librte_eal/windows/eal_interrupts.c
> @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
>
> return 0;
> }
> +
> +void
> +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
> +{
> + RTE_SET_USED(intr_handle);
> +}
This will not be of much use if you don't export it in
rte_eal_exports.def, right?
> Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for
> rte_intr_free_epoll_fd
>
> External email: Use caution opening links or attachments
>
>
> On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com>
> wrote:
> >
> > Linux epoll mechanism is not implemented in Windows.
> >
> > Add stub similarly to freeBSD.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> > lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/lib/librte_eal/windows/eal_interrupts.c
> > b/lib/librte_eal/windows/eal_interrupts.c
> > index 6c64a48f34..6f7a1c7acc 100644
> > --- a/lib/librte_eal/windows/eal_interrupts.c
> > +++ b/lib/librte_eal/windows/eal_interrupts.c
> > @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg),
> > void *arg)
> >
> > return 0;
> > }
> > +
> > +void
> > +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) {
> > + RTE_SET_USED(intr_handle);
> > +}
>
> This will not be of much use if you don't export it in rte_eal_exports.def,
> right?
You're absolutely right, thank you for noticing, I'll send a v2 promptly.
>
> --
> David Marchand
@@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
return 0;
}
+
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
+{
+ RTE_SET_USED(intr_handle);
+}