net/mlx5: fix RSS queue types validation
Checks
Commit Message
Recent patch fixed the RSS action validation, making sure hairpin queues
and standard queues are not used together in the same RSS action.
The variable used for comparison was declared and initialized within the
check loop, making the queue type comparison wrong.
This patch moves the variable declaration to the start of the function,
outside of the check loop.
Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types")
Signed-off-by: Dekel Peled <dekelp@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
Acked-by: Jack Min <jackmin@nvidia.com>
---
drivers/net/mlx5/mlx5_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Wednesday, November 18, 2020 11:24 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation
>
> Recent patch fixed the RSS action validation, making sure hairpin queues
> and standard queues are not used together in the same RSS action.
> The variable used for comparison was declared and initialized within the
> check loop, making the queue type comparison wrong.
>
> This patch moves the variable declaration to the start of the function,
> outside of the check loop.
>
> Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types")
>
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> Acked-by: Jack Min <jackmin@nvidia.com>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
On 11/18/2020 3:34 PM, Raslan Darawsheh wrote:
> Hi,
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
>> Sent: Wednesday, November 18, 2020 11:24 AM
>> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf Shuler
>> <shahafs@nvidia.com>; Matan Azrad <matan@nvidia.com>
>> Cc: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation
>>
>> Recent patch fixed the RSS action validation, making sure hairpin queues
>> and standard queues are not used together in the same RSS action.
>> The variable used for comparison was declared and initialized within the
>> check loop, making the queue type comparison wrong.
>>
>> This patch moves the variable declaration to the start of the function,
>> outside of the check loop.
>>
>> Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types")
>>
>> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
>> Acked-by: Ori Kam <orika@nvidia.com>
>> Acked-by: Jack Min <jackmin@nvidia.com>
>> ---
>
> Patch applied to next-net-mlx,
>
Squashed into relevant commit in next-net, thanks.
@@ -1411,6 +1411,7 @@ mlx5_validate_action_rss(struct rte_eth_dev *dev,
{
struct mlx5_priv *priv = dev->data->dev_private;
const struct rte_flow_action_rss *rss = action->conf;
+ enum mlx5_rxq_type rxq_type = MLX5_RXQ_TYPE_UNDEFINED;
unsigned int i;
if (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT &&
@@ -1476,7 +1477,6 @@ mlx5_validate_action_rss(struct rte_eth_dev *dev,
RTE_FLOW_ERROR_TYPE_ACTION_CONF,
NULL, "No queues configured");
for (i = 0; i != rss->queue_num; ++i) {
- enum mlx5_rxq_type rxq_type = MLX5_RXQ_TYPE_UNDEFINED;
struct mlx5_rxq_ctrl *rxq_ctrl;
if (rss->queue[i] >= priv->rxqs_n)