common/mlx5: fix glue library name

Message ID 20201026092035.11461-2-alialnu@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series common/mlx5: fix glue library name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Ali Alnubani Oct. 26, 2020, 9:20 a.m. UTC
  The MLX5 glue library wasn't following the standard
'librte_<class>_<name>.so' naming.

Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
Cc: bruce.richardson@intel.com

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
 drivers/common/mlx5/linux/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Matan Azrad Nov. 1, 2020, 10:35 a.m. UTC | #1
From: Ali Alnubani
> The MLX5 glue library wasn't following the standard
> 'librte_<class>_<name>.so' naming.
> 
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
  
Raslan Darawsheh Nov. 1, 2020, 1:07 p.m. UTC | #2
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ali Alnubani
> Sent: Monday, October 26, 2020 11:21 AM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com
> Subject: [dpdk-dev] [PATCH] common/mlx5: fix glue library name
> 
> The MLX5 glue library wasn't following the standard
> 'librte_<class>_<name>.so' naming.
> 
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
>  drivers/common/mlx5/linux/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/common/mlx5/linux/meson.build
> b/drivers/common/mlx5/linux/meson.build
> index 9ef8e181d..0d437f8fb 100644
> --- a/drivers/common/mlx5/linux/meson.build
> +++ b/drivers/common/mlx5/linux/meson.build
> @@ -5,7 +5,7 @@ includes += include_directories('.')
> 2.28.0

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
  

Patch

diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build
index 9ef8e181d..0d437f8fb 100644
--- a/drivers/common/mlx5/linux/meson.build
+++ b/drivers/common/mlx5/linux/meson.build
@@ -5,7 +5,7 @@  includes += include_directories('.')
 
 static_ibverbs = (get_option('ibverbs_link') == 'static')
 dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
-LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'
+LIB_GLUE_BASE = 'librte_common_mlx5_glue.so'
 LIB_GLUE_VERSION = '20.02.0'
 LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
 if dlopen_ibverbs
@@ -195,7 +195,7 @@  configure_file(output : 'mlx5_autoconf.h', configuration : config)
 # Build Glue Library
 if dlopen_ibverbs
 	dlopen_name = 'mlx5_glue'
-	dlopen_lib_name = 'rte_pmd_@0@'.format(dlopen_name)
+	dlopen_lib_name = 'rte_common_' + dlopen_name
 	dlopen_so_version = LIB_GLUE_VERSION
 	dlopen_sources = files('mlx5_glue.c')
 	dlopen_install_dir = [ eal_pmd_path + '-glue' ]