Message ID | 20201030174441.1076264-1-thomas@monjalon.net (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95C0AA04E6; Fri, 30 Oct 2020 18:44:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D259C2BF9; Fri, 30 Oct 2020 18:44:50 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 67B132BD3 for <dev@dpdk.org>; Fri, 30 Oct 2020 18:44:49 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 0524B5C0223; Fri, 30 Oct 2020 13:44:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 30 Oct 2020 13:44:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=viWq+Yj2xo5tF kaARdUplmAgnFHGcsnw9j1naPXW0SY=; b=rB9zTgiK55dRaBTaBp5A7uODJLy/h +DccsLVH0REQWR0c7X6bUSdGlYP9ea42NJBAxEmHyGlOOLVFTqSsi+vu6krgyauH E6FPVSeVIJ6K8wWQYfzz9U8+T4M/EIOehXi4t3fpyszz4AY8RynHGh1kWOCRAZiW Me5acyHUoptxIlAIhQPDn8lgAnnUVmXMhDUo/E6Bmq3xBeB99itOrD2rQnve/F+y HSiDdsxlzr75ZY68a7whlpaEXBYtRun9ZQteLdvSF7R4omQvXB/tpRG1LGkw3d2j WL32Smlu2qKfxhPJyKTW46WR4sYuU9RqAUVhGgig8YeJvMXzwEqDjVdxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=viWq+Yj2xo5tFkaARdUplmAgnFHGcsnw9j1naPXW0SY=; b=ZFUh8yYf JHzFMzwQnqn4ezF+UFofmS2XghF/SIwBta/Q3CXPWV32kU7RrmzjQSTCr6Z0aKjk jIIaTIMf97S4Ld8gX9yR3IvHEwdjmAHGJbaeurfnwXtfrJdLlc3+zkjPK7afKQFm bfQdvWgXtvVIluE2WARqRk3CZkpW3jZEdhE5V/acQbcJKShwS2NjNoJqAhU9Wrnm YtXFg8qpz8DOszvOW4pxpom6aujrpmeLjheYgbHUWjpWKC/CtOR36kOEkkJlpYNI +WiirZeAh6N3wLm6pVQgVOAkJmrVm+ohRbhSlF148FrIQxj9vBA1336mJnNCvHSQ J9a915rQSjVtPw== X-ME-Sender: <xms:DlGcX1aaKIc2i4k3lKmZbTsXLI1FQ3QmOA5CRMFWSDsMGIsHV5w2bQ> <xme:DlGcX8YWMSq92MiQW0kTZZVxjuUzj4lkXItHFVPD-3Z-7K1AeHP5mkgVUJnEQcuSQ NxT8LXVO3rLhaVkKA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleehgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepheejhfdvffeuheeiveduvd efieeghfdtvddvtdehhefgkeefhfdthfetffegteeunecuffhomhgrihhnpegtohhnfhdr ihhnnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhn vght X-ME-Proxy: <xmx:DlGcX3_uRLtgbMbFNtl6hl3njicesNpTWugvltssLJQTLGXaidVwow> <xmx:DlGcXzoSl-6CB7T4tIMdaFmTHpkfOYQl1UmX8J76oDQ1UuN4wKZAbA> <xmx:DlGcXwqjbqacCnEpkkToZpsZEt1YJeOvATSoLDlOR9ngTRIzBzzXYg> <xmx:D1GcX1AOARCAsuFXqjWcrHf-GcJyYCACc1Z7afr0yG6AIRzZygbr2w> Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C3E06306467D; Fri, 30 Oct 2020 13:44:45 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, jerinj@marvell.com Date: Fri, 30 Oct 2020 18:44:26 +0100 Message-Id: <20201030174441.1076264-1-thomas@monjalon.net> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201026052105.1561859-1-thomas@monjalon.net> References: <20201026052105.1561859-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
remove mbuf userdata
|
|
Message
Thomas Monjalon
Oct. 30, 2020, 5:44 p.m. UTC
The mbuf field userdata (aliased as udata64) was announced to be removed for two reasons: - applications, libraries and drivers used the same field for different purposes, with a risk of usage conflict. - this field always used 8 bytes even if unneeded Some dynamic fields are created when needed to replace the big static userdata field. As a consequence, 8 bytes can be re-allocated to dynamic fields. This mbuf layout change is important to allow adding more features (consuming more dynamic fields) during the next year. v6: - ARK field types different for Rx and Tx - replace macros with inline functions v5: sent "timestamp series" by mistake v4 (thanks Jerin, Nithin and Ed): - move rte_node dynfield offset to hotter context in cache - move test-eventdev dynfield offset to hotter context in cache - split ARK user data for Rx and Tx + more ARK fixes v3 (thanks Olivier): - use typedef for new field types - fix node field type - initialize offsets to -1 - add more inline functions - inline rte_security_dynfield_is_registered - add PMD-specific userdata field for ARK v2 (thanks David & Andrew): - fix some indentations - return -rte_errno consistently - make some type casts more precise - define dynfield types in macros - hide field description in rte_security - do not lookup security dynfield in ipsec-secgw - do not use the existing timestamp field for other purpose Ed Czeck (1): net/ark: switch user data to dynamic mbuf fields Nithin Dabilpuram (1): node: switch IPv4 metadata to dynamic mbuf field Thomas Monjalon (13): examples: enclose DPDK includes with angle brackets kni: move header file from EAL mbuf: fix typo in dynamic field convention note security: switch metadata to dynamic mbuf field event/sw: switch test counter to dynamic mbuf field net/bnxt: switch CFA code to dynamic mbuf field net/vmxnet3: switch MSS hint to dynamic mbuf field test/distributor: switch sequence to dynamic mbuf field test/graph: switch user data to dynamic mbuf field app/eventdev: switch flow ID to dynamic mbuf field examples/bbdev: switch to dynamic mbuf field examples/rxtx_callbacks: switch TSC to dynamic field mbuf: remove userdata field app/test-eventdev/test_order_atq.c | 4 +- app/test-eventdev/test_order_common.c | 21 ++- app/test-eventdev/test_order_common.h | 21 +++ app/test-eventdev/test_order_queue.c | 4 +- app/test/test_distributor.c | 32 ++++- app/test/test_graph.c | 99 ++++++++------ doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + doc/guides/prog_guide/rte_security.rst | 9 +- doc/guides/rel_notes/deprecation.rst | 1 - doc/guides/rel_notes/release_20_11.rst | 3 + doc/guides/sample_app_ug/rxtx_callbacks.rst | 4 +- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 5 +- drivers/event/sw/sw_evdev_selftest.c | 28 +++- drivers/net/ark/ark_ethdev.c | 39 ++++++ drivers/net/ark/ark_ethdev_rx.c | 3 +- drivers/net/ark/ark_ethdev_tx.c | 3 +- drivers/net/ark/meson.build | 2 + drivers/net/ark/rte_pmd_ark.h | 125 ++++++++++++++++++ drivers/net/ark/version.map | 7 + drivers/net/bnxt/bnxt_ethdev.c | 19 +++ drivers/net/bnxt/bnxt_rxr.c | 2 +- drivers/net/bnxt/bnxt_rxr.h | 10 ++ drivers/net/bnxt/rte_pmd_bnxt.h | 3 + drivers/net/ixgbe/ixgbe_ipsec.c | 5 +- drivers/net/ixgbe/ixgbe_rxtx.c | 6 +- drivers/net/octeontx2/otx2_ethdev.h | 1 + drivers/net/octeontx2/otx2_ethdev_sec.c | 5 +- drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 2 +- drivers/net/octeontx2/otx2_rx.h | 2 +- drivers/net/vmxnet3/vmxnet3_ethdev.c | 15 +++ drivers/net/vmxnet3/vmxnet3_ethdev.h | 11 ++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 9 +- examples/bbdev_app/main.c | 72 ++++++---- examples/bond/main.c | 11 +- examples/ipsec-secgw/ipsec-secgw.c | 9 +- examples/ipsec-secgw/ipsec_worker.c | 12 +- examples/rxtx_callbacks/main.c | 24 +++- kernel/linux/kni/meson.build | 2 +- lib/librte_eal/linux/include/meson.build | 1 - lib/librte_kni/meson.build | 2 +- .../include => librte_kni}/rte_kni_common.h | 2 +- lib/librte_mbuf/rte_mbuf_core.h | 8 +- lib/librte_mbuf/rte_mbuf_dyn.h | 2 +- lib/librte_node/ip4_lookup.c | 40 ++++-- lib/librte_node/ip4_lookup_neon.h | 20 ++- lib/librte_node/ip4_lookup_sse.h | 36 +++-- lib/librte_node/ip4_rewrite.c | 49 +++++-- lib/librte_node/node_private.h | 13 +- lib/librte_security/rte_security.c | 16 +++ lib/librte_security/rte_security.h | 42 ++++++ lib/librte_security/rte_security_driver.h | 3 + lib/librte_security/version.map | 2 + 53 files changed, 681 insertions(+), 187 deletions(-) create mode 100644 drivers/net/ark/rte_pmd_ark.h rename lib/{librte_eal/linux/include => librte_kni}/rte_kni_common.h (98%)
Comments
30/10/2020 18:44, Thomas Monjalon: > The mbuf field userdata (aliased as udata64) > was announced to be removed for two reasons: > - applications, libraries and drivers used the same field > for different purposes, with a risk of usage conflict. > - this field always used 8 bytes even if unneeded > > Some dynamic fields are created when needed to replace > the big static userdata field. > As a consequence, 8 bytes can be re-allocated to dynamic fields. > > This mbuf layout change is important to allow adding more features > (consuming more dynamic fields) during the next year. Applied
On 10/31/2020 3:07 PM, Thomas Monjalon wrote: > 30/10/2020 18:44, Thomas Monjalon: >> The mbuf field userdata (aliased as udata64) >> was announced to be removed for two reasons: >> - applications, libraries and drivers used the same field >> for different purposes, with a risk of usage conflict. >> - this field always used 8 bytes even if unneeded >> >> Some dynamic fields are created when needed to replace >> the big static userdata field. >> As a consequence, 8 bytes can be re-allocated to dynamic fields. >> >> This mbuf layout change is important to allow adding more features >> (consuming more dynamic fields) during the next year. > > Applied > The new txgbe driver in the next-net is also using ‘udata64’, that also needs to be updated. cc'ed txgbe maintainer.
01/11/2020 00:36, Ferruh Yigit: > On 10/31/2020 3:07 PM, Thomas Monjalon wrote: > > 30/10/2020 18:44, Thomas Monjalon: > >> The mbuf field userdata (aliased as udata64) > >> was announced to be removed for two reasons: > >> - applications, libraries and drivers used the same field > >> for different purposes, with a risk of usage conflict. > >> - this field always used 8 bytes even if unneeded > >> > >> Some dynamic fields are created when needed to replace > >> the big static userdata field. > >> As a consequence, 8 bytes can be re-allocated to dynamic fields. > >> > >> This mbuf layout change is important to allow adding more features > >> (consuming more dynamic fields) during the next year. > > > > Applied > > The new txgbe driver in the next-net is also using ‘udata64’, that also needs to > be updated. cc'ed txgbe maintainer. That's a pity it did not take into account the deprecation notice. What kind of hack is it used for? Can it be simply removed to allow quick merging of the PMD?
On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon <thomas@monjalon.net> wrote: > > The new txgbe driver in the next-net is also using ‘udata64’, that also needs to > > be updated. cc'ed txgbe maintainer. > > That's a pity it did not take into account the deprecation notice. > What kind of hack is it used for? > Can it be simply removed to allow quick merging of the PMD? +1 for removing. It seems to be a provision for future features, as this field is simply passed to an internal function that does not use it. $ git grep -C 2 udata drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c- txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, drivers/net/txgbe/txgbe_rxtx.c: tx_offload, &tx_pkt->udata64); drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c- txe->last_id = tx_last; $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c-static inline void drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct txgbe_tx_queue *txq, drivers/net/txgbe/txgbe_rxtx.c- volatile struct txgbe_tx_ctx_desc *ctx_txd, drivers/net/txgbe/txgbe_rxtx.c- uint64_t ol_flags, union txgbe_tx_offload tx_offload, -- drivers/net/txgbe/txgbe_rxtx.c- } drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c: txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, drivers/net/txgbe/txgbe_rxtx.c- tx_offload, &tx_pkt->udata64); drivers/net/txgbe/txgbe_rxtx.c- $ git grep -w mdata drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c: __rte_unused uint64_t *mdata)
On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: > On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon <thomas@monjalon.net> > wrote: > > > The new txgbe driver in the next-net is also using ‘udata64’, that > > > also needs to be updated. cc'ed txgbe maintainer. > > > > That's a pity it did not take into account the deprecation notice. > > What kind of hack is it used for? > > Can it be simply removed to allow quick merging of the PMD? > > +1 for removing. > > It seems to be a provision for future features, as this field is simply passed to > an internal function that does not use it. > > $ git grep -C 2 udata drivers/net/txgbe/ > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c- > txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, > drivers/net/txgbe/txgbe_rxtx.c: > tx_offload, &tx_pkt->udata64); > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c- txe->last_id = > tx_last; > > $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c-static inline void > drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct txgbe_tx_queue > *txq, > drivers/net/txgbe/txgbe_rxtx.c- volatile struct > txgbe_tx_ctx_desc *ctx_txd, > drivers/net/txgbe/txgbe_rxtx.c- uint64_t ol_flags, union > txgbe_tx_offload tx_offload, > -- > drivers/net/txgbe/txgbe_rxtx.c- } > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c: > txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, > drivers/net/txgbe/txgbe_rxtx.c- > tx_offload, &tx_pkt->udata64); > drivers/net/txgbe/txgbe_rxtx.c- > > $ git grep -w mdata drivers/net/txgbe/ > drivers/net/txgbe/txgbe_rxtx.c: __rte_unused uint64_t *mdata) > > > -- > David Marchand Thanks for review. It can be just simply removed in txgbe driver.
On 11/2/2020 9:11 AM, Jiawen Wu wrote: > On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: >> On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon <thomas@monjalon.net> >> wrote: >>>> The new txgbe driver in the next-net is also using ‘udata64’, that >>>> also needs to be updated. cc'ed txgbe maintainer. >>> >>> That's a pity it did not take into account the deprecation notice. >>> What kind of hack is it used for? >>> Can it be simply removed to allow quick merging of the PMD? >> >> +1 for removing. >> >> It seems to be a provision for future features, as this field is simply passed to >> an internal function that does not use it. >> >> $ git grep -C 2 udata drivers/net/txgbe/ >> drivers/net/txgbe/txgbe_rxtx.c- >> drivers/net/txgbe/txgbe_rxtx.c- >> txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, >> drivers/net/txgbe/txgbe_rxtx.c: >> tx_offload, &tx_pkt->udata64); >> drivers/net/txgbe/txgbe_rxtx.c- >> drivers/net/txgbe/txgbe_rxtx.c- txe->last_id = >> tx_last; >> >> $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ >> drivers/net/txgbe/txgbe_rxtx.c- >> drivers/net/txgbe/txgbe_rxtx.c-static inline void >> drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct txgbe_tx_queue >> *txq, >> drivers/net/txgbe/txgbe_rxtx.c- volatile struct >> txgbe_tx_ctx_desc *ctx_txd, >> drivers/net/txgbe/txgbe_rxtx.c- uint64_t ol_flags, union >> txgbe_tx_offload tx_offload, >> -- >> drivers/net/txgbe/txgbe_rxtx.c- } >> drivers/net/txgbe/txgbe_rxtx.c- >> drivers/net/txgbe/txgbe_rxtx.c: >> txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, >> drivers/net/txgbe/txgbe_rxtx.c- >> tx_offload, &tx_pkt->udata64); >> drivers/net/txgbe/txgbe_rxtx.c- >> >> $ git grep -w mdata drivers/net/txgbe/ >> drivers/net/txgbe/txgbe_rxtx.c: __rte_unused uint64_t *mdata) >> >> >> -- >> David Marchand > > Thanks for review. > It can be just simply removed in txgbe driver. > OK, I will remove it in the next-net.
On 11/2/2020 11:08 AM, Ferruh Yigit wrote: > On 11/2/2020 9:11 AM, Jiawen Wu wrote: >> On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: >>> On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon <thomas@monjalon.net> >>> wrote: >>>>> The new txgbe driver in the next-net is also using ‘udata64’, that >>>>> also needs to be updated. cc'ed txgbe maintainer. >>>> >>>> That's a pity it did not take into account the deprecation notice. >>>> What kind of hack is it used for? >>>> Can it be simply removed to allow quick merging of the PMD? >>> >>> +1 for removing. >>> >>> It seems to be a provision for future features, as this field is simply >>> passed to >>> an internal function that does not use it. >>> >>> $ git grep -C 2 udata drivers/net/txgbe/ >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c- >>> txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, >>> drivers/net/txgbe/txgbe_rxtx.c: >>> tx_offload, &tx_pkt->udata64); >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c- txe->last_id = >>> tx_last; >>> >>> $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c-static inline void >>> drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct txgbe_tx_queue >>> *txq, >>> drivers/net/txgbe/txgbe_rxtx.c- volatile struct >>> txgbe_tx_ctx_desc *ctx_txd, >>> drivers/net/txgbe/txgbe_rxtx.c- uint64_t ol_flags, union >>> txgbe_tx_offload tx_offload, >>> -- >>> drivers/net/txgbe/txgbe_rxtx.c- } >>> drivers/net/txgbe/txgbe_rxtx.c- >>> drivers/net/txgbe/txgbe_rxtx.c: >>> txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, >>> drivers/net/txgbe/txgbe_rxtx.c- >>> tx_offload, &tx_pkt->udata64); >>> drivers/net/txgbe/txgbe_rxtx.c- >>> >>> $ git grep -w mdata drivers/net/txgbe/ >>> drivers/net/txgbe/txgbe_rxtx.c: __rte_unused uint64_t *mdata) >>> >>> >>> -- >>> David Marchand >> >> Thanks for review. >> It can be just simply removed in txgbe driver. >> > > OK, I will remove it in the next-net. > Applied following: diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index b35b7de1cb..4d8b43423d 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -281,8 +281,7 @@ txgbe_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts, static inline void txgbe_set_xmit_ctx(struct txgbe_tx_queue *txq, volatile struct txgbe_tx_ctx_desc *ctx_txd, - uint64_t ol_flags, union txgbe_tx_offload tx_offload, - __rte_unused uint64_t *mdata) + uint64_t ol_flags, union txgbe_tx_offload tx_offload) { union txgbe_tx_offload tx_offload_mask; uint32_t type_tucmd_mlhl; @@ -861,7 +860,7 @@ txgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, } txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, - tx_offload, &tx_pkt->udata64); + tx_offload); txe->last_id = tx_last; tx_id = txe->next_id;