mbox series

[v2,00/14] ethdev: remove legacy filter API

Message ID 1603359758-13297-1-git-send-email-arybchenko@solarflare.com (mailing list archive)
Headers
Series ethdev: remove legacy filter API |

Message

Andrew Rybchenko Oct. 22, 2020, 9:42 a.m. UTC 
  Removal is aggressive and tries to cleanup all dead code from drivers.

tep_termination example still uses TUNNEL filters. Functionality is
broken when TUNNEL filter is removed and finally even build of the
example is broken when API is removed. It is assumed that the example
will be removed before the patch series applied.

v2:
  - cleanup testpmd user guide
  - try to improve descriptions a bit
  - remove example/tep_termination mentions from patches
    description
  - fix broken build because of unused static function left
  - other chagnes are documented in specific patches

Andrew Rybchenko (14):
  ethdev: remove legacy MACVLAN filter type support
  ethdev: move MAC filter type to i40e driver
  ethdev: remove legacy EtherType filter type support
  ethdev: remove legacy flexible filter type support
  ethdev: move flexible filter type to e1000 driver
  ethdev: remove legacy SYN filter type support
  ethdev: remove legacy N-tuple filter type support
  ethdev: remove legacy TUNNEL filter type support
  ethdev: remove legacy HASH filter type support
  ethdev: remove legacy L2_TUNNEL filter type support
  ethdev: remove legacy global filter configuration support
  ethdev: remove legacy FDIR filter type support
  app/testpmd: remove command to set FDIR flexible filter mask
  ethdev: remove legacy filter API functions

 app/test-pmd/cmdline.c                      | 2819 +------------------
 app/test-pmd/config.c                       |   15 +-
 app/test-pmd/testpmd.h                      |    2 +
 doc/guides/nics/i40e.rst                    |   16 +-
 doc/guides/rel_notes/deprecation.rst        |    8 -
 doc/guides/rel_notes/release_20_11.rst      |    3 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  461 +--
 drivers/net/bnxt/bnxt_ethdev.c              |  802 ------
 drivers/net/dpaa2/dpaa2_ethdev.c            |    4 -
 drivers/net/e1000/e1000_ethdev.h            |   22 +-
 drivers/net/e1000/igb_ethdev.c              |  391 +--
 drivers/net/e1000/igb_flow.c                |   36 +-
 drivers/net/enic/enic.h                     |    7 -
 drivers/net/enic/enic_clsf.c                |  168 --
 drivers/net/enic/enic_ethdev.c              |   48 -
 drivers/net/hinic/hinic_pmd_ethdev.h        |    1 +
 drivers/net/hns3/hns3_ethdev.h              |    1 +
 drivers/net/i40e/i40e_ethdev.c              |  828 +-----
 drivers/net/i40e/i40e_ethdev.h              |   26 +-
 drivers/net/i40e/i40e_fdir.c                |  539 ----
 drivers/net/i40e/i40e_pf.c                  |    2 +-
 drivers/net/i40e/rte_pmd_i40e.c             |   30 +-
 drivers/net/igc/igc_filter.h                |    1 +
 drivers/net/ixgbe/ixgbe_ethdev.c            |  305 +-
 drivers/net/ixgbe/ixgbe_ethdev.h            |    2 -
 drivers/net/ixgbe/ixgbe_fdir.c              |  220 --
 drivers/net/mlx5/mlx5.h                     |    1 -
 drivers/net/mlx5/mlx5_flow.c                |  516 ----
 drivers/net/mlx5/mlx5_flow.h                |    8 -
 drivers/net/qede/qede_ethdev.h              |    5 -
 drivers/net/qede/qede_filter.c              |  498 ----
 drivers/net/sfc/sfc_ethdev.c                |   27 -
 lib/librte_ethdev/rte_eth_ctrl.h            |  263 +-
 lib/librte_ethdev/rte_ethdev.c              |   28 -
 lib/librte_ethdev/rte_ethdev.h              |   41 -
 lib/librte_ethdev/rte_ethdev_driver.h       |  108 +
 lib/librte_ethdev/version.map               |    2 -
 37 files changed, 351 insertions(+), 7903 deletions(-)

Comments

Ferruh Yigit Oct. 23, 2020, 4:03 p.m. UTC | #1 
On 10/22/2020 10:42 AM, Andrew Rybchenko wrote:
> Removal is aggressive and tries to cleanup all dead code from drivers.
> 
> tep_termination example still uses TUNNEL filters. Functionality is
> broken when TUNNEL filter is removed and finally even build of the
> example is broken when API is removed. It is assumed that the example
> will be removed before the patch series applied.
> 
> v2:
>    - cleanup testpmd user guide
>    - try to improve descriptions a bit
>    - remove example/tep_termination mentions from patches
>      description
>    - fix broken build because of unused static function left
>    - other chagnes are documented in specific patches
> 
> Andrew Rybchenko (14):
>    ethdev: remove legacy MACVLAN filter type support
>    ethdev: move MAC filter type to i40e driver
>    ethdev: remove legacy EtherType filter type support
>    ethdev: remove legacy flexible filter type support
>    ethdev: move flexible filter type to e1000 driver
>    ethdev: remove legacy SYN filter type support
>    ethdev: remove legacy N-tuple filter type support
>    ethdev: remove legacy TUNNEL filter type support
>    ethdev: remove legacy HASH filter type support
>    ethdev: remove legacy L2_TUNNEL filter type support
>    ethdev: remove legacy global filter configuration support
>    ethdev: remove legacy FDIR filter type support
>    app/testpmd: remove command to set FDIR flexible filter mask
>    ethdev: remove legacy filter API functions
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>


There is a dependency to tep_termination sample removal [1], after it is merged 
into main repo, I will proceed with this set.


[1]
https://patches.dpdk.org/patch/81654/
Ferruh Yigit Oct. 29, 2020, 9:36 p.m. UTC | #2 
On 10/23/2020 5:03 PM, Ferruh Yigit wrote:
> On 10/22/2020 10:42 AM, Andrew Rybchenko wrote:
>> Removal is aggressive and tries to cleanup all dead code from drivers.
>>
>> tep_termination example still uses TUNNEL filters. Functionality is
>> broken when TUNNEL filter is removed and finally even build of the
>> example is broken when API is removed. It is assumed that the example
>> will be removed before the patch series applied.
>>
>> v2:
>>    - cleanup testpmd user guide
>>    - try to improve descriptions a bit
>>    - remove example/tep_termination mentions from patches
>>      description
>>    - fix broken build because of unused static function left
>>    - other chagnes are documented in specific patches
>>
>> Andrew Rybchenko (14):
>>    ethdev: remove legacy MACVLAN filter type support
>>    ethdev: move MAC filter type to i40e driver
>>    ethdev: remove legacy EtherType filter type support
>>    ethdev: remove legacy flexible filter type support
>>    ethdev: move flexible filter type to e1000 driver
>>    ethdev: remove legacy SYN filter type support
>>    ethdev: remove legacy N-tuple filter type support
>>    ethdev: remove legacy TUNNEL filter type support
>>    ethdev: remove legacy HASH filter type support
>>    ethdev: remove legacy L2_TUNNEL filter type support
>>    ethdev: remove legacy global filter configuration support
>>    ethdev: remove legacy FDIR filter type support
>>    app/testpmd: remove command to set FDIR flexible filter mask
>>    ethdev: remove legacy filter API functions
>>
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Series applied to dpdk-next-net/main, thanks.