diff mbox series

[08/11] app/flow-perf: check eth dev stop status

Message ID 1602682146-4722-9-git-send-email-arybchenko@solarflare.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series ethdev: change device stop to return status |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Andrew Rybchenko Oct. 14, 2020, 1:29 p.m. UTC 
  From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>

rte_eth_dev_stop() return value was changed from void to int,
so this patch modify usage of this function across app/flow-perf
according to new return type.

Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 app/test-flow-perf/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Wisam Monther Oct. 15, 2020, 8:04 a.m. UTC | #1 
Hi,

>-----Original Message-----
>From: Andrew Rybchenko <arybchenko@solarflare.com>
>Sent: Wednesday, October 14, 2020 4:29 PM
>To: Wisam Monther <wisamm@nvidia.com>
>Cc: dev@dpdk.org; Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>Subject: [PATCH 08/11] app/flow-perf: check eth dev stop status
>
>From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>
>rte_eth_dev_stop() return value was changed from void to int, so this patch
>modify usage of this function across app/flow-perf according to new return
>type.
>
>Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Acked-by: Wisam Jaddo <wisamm@nvidia.com>
diff mbox series

Patch

diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
index c420da6a57..2189b945de 100644
--- a/app/test-flow-perf/main.c
+++ b/app/test-flow-perf/main.c
@@ -1450,7 +1450,8 @@  main(int argc, char **argv)
 
 	RTE_ETH_FOREACH_DEV(port) {
 		rte_flow_flush(port, &error);
-		rte_eth_dev_stop(port);
+		if (rte_eth_dev_stop(port) != 0)
+			printf("Failed to stop device on port %u\n", port);
 		rte_eth_dev_close(port);
 	}
 	return 0;