[v3,1/7] app: fix missing dependencies

Message ID 20201014141304.632120-2-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Rework build macros |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson Oct. 14, 2020, 2:12 p.m. UTC
  A number of lib and driver dependencies for various apps were missed on
build because the proper macro names for their use were mismatched between
meson and make build systems. Before adding in equivalent compatibility
macros we need to ensure to add the proper dependencies to ensure a valid
build.

Fixes: 16ade738fd0d ("app/testpmd: build with meson")
Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
Fixes: 996ef1176111 ("app: add all remaining apps to meson build")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test-crypto-perf/meson.build |  3 +++
 app/test-pmd/meson.build         | 12 ++++++++++++
 2 files changed, 15 insertions(+)
  

Comments

Luca Boccassi Oct. 15, 2020, 10:32 a.m. UTC | #1
On Wed, 2020-10-14 at 15:12 +0100, Bruce Richardson wrote:
> A number of lib and driver dependencies for various apps were missed on
> build because the proper macro names for their use were mismatched between
> meson and make build systems. Before adding in equivalent compatibility
> macros we need to ensure to add the proper dependencies to ensure a valid
> build.
> 
> Fixes: 16ade738fd0d ("app/testpmd: build with meson")
> Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> Fixes: 996ef1176111 ("app: add all remaining apps to meson build")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  app/test-crypto-perf/meson.build |  3 +++
>  app/test-pmd/meson.build         | 12 ++++++++++++
>  2 files changed, 15 insertions(+)

Acked-by: Luca Boccassi <bluca@debian.org>
  

Patch

diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto-perf/meson.build
index f394b75ba..4bd71510d 100644
--- a/app/test-crypto-perf/meson.build
+++ b/app/test-crypto-perf/meson.build
@@ -12,3 +12,6 @@  sources = files('cperf_ops.c',
 		'cperf_test_verify.c',
 		'main.c')
 deps += ['cryptodev', 'net', 'security']
+if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+	deps += 'pmd_crypto_scheduler'
+endif
diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index f52ab148f..0d9e45049 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -31,6 +31,18 @@  endif
 if dpdk_conf.has('RTE_LIBRTE_PDUMP')
 	deps += 'pdump'
 endif
+if dpdk_conf.has('RTE_LIBRTE_BITRATESTATS')
+	deps += 'bitratestats'
+endif
+if dpdk_conf.has('RTE_LIBRTE_LATENCYSTATS')
+	deps += 'latencystats'
+endif
+if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+	deps += 'pmd_crypto_scheduler'
+endif
+if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
+	deps += 'pmd_bond'
+endif
 if dpdk_conf.has('RTE_LIBRTE_BNXT_PMD')
 	deps += 'pmd_bnxt'
 endif