[v3,6/6] doc: update for two ports hairpin mode
Checks
Commit Message
In the release notes, 2 ports hairpin mode feature is added.
In rte flow part, one suggestion is added to mention that metadata
could be used to connect the hairpin RX and TX flows if the hairpin
is working in explicit TX flow rule mode.
In the testpmd command line, the new parameter to set hairpin working
mode is described.
Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
doc/guides/prog_guide/rte_flow.rst | 3 +++
doc/guides/rel_notes/release_20_11.rst | 8 ++++++++
doc/guides/testpmd_app_ug/run_app.rst | 8 ++++++++
3 files changed, 19 insertions(+)
Comments
08/10/2020 14:05, Bing Zhao:
> In the release notes, 2 ports hairpin mode feature is added.
>
> In rte flow part, one suggestion is added to mention that metadata
> could be used to connect the hairpin RX and TX flows if the hairpin
> is working in explicit TX flow rule mode.
>
> In the testpmd command line, the new parameter to set hairpin working
> mode is described.
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
> doc/guides/prog_guide/rte_flow.rst | 3 +++
> doc/guides/rel_notes/release_20_11.rst | 8 ++++++++
> doc/guides/testpmd_app_ug/run_app.rst | 8 ++++++++
> 3 files changed, 19 insertions(+)
Please squash doc changes in related code changes commits,
so both are atomic. Thanks
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, October 13, 2020 5:31 AM
> To: Bing Zhao <bingz@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; ferruh.yigit@intel.com;
> arybchenko@solarflare.com; mdr@ashroe.eu; nhorman@tuxdriver.com;
> bernard.iremonger@intel.com; beilei.xing@intel.com;
> wenzhuo.lu@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 6/6] doc: update for two ports
> hairpin mode
>
> External email: Use caution opening links or attachments
>
>
> 08/10/2020 14:05, Bing Zhao:
> > In the release notes, 2 ports hairpin mode feature is added.
> >
> > In rte flow part, one suggestion is added to mention that metadata
> > could be used to connect the hairpin RX and TX flows if the
> hairpin is
> > working in explicit TX flow rule mode.
> >
> > In the testpmd command line, the new parameter to set hairpin
> working
> > mode is described.
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > Acked-by: Ori Kam <orika@nvidia.com>
> > ---
> > doc/guides/prog_guide/rte_flow.rst | 3 +++
> > doc/guides/rel_notes/release_20_11.rst | 8 ++++++++
> > doc/guides/testpmd_app_ug/run_app.rst | 8 ++++++++
> > 3 files changed, 19 insertions(+)
>
> Please squash doc changes in related code changes commits, so both
> are atomic. Thanks
OK, I will rebase and squash them into other commits. So there is no
need to care about the check patches warning of the headline prefix,
am I right?
>
>
Thanks a lot
BR. Bing
13/10/2020 03:13, Bing Zhao:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 08/10/2020 14:05, Bing Zhao:
> > > In the release notes, 2 ports hairpin mode feature is added.
> > >
> > > In rte flow part, one suggestion is added to mention that metadata
> > > could be used to connect the hairpin RX and TX flows if the
> > hairpin is
> > > working in explicit TX flow rule mode.
> > >
> > > In the testpmd command line, the new parameter to set hairpin
> > working
> > > mode is described.
> > >
> > > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > > Acked-by: Ori Kam <orika@nvidia.com>
> > > ---
> > > doc/guides/prog_guide/rte_flow.rst | 3 +++
> > > doc/guides/rel_notes/release_20_11.rst | 8 ++++++++
> > > doc/guides/testpmd_app_ug/run_app.rst | 8 ++++++++
> > > 3 files changed, 19 insertions(+)
> >
> > Please squash doc changes in related code changes commits, so both
> > are atomic. Thanks
>
> OK, I will rebase and squash them into other commits. So there is no
> need to care about the check patches warning of the headline prefix,
> am I right?
Right
We should improve this script to be less strict.
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, October 13, 2020 2:37 PM
> To: Bing Zhao <bingz@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; ferruh.yigit@intel.com;
> arybchenko@solarflare.com; mdr@ashroe.eu; nhorman@tuxdriver.com;
> bernard.iremonger@intel.com; beilei.xing@intel.com;
> wenzhuo.lu@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 6/6] doc: update for two ports
> hairpin mode
>
> External email: Use caution opening links or attachments
>
>
> 13/10/2020 03:13, Bing Zhao:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 08/10/2020 14:05, Bing Zhao:
> > > > In the release notes, 2 ports hairpin mode feature is added.
> > > >
> > > > In rte flow part, one suggestion is added to mention that
> metadata
> > > > could be used to connect the hairpin RX and TX flows if the
> > > hairpin is
> > > > working in explicit TX flow rule mode.
> > > >
> > > > In the testpmd command line, the new parameter to set hairpin
> > > working
> > > > mode is described.
> > > >
> > > > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > > > Acked-by: Ori Kam <orika@nvidia.com>
> > > > ---
> > > > doc/guides/prog_guide/rte_flow.rst | 3 +++
> > > > doc/guides/rel_notes/release_20_11.rst | 8 ++++++++
> > > > doc/guides/testpmd_app_ug/run_app.rst | 8 ++++++++
> > > > 3 files changed, 19 insertions(+)
> > >
> > > Please squash doc changes in related code changes commits, so
> both
> > > are atomic. Thanks
> >
> > OK, I will rebase and squash them into other commits. So there is
> no
> > need to care about the check patches warning of the headline
> prefix,
> > am I right?
>
> Right
> We should improve this script to be less strict.
>
I see.
So many thanks
@@ -2592,6 +2592,9 @@ set, unpredictable value will be seen depending on driver implementation. For
loopback/hairpin packet, metadata set on Rx/Tx may or may not be propagated to
the other path depending on HW capability.
+In hairpin case with TX explicit flow mode, metadata could (not mandatory) be
+used to connect the RX and TX flows if it can be propagated from RX to TX path.
+
.. _table_rte_flow_action_set_meta:
.. table:: SET_META
@@ -109,6 +109,10 @@ New Features
* Extern objects and functions can be plugged into the pipeline.
* Transaction-oriented table updates.
+* **Updated the ethdev library to support hairpin between two ports.**
+
+ New APIs are introduced to support binding / unbinding 2 ports hairpin.
+ Hairpin TX part flow rules can be inserted explicitly.
Removed Items
-------------
@@ -240,6 +244,10 @@ ABI Changes
* ``ethdev`` internal functions are marked with ``__rte_internal`` tag.
+ * ``struct rte_eth_hairpin_conf`` has two new members:
+
+ * ``uint32_t tx_explicit:1;``
+ * ``uint32_t manual_bind:1;``
Known Issues
------------
@@ -497,3 +497,11 @@ The command line options are:
* ``--record-burst-stats``
Enable display of RX and TX burst stats.
+
+* ``--hairpin-mode=0xXX``
+
+ Set the hairpin port mode with bitmask, only valid when hairpin queues number is set.
+ bit 4 - explicit TX flow rule
+ bit 1 - two hairpin ports paired
+ bit 0 - two hairpin ports loop
+ The default value is 0. Hairpin will use single port mode and implicit TX flow mode.