[2/4] raw/dpaa2: fix build with gcc 11
Checks
Commit Message
Error observed with gcc 11 under development
gcc (GCC) 11.0.0 20200920 (experimental)
build error:
../drivers/raw/dpaa2_qdma/dpaa2_qdma.c: In function ‘rte_qdma_reset’:
../drivers/raw/dpaa2_qdma/dpaa2_qdma.c:454:17:
warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
454 | if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
| ^~
../drivers/raw/dpaa2_qdma/dpaa2_qdma.c:457:25:
note: ...this statement, but the latter is misleadingly indented
as if it were guarded by the ‘if’
457 | return -EBUSY;
| ^~~~~~
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Thu, Oct 8, 2020 at 11:08 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>
> Hi David,
>
> https://patchwork.dpdk.org/patch/76983/ - this patch have same changes?
> Please check and let me know what shall be done.
Ok, I'll mark Ferruh patch as rejected.
Thank you.
On 10/8/2020 11:40 AM, David Marchand wrote:
> On Thu, Oct 8, 2020 at 11:08 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>>
>> Hi David,
>>
>> https://patchwork.dpdk.org/patch/76983/ - this patch have same changes?
>> Please check and let me know what shall be done.
>
> Ok, I'll mark Ferruh patch as rejected.
>
Yes looks like fixing same thing, good for me.
@@ -452,9 +452,10 @@ rte_qdma_reset(void)
/* In case there are pending jobs on any VQ, return -EBUSY */
for (i = 0; i < qdma_dev.max_vqs; i++) {
if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
- qdma_vqs[i].num_dequeues))
+ qdma_vqs[i].num_dequeues)) {
DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
return -EBUSY;
+ }
}
/* Reset HW queues */