diff mbox series

[v2] net/ring: advertise multi segment TX and scatter RX.

Message ID 1601318849-16691-1-git-send-email-dceara@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] net/ring: advertise multi segment TX and scatter RX. |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Dumitru Ceara Sept. 28, 2020, 6:47 p.m. UTC 
  Even though ring interfaces don't support any other TX/RX offloads they
do support sending multi segment packets and this should be advertised
in order to not break applications that use ring interfaces.

Also advertise scatter RX support.

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
---
 drivers/net/ring/rte_eth_ring.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bruce Richardson Sept. 29, 2020, 8:37 a.m. UTC | #1 
On Mon, Sep 28, 2020 at 08:47:29PM +0200, Dumitru Ceara wrote:
> Even though ring interfaces don't support any other TX/RX offloads they
> do support sending multi segment packets and this should be advertised
> in order to not break applications that use ring interfaces.
> 
> Also advertise scatter RX support.
> 
> Signed-off-by: Dumitru Ceara <dceara@redhat.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Ferruh Yigit Sept. 30, 2020, 5:04 p.m. UTC | #2 
On 9/29/2020 9:37 AM, Bruce Richardson wrote:
> On Mon, Sep 28, 2020 at 08:47:29PM +0200, Dumitru Ceara wrote:
>> Even though ring interfaces don't support any other TX/RX offloads they
>> do support sending multi segment packets and this should be advertised
>> in order to not break applications that use ring interfaces.
>>
>> Also advertise scatter RX support.
>>
>> Signed-off-by: Dumitru Ceara <dceara@redhat.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Applied to dpdk-next-net/main, thanks.

Note:
I have added ring.ini in another patch, after it is accepted 'Scattered Rx' also 
needs to be as documented there after this patch.
diff mbox series

Patch

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 40fe1ca..ac1ce1d 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -160,6 +160,8 @@  struct pmd_internals {
 	dev_info->max_mac_addrs = 1;
 	dev_info->max_rx_pktlen = (uint32_t)-1;
 	dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;
+	dev_info->rx_offload_capa = DEV_RX_OFFLOAD_SCATTER;
+	dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS;
 	dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues;
 	dev_info->min_rx_bufsize = 0;