diff mbox series

[18/20] drivers/net: remove redundant MAC addresses freeing

Message ID	20200913220711.3768597-19-thomas@monjalon.net (mailing list archive)
State	Changes Requested, archived
Delegated to:	Ferruh Yigit
Headers	From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>, Ziyang Xuan <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>, Guoyang Zhou <zhouguoyang@huawei.com>, Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Martin Spinler <spinler@cesnet.cz> Date: Mon, 14 Sep 2020 00:07:09 +0200 Message-Id: <20200913220711.3768597-19-thomas@monjalon.net> In-Reply-To: <20200913220711.3768597-1-thomas@monjalon.net> References: <20200913220711.3768597-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 18/20] drivers/net: remove redundant MAC addresses freeing Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	cleanup ethdev close operation \| [00/20] cleanup ethdev close operation [01/20] ethdev: reset device and interrupt pointers on release [02/20] ethdev: allow drivers to return error on close [03/20] net/af_packet: release port upon close [04/20] net/atlantic: release port upon close [05/20] net/axgbe: release port upon close [06/20] net/bonding: release port upon close [07/20] net/failsafe: release port upon close [08/20] net/iavf: release port upon close [09/20] net/mlx4: release port upon close [10/20] net/null: release port upon close [11/20] net/octeontx: release port upon close [12/20] net/pcap: release port upon close [13/20] net/ring: release port upon close [14/20] net/softnic: release port upon close [15/20] net/tap: release port upon close [16/20] ethdev: remove old close behaviour [17/20] drivers/net: accept removing device without any port [18/20] drivers/net: remove redundant MAC addresses freeing [19/20] app/testpmd: reset port status on close notification [20/20] app/testpmd: align behaviour of multi-port detach

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Thomas Monjalon Sept. 13, 2020, 10:07 p.m. UTC

  The MAC addresses array is already freed by rte_eth_dev_release_port().
The redundant freeing can be removed from the PMD port closing functions.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/ark/ark_ethdev.c            | 3 ---
 drivers/net/hinic/hinic_pmd_ethdev.c    | 3 ---
 drivers/net/ice/ice_ethdev.c            | 3 ---
 drivers/net/nfb/nfb_ethdev.c            | 3 ---
 drivers/net/szedata2/rte_eth_szedata2.c | 3 ---
 5 files changed, 15 deletions(-)

Comments

Ferruh Yigit Sept. 23, 2020, 4:45 p.m. UTC | #1

On 9/13/2020 11:07 PM, Thomas Monjalon wrote:
> The MAC addresses array is already freed by rte_eth_dev_release_port().
> The redundant freeing can be removed from the PMD port closing functions.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

diff mbox series

Patch

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 8012af75ee..641a694717 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -707,9 +707,6 @@  eth_ark_dev_close(struct rte_eth_dev *dev)
 		dev->data->rx_queues[i] = 0;
 	}
 
-	rte_free(dev->data->mac_addrs);
-	dev->data->mac_addrs = 0;
-
 	return 0;
 }
 
diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c
index 623534fda4..460093bf95 100644
--- a/drivers/net/hinic/hinic_pmd_ethdev.c
+++ b/drivers/net/hinic/hinic_pmd_ethdev.c
@@ -3225,9 +3225,6 @@  static int hinic_dev_uninit(struct rte_eth_dev *dev)
 
 	rte_free(nic_dev->mc_list);
 
-	rte_free(dev->data->mac_addrs);
-	dev->data->mac_addrs = NULL;
-
 	return HINIC_OK;
 }
 
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index f0cb05cbc9..1a7896f0da 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2423,9 +2423,6 @@  ice_dev_close(struct rte_eth_dev *dev)
 	dev->rx_pkt_burst = NULL;
 	dev->tx_pkt_burst = NULL;
 
-	rte_free(dev->data->mac_addrs);
-	dev->data->mac_addrs = NULL;
-
 	/* disable uio intr before callback unregister */
 	rte_intr_disable(intr_handle);
 
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index d937ac6922..6fe7500475 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -233,9 +233,6 @@  nfb_eth_dev_close(struct rte_eth_dev *dev)
 	}
 	dev->data->nb_tx_queues = 0;
 
-	rte_free(dev->data->mac_addrs);
-	dev->data->mac_addrs = NULL;
-
 	return 0;
 }
 
diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c
index 5f589dfa4c..9ae653e1bd 100644
--- a/drivers/net/szedata2/rte_eth_szedata2.c
+++ b/drivers/net/szedata2/rte_eth_szedata2.c
@@ -1178,9 +1178,6 @@  eth_dev_close(struct rte_eth_dev *dev)
 	}
 	dev->data->nb_tx_queues = 0;
 
-	rte_free(dev->data->mac_addrs);
-	dev->data->mac_addrs = NULL;
-
 	return 0;
 }