| Message ID | 20200917053035.1889989-1-mk@semihalf.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B524A04B6; Thu, 17 Sep 2020 07:30:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8876F1D523; Thu, 17 Sep 2020 07:30:50 +0200 (CEST) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by dpdk.org (Postfix) with ESMTP id 03D0A1D508 for <dev@dpdk.org>; Thu, 17 Sep 2020 07:30:48 +0200 (CEST) Received: by mail-lj1-f176.google.com with SMTP id u21so884370ljl.6 for <dev@dpdk.org>; Wed, 16 Sep 2020 22:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+uHCYd0rqMfB4j7YU6QLObXplVYxcWC9Zpet/RFE40s=; b=Kbm7o86tumzIJdVAkhq2o7C6wd+LSlpxgFbTIuhuaVbmEumNR3iy8KZDaF7MCnay4K UF9NAwyx9O97L69SBln8X4NUGSnM+nkrG0THbshaYVrwiy5Qu2Pta1sPBHuLv5JI5gfF Zq4TtaTcmDqHCeMtVxUNDra+3LaLym2edzCH4gJVQJQK5i2NwOtmXYP9ZjeQ3O8oEdpi x9sZGJyTiaXX16M/sv2pT3nbWxb5XS4ZkYKZXqETysFX1ldWHRTSZIEJ2DfZAjoqskBR orh0TPP51B73z8bPbLKhaIbM1p5m58uf0lftw2drLWqg7JYAjBlxFwctG6NcLzNQWLZE Tj6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+uHCYd0rqMfB4j7YU6QLObXplVYxcWC9Zpet/RFE40s=; b=FCLpVi9nFHtHRt20/hcd7D0tO8KuhweqB6n0CtkMSYWfvjJt7RuI19kzobdEpscouB iniRKgACHc6I+8K/KBJJv2dMUmRjqpDexxTjrzJh8tCe0U44KgHANIiOdbYUlJ29vXBa rRbfCivNcceXIAOb/WeTt1K/5qVoC8bw+TDylKTj516eRmwLvG3t4EaAJW0MZZlZMPMU ShYtYZR5XLbFuBjdGUOmBW+vOoBICuqQXryIqcXgWcK7nZgbJmSlEr5URES/64ccsqWZ E0OVQ4msuenfkYTFusWd9Pnzfhf0w3/ku8JLxZ6wzYKIj069tz68QCGDDi2V+OmVL72b hXGQ== X-Gm-Message-State: AOAM531Tr+IMWD3DbcCmSJPgzHBUZHLaUQuCyA7iEP40j2UVhBTsLC8z NdkPBBVaRzR897XfpwtxZc99mkRksNnSbLUb X-Google-Smtp-Source: ABdhPJywT+xYeMsvvvF7BvT3gRYcxjhJ0de9gy99Emg2fuCqjspz630zOPss+/bhdU7ECo/eu+drvg== X-Received: by 2002:a2e:b4a5:: with SMTP id q5mr10433570ljm.200.1600320648167; Wed, 16 Sep 2020 22:30:48 -0700 (PDT) Received: from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 22:30:47 -0700 (PDT) From: Michal Krawczyk <mk@semihalf.com> To: dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk <mk@semihalf.com> Date: Thu, 17 Sep 2020 07:30:15 +0200 Message-Id: <20200917053035.1889989-1-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
Upgrade HAL and add ENI metrics support
|
|
Message
Michal Krawczyk
Sept. 17, 2020, 5:30 a.m. UTC
Hi, this patchset contains upgrade of the of the HAL, which, beside some fixes, also adds possibility for reading ENI metrics from the device. Those are further exposed to the DPDK applicaiton using xstats. As it's an extra call to the admin queue during a PMD runtime, for multithread safet the locks had to be added around those functions. Michal Krawczyk (20): net/ena/base: use min/max macros with type conversion net/ena/base: specify operations of rte_delay net/ena/base: support 'resource busy' admin status net/ena/base: exponential delay in polling functions net/ena/base: fix release of wait event net/ena/base: remove MMIOWB_NOT_DEFINED ifdef net/ena/base: rework setup of accelerated LLQ mode net/ena/base: add ENI stats net/ena/base: split RSS function and hash getters net/ena/base: do not use hardcoded RSS key buffer size net/ena/base: check for RSS key configuration support net/ena/base: minor style adjustments net/ena/base: add missing unlikely net/ena/base: store admin stats as u64 net/ena/base: add check for meta desc being NULL net/ena/base: convert values to u32 before shifting net/ena/base: simplify loop copying Rx descs net/ena/base: update generation date and commit net/ena: lock dynamic usages of the admin queue net/ena: expose ENI stats as additional xstats drivers/net/ena/base/ena_com.c | 137 ++++++++++++------ drivers/net/ena/base/ena_com.h | 57 ++++++-- .../net/ena/base/ena_defs/ena_admin_defs.h | 56 ++++++- .../net/ena/base/ena_defs/ena_eth_io_defs.h | 3 +- drivers/net/ena/base/ena_defs/ena_gen_info.h | 5 +- drivers/net/ena/base/ena_defs/ena_regs_defs.h | 3 +- drivers/net/ena/base/ena_eth_com.c | 34 +++-- drivers/net/ena/base/ena_eth_com.h | 2 +- drivers/net/ena/base/ena_plat_dpdk.h | 19 ++- drivers/net/ena/ena_ethdev.c | 86 ++++++++++- drivers/net/ena/ena_ethdev.h | 34 +++++ 11 files changed, 344 insertions(+), 92 deletions(-)
Comments
On Thu, 17 Sep 2020 07:30:15 +0200 Michal Krawczyk <mk@semihalf.com> wrote: > Hi, > > this patchset contains upgrade of the of the HAL, which, beside some fixes, also > adds possibility for reading ENI metrics from the device. > > Those are further exposed to the DPDK applicaiton using xstats. > > As it's an extra call to the admin queue during a PMD runtime, for multithread > safet the locks had to be added around those functions. > > Michal Krawczyk (20): > net/ena/base: use min/max macros with type conversion > net/ena/base: specify operations of rte_delay > net/ena/base: support 'resource busy' admin status > net/ena/base: exponential delay in polling functions > net/ena/base: fix release of wait event > net/ena/base: remove MMIOWB_NOT_DEFINED ifdef > net/ena/base: rework setup of accelerated LLQ mode > net/ena/base: add ENI stats > net/ena/base: split RSS function and hash getters > net/ena/base: do not use hardcoded RSS key buffer size > net/ena/base: check for RSS key configuration support > net/ena/base: minor style adjustments > net/ena/base: add missing unlikely > net/ena/base: store admin stats as u64 > net/ena/base: add check for meta desc being NULL > net/ena/base: convert values to u32 before shifting > net/ena/base: simplify loop copying Rx descs > net/ena/base: update generation date and commit > net/ena: lock dynamic usages of the admin queue > net/ena: expose ENI stats as additional xstats > > drivers/net/ena/base/ena_com.c | 137 ++++++++++++------ > drivers/net/ena/base/ena_com.h | 57 ++++++-- > .../net/ena/base/ena_defs/ena_admin_defs.h | 56 ++++++- > .../net/ena/base/ena_defs/ena_eth_io_defs.h | 3 +- > drivers/net/ena/base/ena_defs/ena_gen_info.h | 5 +- > drivers/net/ena/base/ena_defs/ena_regs_defs.h | 3 +- > drivers/net/ena/base/ena_eth_com.c | 34 +++-- > drivers/net/ena/base/ena_eth_com.h | 2 +- > drivers/net/ena/base/ena_plat_dpdk.h | 19 ++- > drivers/net/ena/ena_ethdev.c | 86 ++++++++++- > drivers/net/ena/ena_ethdev.h | 34 +++++ > 11 files changed, 344 insertions(+), 92 deletions(-) > Looks good Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
On 9/17/2020 6:02 PM, Stephen Hemminger wrote: > On Thu, 17 Sep 2020 07:30:15 +0200 > Michal Krawczyk <mk@semihalf.com> wrote: > >> Hi, >> >> this patchset contains upgrade of the of the HAL, which, beside some fixes, also >> adds possibility for reading ENI metrics from the device. >> >> Those are further exposed to the DPDK applicaiton using xstats. >> >> As it's an extra call to the admin queue during a PMD runtime, for multithread >> safet the locks had to be added around those functions. >> >> Michal Krawczyk (20): >> net/ena/base: use min/max macros with type conversion >> net/ena/base: specify operations of rte_delay >> net/ena/base: support 'resource busy' admin status >> net/ena/base: exponential delay in polling functions >> net/ena/base: fix release of wait event >> net/ena/base: remove MMIOWB_NOT_DEFINED ifdef >> net/ena/base: rework setup of accelerated LLQ mode >> net/ena/base: add ENI stats >> net/ena/base: split RSS function and hash getters >> net/ena/base: do not use hardcoded RSS key buffer size >> net/ena/base: check for RSS key configuration support >> net/ena/base: minor style adjustments >> net/ena/base: add missing unlikely >> net/ena/base: store admin stats as u64 >> net/ena/base: add check for meta desc being NULL >> net/ena/base: convert values to u32 before shifting >> net/ena/base: simplify loop copying Rx descs >> net/ena/base: update generation date and commit >> net/ena: lock dynamic usages of the admin queue >> net/ena: expose ENI stats as additional xstats >> >> drivers/net/ena/base/ena_com.c | 137 ++++++++++++------ >> drivers/net/ena/base/ena_com.h | 57 ++++++-- >> .../net/ena/base/ena_defs/ena_admin_defs.h | 56 ++++++- >> .../net/ena/base/ena_defs/ena_eth_io_defs.h | 3 +- >> drivers/net/ena/base/ena_defs/ena_gen_info.h | 5 +- >> drivers/net/ena/base/ena_defs/ena_regs_defs.h | 3 +- >> drivers/net/ena/base/ena_eth_com.c | 34 +++-- >> drivers/net/ena/base/ena_eth_com.h | 2 +- >> drivers/net/ena/base/ena_plat_dpdk.h | 19 ++- >> drivers/net/ena/ena_ethdev.c | 86 ++++++++++- >> drivers/net/ena/ena_ethdev.h | 34 +++++ >> 11 files changed, 344 insertions(+), 92 deletions(-) >> > > Looks good > > Reviewed-by: Stephen Hemminger <stephen@networkplumber.org> > Series applied to dpdk-next-net/main, thanks.