[v2] test/atomic: reduce the number of loops to avoid timeouts

Message ID 1595907697-20260-1-git-send-email-phil.yang@arm.com (mailing list archive)
State Rejected, archived
Delegated to: David Marchand
Headers
Series [v2] test/atomic: reduce the number of loops to avoid timeouts |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Phil Yang July 28, 2020, 3:41 a.m. UTC
  Reduce the number of loops to 10K to avoid the meson test timeout
warning.

For example:
$ sudo meson test -C build --suite DPDK:fast-tests / atomic_autotest -t 50
[...]
1/1 DPDK:fast-tests / atomic_autotest OK             187.35s

Signed-off-by: Phil Yang <phil.yang@arm.com>
---
v2:
Split from the original patchset.

 app/test/test_atomic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Juraj Linkeš Sept. 17, 2020, 9:17 a.m. UTC | #1
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Phil Yang
> Sent: Tuesday, July 28, 2020 5:42 AM
> To: david.marchand@redhat.com; dev@dpdk.org
> Cc: aconole@redhat.com; Honnappa.Nagarahalli@arm.com;
> Ruifeng.Wang@arm.com; nd@arm.com
> Subject: [dpdk-dev] [PATCH v2] test/atomic: reduce the number of loops to
> avoid timeouts
> 
> Reduce the number of loops to 10K to avoid the meson test timeout warning.
> 
> For example:
> $ sudo meson test -C build --suite DPDK:fast-tests / atomic_autotest -t 50 [...]
> 1/1 DPDK:fast-tests / atomic_autotest OK             187.35s
> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
> v2:
> Split from the original patchset.
> 
>  app/test/test_atomic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c index
> 214452e..9b70f44 100644
> --- a/app/test/test_atomic.c
> +++ b/app/test/test_atomic.c
> @@ -99,7 +99,7 @@
> 
>  #define NUM_ATOMIC_TYPES 3
> 
> -#define N 1000000
> +#define N 10000
> 
>  static rte_atomic16_t a16;
>  static rte_atomic32_t a32;
> --
> 2.7.4
> 

Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
  
Stephen Hemminger June 13, 2023, 3:37 a.m. UTC | #2
On Tue, 28 Jul 2020 11:41:37 +0800
Phil Yang <phil.yang@arm.com> wrote:

> Reduce the number of loops to 10K to avoid the meson test timeout
> warning.
> 
> For example:
> $ sudo meson test -C build --suite DPDK:fast-tests / atomic_autotest -t 50
> [...]
> 1/1 DPDK:fast-tests / atomic_autotest OK             187.35s
> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>

I don't have Arm server to test on but this looks like a serious issue
with Arm performance. FYI the default 1000000 takes 10 seconds on
slow NUC (AMD x86). Is this a problem with the lack of real compare-exchange
and the default atomic retry model for that?

This patch didn't get applied in 3 years but still worth investigating
if anyone has resources.
  

Patch

diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c
index 214452e..9b70f44 100644
--- a/app/test/test_atomic.c
+++ b/app/test/test_atomic.c
@@ -99,7 +99,7 @@ 
 
 #define NUM_ATOMIC_TYPES 3
 
-#define N 1000000
+#define N 10000
 
 static rte_atomic16_t a16;
 static rte_atomic32_t a32;