[v3,01/41] pipeline: add new SWX pipeline type
Checks
Commit Message
Add new improved Software Switch (SWX) pipeline type that supports
dynamically-defined packet headers, meta-data, actions and pipelines.
Actions and pipelines are defined through instructions.
Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/librte_pipeline/meson.build | 10 ++-
lib/librte_pipeline/rte_pipeline_version.map | 3 +
lib/librte_pipeline/rte_swx_pipeline.c | 70 +++++++++++++++++
lib/librte_pipeline/rte_swx_pipeline.h | 79 ++++++++++++++++++++
4 files changed, 160 insertions(+), 2 deletions(-)
create mode 100644 lib/librte_pipeline/rte_swx_pipeline.c
create mode 100644 lib/librte_pipeline/rte_swx_pipeline.h
Comments
On Tue, 8 Sep 2020 21:17:50 +0100
Cristian Dumitrescu <cristian.dumitrescu@intel.com> wrote:
> +/*
> + * Pipeline.
> + */
> +struct rte_swx_pipeline {
> + int build_done;
> + int numa_node;
> +};
> +
> +
Is int the right type for these.
build_done seems like a boolean
and numa_node should be unsigned?
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, September 9, 2020 8:06 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline
> type
>
> On Tue, 8 Sep 2020 21:17:50 +0100
> Cristian Dumitrescu <cristian.dumitrescu@intel.com> wrote:
>
> > +/*
> > + * Pipeline.
> > + */
> > +struct rte_swx_pipeline {
> > + int build_done;
> > + int numa_node;
> > +};
> > +
> > +
>
> Is int the right type for these.
> build_done seems like a Boolean
Isn't the difference between int and bool mostly cosmetic?
AFAIK we don't have a hard rule in DPDK about bool vs. int.
> and numa_node should be unsigned?
All the functions in libnuma use int as the numa_node type, please see: man 3 numa.
Regards,
Cristian
On Wed, Sep 09, 2020 at 07:52:39PM +0000, Dumitrescu, Cristian wrote:
> Hi Stephen,
>
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Wednesday, September 9, 2020 8:06 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 01/41] pipeline: add new SWX pipeline
> > type
> >
> > On Tue, 8 Sep 2020 21:17:50 +0100
> > Cristian Dumitrescu <cristian.dumitrescu@intel.com> wrote:
> >
> > > +/*
> > > + * Pipeline.
> > > + */
> > > +struct rte_swx_pipeline {
> > > + int build_done;
> > > + int numa_node;
> > > +};
> > > +
> > > +
> >
> > Is int the right type for these.
> > build_done seems like a Boolean
>
> Isn't the difference between int and bool mostly cosmetic?
> AFAIK we don't have a hard rule in DPDK about bool vs. int.
>
> > and numa_node should be unsigned?
>
> All the functions in libnuma use int as the numa_node type, please see: man 3 numa.
>
Yes, we also have -1 in DPDK for an unspecified NUMA node, e.g. where a PCI
device is just attached to the chipset rather than direct to the CPU
socket.
/Bruce
@@ -1,6 +1,12 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-sources = files('rte_pipeline.c', 'rte_port_in_action.c', 'rte_table_action.c')
-headers = files('rte_pipeline.h', 'rte_port_in_action.h', 'rte_table_action.h')
+sources = files('rte_pipeline.c',
+ 'rte_port_in_action.c',
+ 'rte_table_action.c',
+ 'rte_swx_pipeline.c',)
+headers = files('rte_pipeline.h',
+ 'rte_port_in_action.h',
+ 'rte_table_action.h',
+ 'rte_swx_pipeline.h',)
deps += ['port', 'table', 'meter', 'sched', 'cryptodev']
@@ -55,4 +55,7 @@ EXPERIMENTAL {
rte_table_action_time_read;
rte_table_action_ttl_read;
rte_table_action_crypto_sym_session_get;
+ rte_swx_pipeline_config;
+ rte_swx_pipeline_build;
+ rte_swx_pipeline_free;
};
new file mode 100644
@@ -0,0 +1,70 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+#include <stdlib.h>
+#include <string.h>
+#include <stdio.h>
+#include <errno.h>
+
+#include <rte_common.h>
+
+#include "rte_swx_pipeline.h"
+
+#define CHECK(condition, err_code) \
+do { \
+ if (!(condition)) \
+ return -(err_code); \
+} while (0)
+
+#define CHECK_NAME(name, err_code) \
+ CHECK((name) && (name)[0], err_code)
+
+/*
+ * Pipeline.
+ */
+struct rte_swx_pipeline {
+ int build_done;
+ int numa_node;
+};
+
+
+/*
+ * Pipeline.
+ */
+int
+rte_swx_pipeline_config(struct rte_swx_pipeline **p, int numa_node)
+{
+ struct rte_swx_pipeline *pipeline;
+
+ /* Check input parameters. */
+ CHECK(p, EINVAL);
+
+ /* Memory allocation. */
+ pipeline = calloc(1, sizeof(struct rte_swx_pipeline));
+ CHECK(pipeline, ENOMEM);
+
+ /* Initialization. */
+ pipeline->numa_node = numa_node;
+
+ *p = pipeline;
+ return 0;
+}
+
+void
+rte_swx_pipeline_free(struct rte_swx_pipeline *p)
+{
+ if (!p)
+ return;
+
+ free(p);
+}
+
+int
+rte_swx_pipeline_build(struct rte_swx_pipeline *p)
+{
+ CHECK(p, EINVAL);
+ CHECK(p->build_done == 0, EEXIST);
+
+ p->build_done = 1;
+ return 0;
+}
new file mode 100644
@@ -0,0 +1,79 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+#ifndef __INCLUDE_RTE_SWX_PIPELINE_H__
+#define __INCLUDE_RTE_SWX_PIPELINE_H__
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @file
+ * RTE SWX Pipeline
+ */
+
+#include <stddef.h>
+#include <stdint.h>
+
+#include <rte_compat.h>
+
+/*
+ * Pipeline setup and operation
+ */
+
+/** Pipeline opaque data structure. */
+struct rte_swx_pipeline;
+
+/**
+ * Pipeline configure
+ *
+ * @param[out] p
+ * Pipeline handle. Must point to valid memory. Contains valid pipeline handle
+ * when the function returns successfully.
+ * @param[in] numa_node
+ * Non-Uniform Memory Access (NUMA) node.
+ * @return
+ * 0 on success or the following error codes otherwise:
+ * -EINVAL: Invalid argument;
+ * -ENOMEM: Not enough space/cannot allocate memory.
+ */
+__rte_experimental
+int
+rte_swx_pipeline_config(struct rte_swx_pipeline **p,
+ int numa_node);
+
+/**
+ * Pipeline build
+ *
+ * Once called, the pipeline build operation marks the end of pipeline
+ * configuration. At this point, all the internal data structures needed to run
+ * the pipeline are built.
+ *
+ * @param[in] p
+ * Pipeline handle.
+ * @return
+ * 0 on success or the following error codes otherwise:
+ * -EINVAL: Invalid argument;
+ * -ENOMEM: Not enough space/cannot allocate memory;
+ * -EEXIST: Pipeline was already built successfully.
+ */
+__rte_experimental
+int
+rte_swx_pipeline_build(struct rte_swx_pipeline *p);
+
+/**
+ * Pipeline free
+ *
+ * @param[in] p
+ * Pipeline handle.
+ */
+__rte_experimental
+void
+rte_swx_pipeline_free(struct rte_swx_pipeline *p);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif