[DPDK] net/e1000: add the VLAN capabilities of NIC
Checks
Commit Message
From: Peng Zhihong <zhihongx.peng@intel.com>
The rte_eth_dev_set_vlan_offload function will check whether the NIC has
the set vlan feature. If it has not, it will return failure. So need
to add all the vlan feature flags of the NIC.
Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
Cc: wei.dai@intel.com
Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
drivers/net/e1000/igb_rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Hi,
> -----Original Message-----
> From: Peng, ZhihongX <zhihongx.peng@intel.com>
> Sent: Monday, July 20, 2020 9:47 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>;
> wei.dai@intel.com
> Subject: [DPDK] net/e1000: add the VLAN capabilities of NIC
>
> From: Peng Zhihong <zhihongx.peng@intel.com>
>
> The rte_eth_dev_set_vlan_offload function will check whether the NIC has the
> set vlan feature. If it has not, it will return failure. So need to add all the vlan
> feature flags of the NIC.
>
> Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
> Cc: wei.dai@intel.com
you should cc stable not wei.dai
>
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
> drivers/net/e1000/igb_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index
> 5717cdb70..966df3f20 100644
> --- a/drivers/net/e1000/igb_rxtx.c
> +++ b/drivers/net/e1000/igb_rxtx.c
> @@ -1647,7 +1647,8 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev
> *dev)
> DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_KEEP_CRC |
> DEV_RX_OFFLOAD_SCATTER |
> - DEV_RX_OFFLOAD_RSS_HASH;
> + DEV_RX_OFFLOAD_RSS_HASH |
> + DEV_RX_OFFLOAD_VLAN_EXTEND;
>
> return rx_offload_capa;
> }
> --
> 2.17.1
@@ -1647,7 +1647,8 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
DEV_RX_OFFLOAD_JUMBO_FRAME |
DEV_RX_OFFLOAD_KEEP_CRC |
DEV_RX_OFFLOAD_SCATTER |
- DEV_RX_OFFLOAD_RSS_HASH;
+ DEV_RX_OFFLOAD_RSS_HASH |
+ DEV_RX_OFFLOAD_VLAN_EXTEND;
return rx_offload_capa;
}