diff mbox series

[v6,2/4] maintainers: claim maintainers of C11 atomics

Message ID 1594115449-13750-3-git-send-email-phil.yang@arm.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series generic rte atomic APIs deprecate proposal |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Phil Yang July 7, 2020, 9:50 a.m. UTC 
  Add the maintainership of C11 atomics code. Different maintainers focus
on different platforms C11 atomics.

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Monjalon July 10, 2020, 5:45 p.m. UTC | #1 
07/07/2020 11:50, Phil Yang:
> Add the maintainership of C11 atomics code. Different maintainers focus
> on different platforms C11 atomics.
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> +C11 Atomics Code Maintainer
> +M: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> +M: David Christensen <drc@linux.vnet.ibm.com>

I remember we discussed the need for identifying maintainers
of C11 atomics code.
However I doubt it will be very useful if there is no file
associated with this responsibility.

Maybe that relying on arch maintainers is enough?
Honnappa Nagarahalli July 10, 2020, 11:41 p.m. UTC | #2 
<snip>

> 
> 07/07/2020 11:50, Phil Yang:
> > Add the maintainership of C11 atomics code. Different maintainers
> > focus on different platforms C11 atomics.
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > +C11 Atomics Code Maintainer
> > +M: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > +M: David Christensen <drc@linux.vnet.ibm.com>
> 
> I remember we discussed the need for identifying maintainers of C11 atomics
> code.
Yes, it was discussed in the tech-board meeting [1].

[1] https://mails.dpdk.org/archives/dev/2020-April/165143.html

> However I doubt it will be very useful if there is no file associated with this
> responsibility.
> 
> Maybe that relying on arch maintainers is enough?
I already see reviews from multiple engineers (not just arch maintainers) on the mailing list on C11 related patches. I think it might be enough.
I am fine to remove this.

>
Phil Yang July 13, 2020, 6:26 a.m. UTC | #3 
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> writes:

<snip>
> 
> >
> > 07/07/2020 11:50, Phil Yang:
> > > Add the maintainership of C11 atomics code. Different maintainers
> > > focus on different platforms C11 atomics.
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > +C11 Atomics Code Maintainer
> > > +M: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > +M: David Christensen <drc@linux.vnet.ibm.com>
> >
> > I remember we discussed the need for identifying maintainers of C11
> atomics
> > code.
> Yes, it was discussed in the tech-board meeting [1].
> 
> [1] https://mails.dpdk.org/archives/dev/2020-April/165143.html
> 
> > However I doubt it will be very useful if there is no file associated with this
> > responsibility.
> >
> > Maybe that relying on arch maintainers is enough?
> I already see reviews from multiple engineers (not just arch maintainers) on
> the mailing list on C11 related patches. I think it might be enough.
> I am fine to remove this.

Removed this patch in the new version.

Thanks,
Phil
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 27fcd6d..3682d2a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -276,6 +276,10 @@  F: lib/librte_eal/include/rte_random.h
 F: lib/librte_eal/common/rte_random.c
 F: app/test/test_rand_perf.c
 
+C11 Atomics Code Maintainer
+M: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
+M: David Christensen <drc@linux.vnet.ibm.com>
+
 ARM v7
 M: Jan Viktorin <viktorin@rehivetech.com>
 M: Ruifeng Wang <ruifeng.wang@arm.com>