diff mbox series

[05/21] net/ixgbe/base: added API for NVM update

Message ID 20200612032410.20864-6-guinanx.sun@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series update ixgbe base code |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Guinan Sun June 12, 2020, 3:23 a.m. UTC 
  When Secure Boot is enabled access to the /dev/mem is forbidden
for user-space applications and clients are reporting inability
to use tools in Secure Boot Mode. The way to perform NVM update
is to use ixgbe driver. Currently 10G Linux Base Driver has API
which allows only EEPROM access. There is a need to extend IOCTL
API to allow NVM and registers access.

Signed-off-by: Piotr Skajewski <piotrx.skajewski@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/ixgbe/base/ixgbe_api.c  | 13 ++++++++++
 drivers/net/ixgbe/base/ixgbe_type.h | 40 +++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+)

Comments

Ferruh Yigit June 22, 2020, 11:59 a.m. UTC | #1 
On 6/12/2020 4:23 AM, Guinan Sun wrote:
> When Secure Boot is enabled access to the /dev/mem is forbidden
> for user-space applications and clients are reporting inability
> to use tools in Secure Boot Mode. The way to perform NVM update
> is to use ixgbe driver. Currently 10G Linux Base Driver has API
> which allows only EEPROM access. There is a need to extend IOCTL
> API to allow NVM and registers access.

If I understand this correctly, this is to enable NVM update through 'ixgbe'
kernel driver, is this needed for the DPDK?

> 
> Signed-off-by: Piotr Skajewski <piotrx.skajewski@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>

<...>

> @@ -4200,6 +4236,10 @@ struct ixgbe_hw {
>  	bool allow_unsupported_sfp;
>  	bool wol_enabled;
>  	bool need_crosstalk_fix;
> +#ifdef IXGBE_NVMUPD_SUPPORT
> +	/* NVM Update features */
> +	struct ixgbe_nvm_features nvmupd_features;
> +#endif

In DPDK is there anywhere that sets this 'IXGBE_NVMUPD_SUPPORT' define?
Guinan Sun June 30, 2020, 2:37 a.m. UTC | #2 
Hi Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, June 22, 2020 7:59 PM
> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> Cc: Skajewski, PiotrX <piotrx.skajewski@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 05/21] net/ixgbe/base: added API for NVM
> update
> 
> On 6/12/2020 4:23 AM, Guinan Sun wrote:
> > When Secure Boot is enabled access to the /dev/mem is forbidden for
> > user-space applications and clients are reporting inability to use
> > tools in Secure Boot Mode. The way to perform NVM update is to use
> > ixgbe driver. Currently 10G Linux Base Driver has API which allows
> > only EEPROM access. There is a need to extend IOCTL API to allow NVM
> > and registers access.
> 
> If I understand this correctly, this is to enable NVM update through 'ixgbe'
> kernel driver, is this needed for the DPDK?
> 
> >
> > Signed-off-by: Piotr Skajewski <piotrx.skajewski@intel.com>
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> 
> <...>
> 
> > @@ -4200,6 +4236,10 @@ struct ixgbe_hw {
> >  	bool allow_unsupported_sfp;
> >  	bool wol_enabled;
> >  	bool need_crosstalk_fix;
> > +#ifdef IXGBE_NVMUPD_SUPPORT
> > +	/* NVM Update features */
> > +	struct ixgbe_nvm_features nvmupd_features; #endif
> 
> In DPDK is there anywhere that sets this 'IXGBE_NVMUPD_SUPPORT' define?

V2 patch will remove this code.
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c
index 9e4763a64..4d61513ec 100644
--- a/drivers/net/ixgbe/base/ixgbe_api.c
+++ b/drivers/net/ixgbe/base/ixgbe_api.c
@@ -95,6 +95,19 @@  s32 ixgbe_init_shared_code(struct ixgbe_hw *hw)
 	}
 	hw->mac.max_link_up_time = IXGBE_LINK_UP_TIME;
 
+#ifdef IXGBE_NVMUPD_SUPPORT
+	/* NVM Update features structure initialization */
+	hw->nvmupd_features.major = IXGBE_NVMUPD_FEATURES_API_VER_MAJOR;
+	hw->nvmupd_features.minor = IXGBE_NVMUPD_FEATURES_API_VER_MINOR;
+	hw->nvmupd_features.size = sizeof(hw->nvmupd_features);
+	memset(hw->nvmupd_features.features, 0x0,
+	       IXGBE_NVMUPD_FEATURES_API_FEATURES_ARRAY_LEN *
+	       sizeof(*hw->nvmupd_features.features));
+
+	hw->nvmupd_features.features[0] =
+		IXGBE_NVMUPD_FEATURE_REGISTER_ACCESS_SUPPORT;
+#endif /* IXGBE_NVMUPD_SUPPORT */
+
 	return status;
 }
 
diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h
index 33ca659cd..c1ee4c680 100644
--- a/drivers/net/ixgbe/base/ixgbe_type.h
+++ b/drivers/net/ixgbe/base/ixgbe_type.h
@@ -169,6 +169,10 @@ 
 #define IXGBE_FLA_X550EM_x	IXGBE_FLA
 #define IXGBE_FLA_X550EM_a	0x15F68
 #define IXGBE_FLA_BY_MAC(_hw)	IXGBE_BY_MAC((_hw), FLA)
+#define IXGBE_FLA_FL_SIZE_SHIFT_X540	17
+#define IXGBE_FLA_FL_SIZE_SHIFT_X550	12
+#define IXGBE_FLA_FL_SIZE_MASK_X540	(0x7 << IXGBE_FLA_FL_SIZE_SHIFT_X540)
+#define IXGBE_FLA_FL_SIZE_MASK_X550	(0x7 << IXGBE_FLA_FL_SIZE_SHIFT_X550)
 
 #define IXGBE_EEMNGCTL	0x10110
 #define IXGBE_EEMNGDATA	0x10114
@@ -1402,6 +1406,7 @@  struct ixgbe_dmac_config {
 #define IXGBE_BARCTRL_FLSIZE		0x0700
 #define IXGBE_BARCTRL_FLSIZE_SHIFT	8
 #define IXGBE_BARCTRL_CSRSIZE		0x2000
+#define IXGBE_BARCTRL_CSRSIZE_SHIFT	13
 
 /* RSCCTL Bit Masks */
 #define IXGBE_RSCCTL_RSCEN	0x01
@@ -3905,6 +3910,37 @@  struct ixgbe_hw_stats {
 	u64 o2bspc;
 };
 
+#ifdef IXGBE_NVMUPD_SUPPORT
+/* NVM Update commands */
+#define IXGBE_NVMUPD_CMD_REG_READ	0x0000000B
+#define IXGBE_NVMUPD_CMD_REG_WRITE	0x0000000C
+
+/* NVM Update features API */
+#define IXGBE_NVMUPD_FEATURES_API_VER_MAJOR		0
+#define IXGBE_NVMUPD_FEATURES_API_VER_MINOR		0
+#define IXGBE_NVMUPD_FEATURES_API_FEATURES_ARRAY_LEN	12
+#define IXGBE_NVMUPD_EXEC_FEATURES			0xe
+#define IXGBE_NVMUPD_FEATURE_FLAT_NVM_SUPPORT		BIT(0)
+#define IXGBE_NVMUPD_FEATURE_REGISTER_ACCESS_SUPPORT	BIT(1)
+
+#define IXGBE_NVMUPD_MOD_PNT_MASK			0xFF
+
+struct ixgbe_nvm_access {
+	u32 command;
+	u32 config;
+	u32 offset;	/* in bytes */
+	u32 data_size;	/* in bytes */
+	u8 data[1];
+};
+
+struct ixgbe_nvm_features {
+	u8 major;
+	u8 minor;
+	u16 size;
+	u8 features[IXGBE_NVMUPD_FEATURES_API_FEATURES_ARRAY_LEN];
+};
+
+#endif
 /* forward declaration */
 struct ixgbe_hw;
 
@@ -4200,6 +4236,10 @@  struct ixgbe_hw {
 	bool allow_unsupported_sfp;
 	bool wol_enabled;
 	bool need_crosstalk_fix;
+#ifdef IXGBE_NVMUPD_SUPPORT
+	/* NVM Update features */
+	struct ixgbe_nvm_features nvmupd_features;
+#endif
 };
 
 #define ixgbe_call_func(hw, func, params, error) \