[v2] mbuf: remove unused next member in dyn flag/field
Checks
Commit Message
TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and
mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's
next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te,
next).
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: stable@dpdk.org
Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---
V2: update subject as Olivier suggested.
lib/librte_mbuf/rte_mbuf_dyn.c | 2 --
1 file changed, 2 deletions(-)
Comments
09/06/2020 09:12, Xiaolong Ye:
> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and
> mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's
> next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te,
> next).
>
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
@@ -19,7 +19,6 @@
#define RTE_MBUF_DYN_MZNAME "rte_mbuf_dyn"
struct mbuf_dynfield_elt {
- TAILQ_ENTRY(mbuf_dynfield_elt) next;
struct rte_mbuf_dynfield params;
size_t offset;
};
@@ -31,7 +30,6 @@ static struct rte_tailq_elem mbuf_dynfield_tailq = {
EAL_REGISTER_TAILQ(mbuf_dynfield_tailq);
struct mbuf_dynflag_elt {
- TAILQ_ENTRY(mbuf_dynflag_elt) next;
struct rte_mbuf_dynflag params;
unsigned int bitnum;
};