diff mbox series

net/softnic: fix resource leak

Message ID 20200427140325.83191-1-jasvinder.singh@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series net/softnic: fix resource leak |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Jasvinder Singh April 27, 2020, 2:03 p.m. UTC 
  When sending request messages to data plane pipelines, the
caller must free the memory allocated to request message on
receiving error response.

Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787

Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table entries")
Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
Fixes: 2505030a8383 ("net/softnic: add command for TTL action")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 drivers/net/softnic/rte_eth_softnic_thread.c | 65 +++++++++++++++-----
 1 file changed, 48 insertions(+), 17 deletions(-)

Comments

John McNamara May 13, 2020, 12:45 p.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
> Sent: Monday, April 27, 2020 3:03 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak
> 
> When sending request messages to data plane pipelines, the caller must
> free the memory allocated to request message on receiving error response.
> 
> Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
> 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
> 
> Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
> Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
> Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table
> entries")
> Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
> Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>




Cristian,

Can you merge this and other Coverity fixes. They need to be cleared for DPDK 20.05.

John
Cristian Dumitrescu May 13, 2020, 1:55 p.m. UTC | #2 
> -----Original Message-----
> From: Mcnamara, John <john.mcnamara@intel.com>
> Sent: Wednesday, May 13, 2020 1:46 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
> > Sent: Monday, April 27, 2020 3:03 PM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak
> >
> > When sending request messages to data plane pipelines, the caller must
> > free the memory allocated to request message on receiving error
> response.
> >
> > Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
> > 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
> >
> > Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
> > Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
> > Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table
> > entries")
> > Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
> > Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> 
> 
> 
> 
> Cristian,
> 
> Can you merge this and other Coverity fixes. They need to be cleared for
> DPDK 20.05.
> 
> John

Ferruh and Jasvinder confirmed these are already merged.
Ferruh Yigit May 13, 2020, 3:32 p.m. UTC | #3 
On 5/13/2020 2:55 PM, Dumitrescu, Cristian wrote:
> 
> 
>> -----Original Message-----
>> From: Mcnamara, John <john.mcnamara@intel.com>
>> Sent: Wednesday, May 13, 2020 1:46 PM
>> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>
>> Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>>
>>> -----Original Message-----
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
>>> Sent: Monday, April 27, 2020 3:03 PM
>>> To: dev@dpdk.org
>>> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>>> Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>>>
>>> When sending request messages to data plane pipelines, the caller must
>>> free the memory allocated to request message on receiving error
>> response.
>>>
>>> Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
>>> 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
>>>
>>> Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
>>> Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
>>> Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table
>>> entries")
>>> Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
>>> Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
>>>
>>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>>
>>
>>
>>
>> Cristian,
>>
>> Can you merge this and other Coverity fixes. They need to be cleared for
>> DPDK 20.05.
>>
>> John
> 
> Ferruh and Jasvinder confirmed these are already merged.
> 

Patches are in the tree Cristian, but I think they are not addressing the
coverity issue correctly, that looks the reason that coverity issues are still
there.
diff mbox series

Patch

diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c
index 028911c19..f45dbbe1e 100644
--- a/drivers/net/softnic/rte_eth_softnic_thread.c
+++ b/drivers/net/softnic/rte_eth_softnic_thread.c
@@ -773,9 +773,9 @@  pipeline_msg_alloc(void)
 }
 
 static void
-pipeline_msg_free(struct pipeline_msg_rsp *rsp)
+pipeline_msg_free(void *msg)
 {
-	free(rsp);
+	free(msg);
 }
 
 static struct pipeline_msg_rsp *
@@ -843,8 +843,10 @@  softnic_pipeline_port_in_stats_read(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -892,8 +894,10 @@  softnic_pipeline_port_in_enable(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -939,8 +943,10 @@  softnic_pipeline_port_in_disable(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -994,8 +1000,10 @@  softnic_pipeline_port_out_stats_read(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1051,8 +1059,10 @@  softnic_pipeline_table_stats_read(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1331,8 +1341,10 @@  softnic_pipeline_table_rule_add(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1415,8 +1427,10 @@  softnic_pipeline_table_rule_add_default(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1573,8 +1587,10 @@  softnic_pipeline_table_rule_add_bulk(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1638,8 +1654,10 @@  softnic_pipeline_table_rule_delete(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1688,8 +1706,10 @@  softnic_pipeline_table_rule_delete_default(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1748,8 +1768,10 @@  softnic_pipeline_table_rule_stats_read(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1831,6 +1853,7 @@  softnic_pipeline_table_mtr_profile_add(struct pmd_internals *softnic,
 	rsp = pipeline_msg_send_recv(p, req);
 	if (rsp == NULL) {
 		free(mp);
+		pipeline_msg_free(req);
 		return -1;
 	}
 
@@ -1888,8 +1911,10 @@  softnic_pipeline_table_mtr_profile_delete(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1951,8 +1976,10 @@  softnic_pipeline_table_rule_mtr_read(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -2016,8 +2043,10 @@  softnic_pipeline_table_dscp_table_update(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;
@@ -2081,8 +2110,10 @@  softnic_pipeline_table_rule_ttl_read(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
+	if (rsp == NULL) {
+		pipeline_msg_free(req);
 		return -1;
+	}
 
 	/* Read response */
 	status = rsp->status;