diff mbox series

[20.08] buildtools/map_to_def.py: drop python2 support

Message ID 20200513110249.26667-1-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [20.08] buildtools/map_to_def.py: drop python2 support |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-testing fail Testing issues

Commit Message

Bruce Richardson May 13, 2020, 11:02 a.m. UTC 
  The build scripts called from meson all use python3 as meson itself depends
upon python3. Therefore there is no need for python2 compatibility in these
script files.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 buildtools/map_to_def.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Burakov, Anatoly May 13, 2020, 11:54 a.m. UTC | #1 
On 13-May-20 12:02 PM, Bruce Richardson wrote:
> The build scripts called from meson all use python3 as meson itself depends
> upon python3. Therefore there is no need for python2 compatibility in these
> script files.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

I think there was a reimplementation of check_output there that isn't 
necessary any more either. (and hasn't been for some time...)

Otherwise,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Bruce Richardson May 13, 2020, 12:48 p.m. UTC | #2 
On Wed, May 13, 2020 at 12:54:21PM +0100, Burakov, Anatoly wrote:
> On 13-May-20 12:02 PM, Bruce Richardson wrote:
> > The build scripts called from meson all use python3 as meson itself depends
> > upon python3. Therefore there is no need for python2 compatibility in these
> > script files.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> 
> I think there was a reimplementation of check_output there that isn't
> necessary any more either. (and hasn't been for some time...)
>
Not sure what you are referring to here. Perhaps a different script file?
Burakov, Anatoly May 14, 2020, 1:15 p.m. UTC | #3 
On 13-May-20 1:48 PM, Bruce Richardson wrote:
> On Wed, May 13, 2020 at 12:54:21PM +0100, Burakov, Anatoly wrote:
>> On 13-May-20 12:02 PM, Bruce Richardson wrote:
>>> The build scripts called from meson all use python3 as meson itself depends
>>> upon python3. Therefore there is no need for python2 compatibility in these
>>> script files.
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> ---
>>
>> I think there was a reimplementation of check_output there that isn't
>> necessary any more either. (and hasn't been for some time...)
>>
> Not sure what you are referring to here. Perhaps a different script file?
> 

Oh, sorry, yes. I slightly misread the patch description :)
diff mbox series

Patch

diff --git a/buildtools/map_to_def.py b/buildtools/map_to_def.py
index 6775b54a9..9edde7a67 100644
--- a/buildtools/map_to_def.py
+++ b/buildtools/map_to_def.py
@@ -1,8 +1,7 @@ 
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-from __future__ import print_function
 import sys
 from os.path import dirname, basename, join, exists