crypto/nitrox: add 3DES-CBC support
Checks
Commit Message
This patch adds 3DES CBC mode cipher algorithm.
Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
---
app/test/test_cryptodev.c | 1 +
app/test/test_cryptodev_des_test_vectors.h | 6 ++++--
doc/guides/cryptodevs/features/nitrox.ini | 1 +
doc/guides/cryptodevs/nitrox.rst | 2 ++
drivers/crypto/nitrox/nitrox_sym.c | 4 ++++
drivers/crypto/nitrox/nitrox_sym_capabilities.c | 21 ++++++++++++++++++++-
6 files changed, 32 insertions(+), 3 deletions(-)
Comments
>
> This patch adds 3DES CBC mode cipher algorithm.
>
> Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> ---
Is it worth mentioning in release notes?
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Thursday, March 26, 2020 12:18 AM
> To: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> Cc: dev@dpdk.org; Srikanth Jampala <jsrikanth@marvell.com>
> Subject: [EXT] RE: [PATCH] crypto/nitrox: add 3DES-CBC support
>
> External Email
>
> ----------------------------------------------------------------------
> >
> > This patch adds 3DES CBC mode cipher algorithm.
> >
> > Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> > ---
> Is it worth mentioning in release notes?
I added that description to avoid below checkpatch warning:
### crypto/nitrox: add 3DES-CBC support
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 83 lines checked
0/1 valid patch
> > ----------------------------------------------------------------------
> > >
> > > This patch adds 3DES CBC mode cipher algorithm.
> > >
> > > Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> > > ---
> > Is it worth mentioning in release notes?
>
> I added that description to avoid below checkpatch warning:
>
> ### crypto/nitrox: add 3DES-CBC support
>
> WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> appropriate one
>
> total: 0 errors, 1 warnings, 83 lines checked
>
> 0/1 valid patch
I think you misinterpreted my comment.
I was talking about release notes and not patch description.
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, April 1, 2020 7:38 PM
> To: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> Cc: dev@dpdk.org; Srikanth Jampala <jsrikanth@marvell.com>
> Subject: [EXT] RE: [PATCH] crypto/nitrox: add 3DES-CBC support
>
> External Email
>
> ----------------------------------------------------------------------
> > > --------------------------------------------------------------------
> > > --
> > > >
> > > > This patch adds 3DES CBC mode cipher algorithm.
> > > >
> > > > Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> > > > ---
> > > Is it worth mentioning in release notes?
> >
> > I added that description to avoid below checkpatch warning:
> >
> > ### crypto/nitrox: add 3DES-CBC support
> >
> > WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> > appropriate one
> >
> > total: 0 errors, 1 warnings, 83 lines checked
> >
> > 0/1 valid patch
>
> I think you misinterpreted my comment.
> I was talking about release notes and not patch description.
I haven't added that description in the release notes.
I only added description in the Limitations section.
> > > > --
> > > > >
> > > > > This patch adds 3DES CBC mode cipher algorithm.
> > > > >
> > > > > Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> > > > > ---
> > > > Is it worth mentioning in release notes?
> > >
> > > I added that description to avoid below checkpatch warning:
> > >
> > > ### crypto/nitrox: add 3DES-CBC support
> > >
> > > WARNING:COMMIT_MESSAGE: Missing commit description - Add an
> > > appropriate one
> > >
> > > total: 0 errors, 1 warnings, 83 lines checked
> > >
> > > 0/1 valid patch
> >
> > I think you misinterpreted my comment.
> > I was talking about release notes and not patch description.
>
> I haven't added that description in the release notes.
> I only added description in the Limitations section.
OK, it seems you do not want to add this in release notes.
Applied to dpdk-next-crypto
Thanks.
@@ -13117,6 +13117,7 @@ static struct unit_test_suite cryptodev_nitrox_testsuite = {
TEST_CASE_ST(ut_setup, ut_teardown,
test_device_configure_invalid_queue_pair_ids),
TEST_CASE_ST(ut_setup, ut_teardown, test_AES_chain_all),
+ TEST_CASE_ST(ut_setup, ut_teardown, test_3DES_chain_all),
TEST_CASES_END() /**< NULL terminate unit test array */
}
@@ -1115,7 +1115,8 @@ static const struct blockcipher_test_case triple_des_chain_test_cases[] = {
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
- BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
+ BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2 |
+ BLOCKCIPHER_TEST_TARGET_PMD_NITROX
},
{
.test_descr = "3DES-192-CBC HMAC-SHA1 Decryption Digest Verify",
@@ -1129,7 +1130,8 @@ static const struct blockcipher_test_case triple_des_chain_test_cases[] = {
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
- BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
+ BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2 |
+ BLOCKCIPHER_TEST_TARGET_PMD_NITROX
},
{
.test_descr = "3DES-192-CBC SHA1 Encryption Digest",
@@ -20,6 +20,7 @@ OOP LB In LB Out = Y
AES CBC (128) = Y
AES CBC (192) = Y
AES CBC (256) = Y
+3DES CBC = Y
;
; Supported authentication algorithms of the 'nitrox' crypto driver.
@@ -18,6 +18,7 @@ Nitrox crypto PMD has support for:
Cipher algorithms:
* ``RTE_CRYPTO_CIPHER_AES_CBC``
+* ``RTE_CRYPTO_CIPHER_3DES_CBC``
Hash algorithms:
@@ -29,6 +30,7 @@ Limitations
-----------
* AES_CBC Cipher Only combination is not supported.
+* 3DES Cipher Only combination is not supported.
* Session-less APIs are not supported.
Installation
@@ -314,6 +314,10 @@ get_flexi_cipher_type(enum rte_crypto_cipher_algorithm algo, bool *is_aes)
type = CIPHER_AES_CBC;
*is_aes = true;
break;
+ case RTE_CRYPTO_CIPHER_3DES_CBC:
+ type = CIPHER_3DES_CBC;
+ *is_aes = false;
+ break;
default:
type = CIPHER_INVALID;
NITROX_LOG(ERR, "Algorithm not supported %d\n", algo);
@@ -88,7 +88,26 @@ static const struct rte_cryptodev_capabilities nitrox_capabilities[] = {
}, }
}, }
},
-
+ { /* 3DES CBC */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+ {.cipher = {
+ .algo = RTE_CRYPTO_CIPHER_3DES_CBC,
+ .block_size = 8,
+ .key_size = {
+ .min = 24,
+ .max = 24,
+ .increment = 0
+ },
+ .iv_size = {
+ .min = 8,
+ .max = 8,
+ .increment = 0
+ }
+ }, }
+ }, }
+ },
RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
};