Message ID | 1582130850-6958-1-git-send-email-wisamm@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C058A0555; Wed, 19 Feb 2020 17:47:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC3761B951; Wed, 19 Feb 2020 17:47:40 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80053.outbound.protection.outlook.com [40.107.8.53]) by dpdk.org (Postfix) with ESMTP id 1230823D; Wed, 19 Feb 2020 17:47:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9KFnPST1nUMFDLwzW7uVMTAA/8PDxlad/1T+HpCT5WC8goFOmSrBQBqSGNvXB8n6CTwwBRkpb0SDbzRsCBZJrg5SHXXdWv5iT2lAHL1MktxmfmvcCQlEkIJLD6UyZKavpF9EJ1hzNhFPQsCUCDpFcgfLiJ+B6QRyl597jU3anY0iAst8uIi2vY62ZjS0W8SgoirwgEmdev7wjZHyVDZyt4pAck+5xb4+7PuPpaYyUBfRzMroJzDRbStCwykgr2Z0RbNDWaXYCW+jP5ulk9LV7mTvOtoikO4yL7UQDYvt/3FH2Ypd2h4vbTR30kvcy2Br6YdZdms05ooCe+nT/o8iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+nV3UwIPkGKideIO5suGEFRxyIKMEUq7xj4j5MpyME=; b=F7whUbMsjQkU3pURMQIEbE1ehtjuavmmCCULXoLS7LVjZxhqbwxtyuoT9wgjBWaQkbPZym9ezYAPKOGsvRPsJcUcUO3v8WT0mCGvQ9xEAyPfgW5tWq18I7wG6+cWXIG3VQalQagnnR0DxFBQxSlgGwfM0f7a9JTgbU376uA3A2UmPVqTUv75/aupe941/HpLC6oivDxt7sMANqXzDPTvapW8zT5XBwNrvrm4TC9BfVWc0cEG8GtJIRUW1TG9OmPYq89RcxwwWAFK11t+P4tjI654mxNuL+ALhFRqHME+1XnTxgdHWBU35uwDP1A8UPEuGQSADnPvtFqc7MlbzF8AMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+nV3UwIPkGKideIO5suGEFRxyIKMEUq7xj4j5MpyME=; b=RPubAz6ro6KKy0fSRcvTuHSkaPptk846/uHqtleoLPiRDQBmnFfU9we5ggJYADczSAQbEXGsiPSGhnvc6MnVxPZwLaEVMTDzw79NDplu+AmI1D45giMXRF73BurvCaY6SsRP3XsKq/nackhyQsy0YFO0yWk4/KELGzJ/TuHmJEE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=wisamm@mellanox.com; Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (20.178.202.18) by AM0PR05MB5027.eurprd05.prod.outlook.com (20.177.40.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.31; Wed, 19 Feb 2020 16:47:38 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758%3]) with mapi id 15.20.2750.016; Wed, 19 Feb 2020 16:47:37 +0000 From: Wisam Jaddo <wisamm@mellanox.com> To: wenzhuo.lu@intel.com, dev@dpdk.org, rasland@mellanox.com, matan@mellanox.com Cc: mukawa@igel.co.jp, stable@dpdk.org Date: Wed, 19 Feb 2020 18:47:30 +0200 Message-Id: <1582130850-6958-1-git-send-email-wisamm@mellanox.com> X-Mailer: git-send-email 2.7.4 Content-Type: text/plain X-ClientProxiedBy: PR0P264CA0087.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::27) To AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (37.142.13.130) by PR0P264CA0087.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2750.18 via Frontend Transport; Wed, 19 Feb 2020 16:47:36 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [37.142.13.130] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 770601d5-da4f-4714-276b-08d7b55b6d4b X-MS-TrafficTypeDiagnostic: AM0PR05MB5027:|AM0PR05MB5027: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <AM0PR05MB50273286C33DC966443ED0DCA9100@AM0PR05MB5027.eurprd05.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-Forefront-PRVS: 0318501FAE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(189003)(199004)(8886007)(6666004)(52116002)(26005)(4326008)(956004)(2616005)(66556008)(478600001)(186003)(7696005)(16526019)(66476007)(8936002)(55016002)(316002)(6636002)(66946007)(2906002)(81166006)(81156014)(36756003)(5660300002)(86362001)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5027; H:AM0PR05MB6610.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7JXnFaQ5aVbK+YX5DJuwZ9mzt1rtwqdtQVMg97Xc6lDLUDcxQt4WA/xMV5ZIAfdbvVjQGiW3xwE6WCU2GzNB4omE83WNkOZR579u/VYzAhEVv8TYA7GX8k5BgLNrYEgIQuteFRAya+b3zTeuQMl3srEZR9MDL5BGpkCPfYhmPDd2ZHsOU4xrWLEdaDEuHzhqJmCNopYp0esHBz1rWg1N0b8fRFPYBwiFT5rVGkhlm6bFkyLWkKK9lb72AnEFPhwWtt0m+4c8wQ6xidoePJiFA2u3zJvNoGn34Jm6fSWD4ioPxb4E6MFfKDbBk6d0EFBCm4vOhTvKnzdJcpwiXNMdVVoVPCJvNP9LwRLgBTRKu9JlvIe3AX88M0JJRSrD5yY+uiPkf5pYe5qENlT0KDH55WTdjGT/dGfIYzy5zmzhvK883+WeHimIR+7MSXNxZgGH X-MS-Exchange-AntiSpam-MessageData: 201HdL4rIBPaAmSEX78aUlnglMBO6a/iZF8xi1NPyDYejMbouUwysYiShlkXvOPETH9PCJ4pMGOyuekm2Flhf4Bf0Iev9DVq4NG84apd3yy3oKrTsY++2wKd/v9WWngCeTg/V7w5KcKkzAnlBwUWHA== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 770601d5-da4f-4714-276b-08d7b55b6d4b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2020 16:47:37.8616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y4T4cH9CJsig+4Vsn8ryF7O4rNiKBxoMHv72Y+pwD5RjfJfeMqHZhyyoHOpXQ3p3Wdba1MhYwdGAMYgEbjrx9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5027 Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
app/testpmd: fix identifier size for port attach
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/iol-testing | success | Testing PASS |
ci/Intel-compilation | fail | apply issues |
ci/travis-robot | success | Travis build: passed |
Commit Message
Wisam Jaddo
Feb. 19, 2020, 4:47 p.m. UTC
Identifier for new port may contain white list options,
and white list options will not fit into 128 from STR_TOKEN_SIZE,
instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
better and more options
Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
Cc: mukawa@igel.co.jp
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
> -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Wisam Jaddo > Sent: Wednesday, February 19, 2020 4:48 PM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org; > rasland@mellanox.com; matan@mellanox.com > Cc: mukawa@igel.co.jp; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach > > Identifier for new port may contain white list options, and white list options > will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from > STR_MULTI_TOKEN_SIZE will provide better and more options > > Fixes: edab33b1c01d ("app/testpmd: support port hotplug") > Cc: mukawa@igel.co.jp > Cc: stable@dpdk.org > > Signed-off-by: Wisam Jaddo <wisamm@mellanox.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
On 2/19/2020 4:47 PM, Wisam Jaddo wrote: > Identifier for new port may contain white list options, > and white list options will not fit into 128 from STR_TOKEN_SIZE, > instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide > better and more options Out of curiosity, what device identifier doesn't fit to 128 chars, can you please give a sample? > > Fixes: edab33b1c01d ("app/testpmd: support port hotplug") > Cc: mukawa@igel.co.jp > Cc: stable@dpdk.org > > Signed-off-by: Wisam Jaddo <wisamm@mellanox.com> > --- > app/test-pmd/cmdline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 38b6d80..a037a55 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = { > struct cmd_operate_attach_port_result { > cmdline_fixed_string_t port; > cmdline_fixed_string_t keyword; > - cmdline_fixed_string_t identifier; > + cmdline_multi_string_t identifier; > }; > > static void cmd_operate_attach_port_parsed(void *parsed_result, > @@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword = > keyword, "attach"); > cmdline_parse_token_string_t cmd_operate_attach_port_identifier = > TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result, > - identifier, NULL); > + identifier, TOKEN_STRING_MULTI); > > cmdline_parse_inst_t cmd_operate_attach_port = { > .f = cmd_operate_attach_port_parsed, >
When attaching new device, it needs to pass the white list options with the PCI, For example if I want the following set of options with the new attach device it will fail Due to not enough space: port attach 0000:03:00.0,l3_vxlan_en=1,txq_inline_mpw=77,dv_xmeta_en=1,txqs_min_inline=0,dv_esw_en=1,dv_flow_en=1,txq_inline_min=28,txq_inline_max=65 -----Original Message----- From: Ferruh Yigit <ferruh.yigit@intel.com> Sent: Thursday, February 20, 2020 2:28 PM To: Wisam Monther <wisamm@mellanox.com>; wenzhuo.lu@intel.com; dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Matan Azrad <matan@mellanox.com> Cc: mukawa@igel.co.jp; stable@dpdk.org Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach On 2/19/2020 4:47 PM, Wisam Jaddo wrote: > Identifier for new port may contain white list options, and white list > options will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 > char from STR_MULTI_TOKEN_SIZE will provide better and more options Out of curiosity, what device identifier doesn't fit to 128 chars, can you please give a sample? > > Fixes: edab33b1c01d ("app/testpmd: support port hotplug") > Cc: mukawa@igel.co.jp > Cc: stable@dpdk.org > > Signed-off-by: Wisam Jaddo <wisamm@mellanox.com> > --- > app/test-pmd/cmdline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 38b6d80..a037a55 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = { > struct cmd_operate_attach_port_result { > cmdline_fixed_string_t port; > cmdline_fixed_string_t keyword; > - cmdline_fixed_string_t identifier; > + cmdline_multi_string_t identifier; > }; > > static void cmd_operate_attach_port_parsed(void *parsed_result, @@ > -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword = > keyword, "attach"); > cmdline_parse_token_string_t cmd_operate_attach_port_identifier = > TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result, > - identifier, NULL); > + identifier, TOKEN_STRING_MULTI); > > cmdline_parse_inst_t cmd_operate_attach_port = { > .f = cmd_operate_attach_port_parsed, >
On 2/20/2020 10:03 AM, Iremonger, Bernard wrote: > >> -----Original Message----- >> From: dev <dev-bounces@dpdk.org> On Behalf Of Wisam Jaddo >> Sent: Wednesday, February 19, 2020 4:48 PM >> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org; >> rasland@mellanox.com; matan@mellanox.com >> Cc: mukawa@igel.co.jp; stable@dpdk.org >> Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach >> >> Identifier for new port may contain white list options, and white list options >> will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from >> STR_MULTI_TOKEN_SIZE will provide better and more options >> >> Fixes: edab33b1c01d ("app/testpmd: support port hotplug") >> Cc: mukawa@igel.co.jp >> Cc: stable@dpdk.org >> >> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com> > > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com> > Applied to dpdk-next-net/master, thanks.
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 38b6d80..a037a55 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = { struct cmd_operate_attach_port_result { cmdline_fixed_string_t port; cmdline_fixed_string_t keyword; - cmdline_fixed_string_t identifier; + cmdline_multi_string_t identifier; }; static void cmd_operate_attach_port_parsed(void *parsed_result, @@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword = keyword, "attach"); cmdline_parse_token_string_t cmd_operate_attach_port_identifier = TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result, - identifier, NULL); + identifier, TOKEN_STRING_MULTI); cmdline_parse_inst_t cmd_operate_attach_port = { .f = cmd_operate_attach_port_parsed,