Message ID | 1582204709-7992-1-git-send-email-wisamm@mellanox.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 052D3A0556; Thu, 20 Feb 2020 14:18:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B86061C0AD; Thu, 20 Feb 2020 14:18:39 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70072.outbound.protection.outlook.com [40.107.7.72]) by dpdk.org (Postfix) with ESMTP id 861C91C0AC; Thu, 20 Feb 2020 14:18:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUD7hunhAQdcPwRfBp2wzJFRRSGm+OqiDQ6SScwIgqYxfBlkFrZJB6n/tHfQp99XWJ1SwzNlcFP/fu09kHhsiiz7Ht9JdzzpUfyRQ/dH3V7/X61g0NBuYLBcShulwGJrAH+c7oJIbfgZpNNm7PqDtWdFFXQJ1AgixIPmyjEs8b33qALDoX8zBypynzqDVWGC6NL02svKNUy42rBATl5td83oPCDgmgBpMnoa8vLq6BZKV0EsN4q99HhTcG5a0Jkwnxh/R2aNDxYbi4pugtw5O/FjkJ4bx46lsIX9wI+lr3XYDjnsfIFZ9v/t1nErrA5zo8VqWyVqramzjpeUCwbegQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J7xooVBRljuvGRDFm2gQBZ4Rt6d4Jpb+217Y0sm2nhA=; b=GmCM4C+495zKj1lFQFWu/Wo0Ta6+8CTLFFQOXGUfdav72cguDL4hv/tbDwh5lr+RjxPuY5gI+YKjN+0zRcdcWP2QWopDgGodFOa4LxlqE0quV4y4S3aXbjCpQWfJGDGJSjIGaF4s0sg+P5clvYeAXf4SLK19JdUQVJGrVdOl8ZxMaFihl3m87K+Bys6Jtge4wRhwE40IvzJ/tgfjl6fRKPBYb3YPN3dFKO40+i9VowSG4s5KFZLBeuo+e1m5OJnwso2X0EvBx7jS5dCHt2NTv3Z6tHrFt01LugB3l3t2vcXGx2Vjh+2BhXSKimgq2cK4Kmw48D30nUHfI6HcCIOZIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J7xooVBRljuvGRDFm2gQBZ4Rt6d4Jpb+217Y0sm2nhA=; b=lgufF+byYQVS3B+E560Up+HLjBJH4dInfWviCr1pcicENQEZ3WW0DeKsFHVlaMVvUxTgplWVvXFPb1M9eBuJikLlHHS89wZ/t/Z2b+DxJNy+ho40Oxw7sgmZYkpTfyF777G1CYrHv/HOszTydG1agP+aeE4AAGyOHbdKbBu575o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=wisamm@mellanox.com; Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (20.178.202.18) by AM0PR05MB5892.eurprd05.prod.outlook.com (20.178.119.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Thu, 20 Feb 2020 13:18:36 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758%3]) with mapi id 15.20.2750.016; Thu, 20 Feb 2020 13:18:36 +0000 From: Wisam Jaddo <wisamm@mellanox.com> To: dev@dpdk.org, rasland@mellanox.com, thomasm@mellanox.com Cc: stable@dpdk.org Date: Thu, 20 Feb 2020 15:18:29 +0200 Message-Id: <1582204709-7992-1-git-send-email-wisamm@mellanox.com> X-Mailer: git-send-email 2.7.4 Content-Type: text/plain X-ClientProxiedBy: PR0P264CA0031.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::19) To AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (37.142.13.130) by PR0P264CA0031.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2750.17 via Frontend Transport; Thu, 20 Feb 2020 13:18:35 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [37.142.13.130] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9a5a44de-2ca3-4788-a4fb-08d7b607646e X-MS-TrafficTypeDiagnostic: AM0PR05MB5892:|AM0PR05MB5892: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <AM0PR05MB589284B5DB2927491E99D96AA9130@AM0PR05MB5892.eurprd05.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:989; X-Forefront-PRVS: 031996B7EF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(136003)(366004)(39850400004)(396003)(199004)(189003)(8936002)(956004)(4744005)(2616005)(86362001)(66556008)(66476007)(55016002)(66946007)(2906002)(316002)(8886007)(6666004)(5660300002)(81166006)(186003)(81156014)(4326008)(450100002)(8676002)(26005)(52116002)(478600001)(36756003)(6636002)(7696005)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5892; H:AM0PR05MB6610.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JccS0RKGKJQZtF2xo3b4Mr//zey95Vaz5//L1NTv0LUhzhEviuRT8h6XJQVnfOUgBlhsLc9JDyV1sdnhbEWjydpZnyB7gjj8QxqDWWrlyZ6CmgUKo8lSixno4pVoR9UCoaHICtVMmcxWj1sXYjazqgXtq3fLcjcc95Z9c6QAV6cUp7q7dgdue52wN57EOit/KzTVOb0W3Ad0p0Nftd4z+SZG8gEjajKJk9PFYm9Bf6sUwb3n2kiaAl7lUsxCnvkvLksogJ6LNdtYwULlrZMysRWzLazWEp00GPcp2VNpx7LPgfU7n7ROptj/1jRwlyUdxPNefoGkQjmHeVIbvs+PbMgUea3799ZrZ/4Q76xuYRsur9FFvWw/Bv+AjprDgT9ci6/N9lYK6cBKQ2J0BHg3lplN2unIgPGkW47NMs6zYddTNAVIyDwIW9rjIICkjFFo X-MS-Exchange-AntiSpam-MessageData: JLR1Lj0ZeFBsDaunVyJVRjqDcnBidzDmKXcfHdPkwEazW6rzjTG7PslYa0ebgLrMttu8X41stvy0Z4yd7eIZ3+kAzqqX5AvQzvoWUr0RPu3/buPG1DmiW74zTRy/wtUiCFkRBrkIEjWM4FpdCMQY6A== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5a44de-2ca3-4788-a4fb-08d7b607646e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2020 13:18:36.4802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R0fzFJ5tU2/1usuvhmB7BGNpXHF1liz0iB3KuhkQ1RRfdG4JexKhD1DcrUzR+oTOjulyEXRGMdzyYYxHCvkekg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5892 Subject: [dpdk-dev] [PATCH] lib/cmdline_rdline: increase command line buf size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
lib/cmdline_rdline: increase command line buf size
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-testing | success | Testing PASS |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/Intel-compilation | success | Compilation OK |
ci/travis-robot | warning | Travis build: failed |
Commit Message
Wisam Jaddo
Feb. 20, 2020, 1:18 p.m. UTC
The current size of buffer is not enough to fit all allowed items/actions,
thus it will block a lot of testing.
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
lib/librte_cmdline/cmdline_rdline.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, About the title, I suggest: cmdline: increase maximum line length 20/02/2020 14:18, Wisam Jaddo: > The current size of buffer is not enough to fit all allowed items/actions, > thus it will block a lot of testing. > > Cc: stable@dpdk.org +Cc maintainers of cmdline and testpmd > Signed-off-by: Wisam Jaddo <wisamm@mellanox.com> [...] > -#define RDLINE_BUF_SIZE 512 > +#define RDLINE_BUF_SIZE 2048 I feel 2k is reasonable. What is the consequence on memory usage? How critical is this change? Which kind of command is so long?
Hi, Sure I'll handle the title with the right prefix. - consequence on memory usage? I don't think it will affect much, Since we are reading from the same buffer all the time, Read -> reset -> read again -> ...etc - How critical is this change? For now it's not that critical, but for testing perspective I think it's critical, And it's a must to have so we can check un touched scenarios. Example: one rule can have outer items, inner items, actions ={ header rewrite, meta actions, duplicate actions, fate action, ..etc} thus to test such combination we need to parse more in the cmdline - Which kind of command is so long? RTE_FLOW Example: flow create 2 ingress priority 0 group 4 transfer pattern eth / ipv4 tos spec 0x0 ttl spec 0x0 proto spec 0x6 src spec 4.4.4.11 dst spec 4.4.4.10 tos mask 0x0 ttl mask 0x0 proto mask 0x0 src mask 255.255.255.255 dst mask 255.255.255.255 / tcp src spec 5001 dst spec 38392 flags spec 0x0 src mask 65535 dst mask 65535 flags mask 0x5 / tag index is 0 data spec 0x00000200 data mask 0x0000ff00 / end actions count / set_tag index 0 data 0x00000200 mask 0x0000ff00 / set_tag index 0 data 0x0000002a mask 0x000000ff / set_meta data 0x00000001 mask 0x0000ffff / jump group 7 / end BRs, Wisam Jaddo -----Original Message----- From: Thomas Monjalon <thomas@monjalon.net> Sent: Thursday, February 20, 2020 3:43 PM To: Wisam Monther <wisamm@mellanox.com> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; stable@dpdk.org; olivier.matz@6wind.com; bernard.iremonger@intel.com Subject: Re: [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size Hi, About the title, I suggest: cmdline: increase maximum line length 20/02/2020 14:18, Wisam Jaddo: > The current size of buffer is not enough to fit all allowed > items/actions, thus it will block a lot of testing. > > Cc: stable@dpdk.org +Cc maintainers of cmdline and testpmd > Signed-off-by: Wisam Jaddo <wisamm@mellanox.com> [...] > -#define RDLINE_BUF_SIZE 512 > +#define RDLINE_BUF_SIZE 2048 I feel 2k is reasonable. What is the consequence on memory usage? How critical is this change? Which kind of command is so long?
diff --git a/lib/librte_cmdline/cmdline_rdline.h b/lib/librte_cmdline/cmdline_rdline.h index d217029..8193e1d 100644 --- a/lib/librte_cmdline/cmdline_rdline.h +++ b/lib/librte_cmdline/cmdline_rdline.h @@ -39,7 +39,7 @@ extern "C" { #endif /* configuration */ -#define RDLINE_BUF_SIZE 512 +#define RDLINE_BUF_SIZE 2048 #define RDLINE_PROMPT_SIZE 32 #define RDLINE_VT100_BUF_SIZE 8 #define RDLINE_HISTORY_BUF_SIZE BUFSIZ