[v5,8/9] build: add additional common files support
Checks
Commit Message
Added support for additional common files in meson build
to expand Windows EAL and to support the lcore parsing
feature on Windows.
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Signed-off-by: Antara Ganesh Kolar <antara.ganesh.kolar@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
Reviewed-by: Keith Wiles <keith.wiles@intel.com>
---
lib/librte_eal/windows/eal/meson.build | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Comments
13/01/2020 22:55, Pallavi Kadam:
> Added support for additional common files in meson build
> to expand Windows EAL and to support the lcore parsing
> feature on Windows.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Signed-off-by: Antara Ganesh Kolar <antara.ganesh.kolar@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> Reviewed-by: Keith Wiles <keith.wiles@intel.com>
> ---
> --- a/lib/librte_eal/windows/eal/meson.build
> +++ b/lib/librte_eal/windows/eal/meson.build
> common_sources = files(
> + '../../common/eal_common_bus.c',
> + '../../common/eal_common_class.c',
> + '../../common/eal_common_devargs.c',
> '../../common/eal_common_errno.c',
> '../../common/eal_common_launch.c',
> '../../common/eal_common_lcore.c',
> - '../../common/eal_common_log.c'
> + '../../common/eal_common_log.c',
> + '../../common/eal_common_options.c',
> + '../../common/eal_common_thread.c',
> + '../../common/rte_option.c'
Please add a comma after the last item of the list, so the next patch
won't need to change this line.
On 1/27/2020 2:55 PM, Thomas Monjalon wrote:
> 13/01/2020 22:55, Pallavi Kadam:
>> Added support for additional common files in meson build
>> to expand Windows EAL and to support the lcore parsing
>> feature on Windows.
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Signed-off-by: Antara Ganesh Kolar <antara.ganesh.kolar@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>> Reviewed-by: Keith Wiles <keith.wiles@intel.com>
>> ---
>> --- a/lib/librte_eal/windows/eal/meson.build
>> +++ b/lib/librte_eal/windows/eal/meson.build
>> common_sources = files(
>> + '../../common/eal_common_bus.c',
>> + '../../common/eal_common_class.c',
>> + '../../common/eal_common_devargs.c',
>> '../../common/eal_common_errno.c',
>> '../../common/eal_common_launch.c',
>> '../../common/eal_common_lcore.c',
>> - '../../common/eal_common_log.c'
>> + '../../common/eal_common_log.c',
>> + '../../common/eal_common_options.c',
>> + '../../common/eal_common_thread.c',
>> + '../../common/rte_option.c'
> Please add a comma after the last item of the list, so the next patch
> won't need to change this line.
Thanks, will update this in v6.
>
>
>
@@ -8,10 +8,16 @@ env_headers = files(
'include/rte_os.h',
)
common_sources = files(
+ '../../common/eal_common_bus.c',
+ '../../common/eal_common_class.c',
+ '../../common/eal_common_devargs.c',
'../../common/eal_common_errno.c',
'../../common/eal_common_launch.c',
'../../common/eal_common_lcore.c',
- '../../common/eal_common_log.c'
+ '../../common/eal_common_log.c',
+ '../../common/eal_common_options.c',
+ '../../common/eal_common_thread.c',
+ '../../common/rte_option.c'
)
env_sources = files('eal.c',
'eal_debug.c',