Message ID | 20191211182522.8163-1-alialnu@mellanox.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7DAAA04F5; Wed, 11 Dec 2019 19:26:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40E442C6A; Wed, 11 Dec 2019 19:26:02 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80042.outbound.protection.outlook.com [40.107.8.42]) by dpdk.org (Postfix) with ESMTP id D1F161D9E; Wed, 11 Dec 2019 19:26:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Brv+Flg7ihsXn7FyBDZ6rUolBXQi+3Gq7US/yiGZm0GStQymBxn5rnin0P/j74fWkTgv6TNyl8e9MIhTQ9o0/cLzUvq4Ax+1YQ6HReqVmDwLuJXkwh96GswlFOHyUGmILLeBfDsGQ/cANBmzb/o4RegIK8/FM0dQksgL+oRV0Wtd2Z95RG5DK8KHa3gQY966Vrvwwo0ULfmvFE6Pc2AAFKa7+NOK8OAm6Ud5utmimeRR+OvgwVOxrIZKtbyBscHoDDdh91CyCq35a8qvz1ftr3sR6/lpkIhd41l0SjhfoCRXhFzUTAMkr7F4vs8k1VnwQ/oQ/r6nBoAqgU3KmucSOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SQFGQqA2aCB1eatPZ6wqTHtA8SOa/p7FlUbzPk7Zi/4=; b=NeKyQAro7O90SHB+9J714gUYIE8PX4zT8YXu8+9FD8tcWVR1Lq8hj1kP6mfaEdfUT8kR/BjDUMGcCSKCQYxgR8Iw+iXgi6fKRiOgh/a6L2f9+P+/uTvp1b8iSFaLYWuxPNinFFzkR2esTaPWAkH5kXS6nehjlpg+8FnnZLeXXgTrtt4hN9J70888qts3Rs5ErCTZ4g4EKYr8aQFJX1KsCUHT2MP9sii+PxiaLXG1tRhmIPFPUmYF0eIaIgxsDbU2a/XT6eRRdD7OER5WEq3VmJIGEsw8BKSgFoOmOyc9bYCmRLmZdlLJgp3JFtd7o/lhnUlrmjhuSthxLo3Lk19dQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SQFGQqA2aCB1eatPZ6wqTHtA8SOa/p7FlUbzPk7Zi/4=; b=DorKu8zhvbSrh+MKIkGXOjv0KuCC52a3QIldBo8sLmeBpdwA/Q8g5EPp3jnpqAhd7AOfPfp4J5qOOJPCRANwkR0Gg6b67PBPqzknHozb47KacAQ22Wbl2rra2qo20W84QxKshQnTnmCVml0xfKsXTbycSAIRZM2XEiiy4+gOyUY= Received: from AM0PR05MB4401.eurprd05.prod.outlook.com (52.134.124.20) by AM0PR05MB4932.eurprd05.prod.outlook.com (20.176.215.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.13; Wed, 11 Dec 2019 18:25:59 +0000 Received: from AM0PR05MB4401.eurprd05.prod.outlook.com ([fe80::d5e8:d078:e580:ffd7]) by AM0PR05MB4401.eurprd05.prod.outlook.com ([fe80::d5e8:d078:e580:ffd7%6]) with mapi id 15.20.2538.012; Wed, 11 Dec 2019 18:25:59 +0000 From: Ali Alnubani <alialnu@mellanox.com> To: "dev@dpdk.org" <dev@dpdk.org> CC: "vattunuru@marvell.com" <vattunuru@marvell.com>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH] eal/linux: fix build when VFIO is disabled Thread-Index: AQHVsFBv3LAtwgGqQESubXxWZ+bcvQ== Date: Wed, 11 Dec 2019 18:25:59 +0000 Message-ID: <20191211182522.8163-1-alialnu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.11.0 x-clientproxiedby: PR0P264CA0036.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::24) To AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=alialnu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [95.142.172.178] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e87289c9-8cbc-497e-e6b5-08d77e679212 x-ms-traffictypediagnostic: AM0PR05MB4932: x-microsoft-antispam-prvs: <AM0PR05MB4932EE844CDCDEEB98560D74D75A0@AM0PR05MB4932.eurprd05.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:1303; x-forefront-prvs: 024847EE92 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(199004)(189003)(478600001)(36756003)(8936002)(186003)(81166006)(6512007)(8676002)(2906002)(4326008)(6486002)(71200400001)(86362001)(316002)(4744005)(6506007)(5660300002)(2616005)(1076003)(66946007)(66556008)(66476007)(52116002)(6916009)(54906003)(66446008)(81156014)(26005)(64756008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4932; H:AM0PR05MB4401.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: geeindc9QU0DJeV5+jISUTptWLFxEu4xunNbBm7qJsuZMyFf0O4+ddV9crXdbHOwyjA4Qp7WBdKid04YEvIyf6ocquBjwDEDDM2OD/YeLp1YEtwoa947DmlLJKzdt/VYFALLaBGj1LBxhJsy9C/AysyWvX41g+v9eXEJcM6IPnd72ZC32TwdEE7mdtAIaW7b1bdDX7Y0E5tA+WITQ9iXlkplVFEuiF3Z3AqcGsFU5FTeszBSSW+4/RljQ36YG5p5GkPXjVOKufe8sjF8jxc4A6WoNK9d+hM3p2b2tdDuWcNoOPUlUtFd05jYRYN9jy9uakSMm59btDmPHuGRC0jP/jrXA2yQ2H70yUmT/CCdQSpaA2a1tpxxfftY1To1JOAQE+2L1yKQYmuWQy7+o4BNCcTaSgz4QMI9s+iCGU0pMMhUa2UKjX5whWSQ913sVcPg x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <D27E8E7DC7DD354883CF029804414228@eurprd05.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e87289c9-8cbc-497e-e6b5-08d77e679212 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2019 18:25:59.6526 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mtC53npdRYmVYVcVDyPeCXUIv8UH1qf22nSf/hE717FtqOxDgPpB+L7PQJjjw3bQaLIWZzjaEkswywXTBinmiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4932 Subject: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
eal/linux: fix build when VFIO is disabled
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-testing | success | Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/travis-robot | success | Travis build: passed |
ci/Intel-compilation | fail | apply issues |
Commit Message
Ali Alnubani
Dec. 11, 2019, 6:25 p.m. UTC
The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO
is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are
therefore undefined, causing the build failure:
lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’:
lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is
not defined, evaluates to 0 [-Werror=undef]
Fixes: a0dede62a537 ("eal/linux: remove KNI restriction on IOVA")
Cc: vattunuru@marvell.com
Cc: stable@dpdk.org
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
lib/librte_eal/linux/eal/eal.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Wed, Dec 11, 2019 at 7:26 PM Ali Alnubani <alialnu@mellanox.com> wrote: > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO > is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are > therefore undefined, causing the build failure: > > lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’: > lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is > not defined, evaluates to 0 [-Werror=undef] The patch itself is ok. But, out of curiosity, why would you disable vfio support?
> -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Monday, December 16, 2019 7:22 PM > To: Ali Alnubani <alialnu@mellanox.com> > Cc: dev@dpdk.org; vattunuru@marvell.com; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled > > On Wed, Dec 11, 2019 at 7:26 PM Ali Alnubani <alialnu@mellanox.com> > wrote: > > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO is > > explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are > > therefore undefined, causing the build failure: > > > > lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’: > > lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is > > not defined, evaluates to 0 [-Werror=undef] > > The patch itself is ok. > But, out of curiosity, why would you disable vfio support? No reason. I noticed the build error by accident actually. > > > -- > David Marchand Regards, Ali
11/12/2019 19:25, Ali Alnubani: > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO > is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are > therefore undefined, causing the build failure: > > lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’: > lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is > not defined, evaluates to 0 [-Werror=undef] > > Fixes: a0dede62a537 ("eal/linux: remove KNI restriction on IOVA") > Cc: vattunuru@marvell.com > Cc: stable@dpdk.org > > Signed-off-by: Ali Alnubani <alialnu@mellanox.com> Applied, thanks
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c index c4233ec3c..9530ee55f 100644 --- a/lib/librte_eal/linux/eal/eal.c +++ b/lib/librte_eal/linux/eal/eal.c @@ -25,6 +25,7 @@ #if defined(RTE_ARCH_X86) #include <sys/io.h> #endif +#include <linux/version.h> #include <rte_compat.h> #include <rte_common.h>