test/compress: replace test vector

  This patch replaces existing test vector with a new
one containing C code to fix license issue.

Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
 app/test/test_compressdev_test_buffer.h | 228 ++++++++++++++----------
 1 file changed, 132 insertions(+), 96 deletions(-)
  

> -----Original Message-----
> From: Trybula, ArturX <arturx.trybula@intel.com>
> Sent: Tuesday, January 14, 2020 11:57 AM
> To: dev@dpdk.org; stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; shallyv@marvell.com;
> Dybkowski, AdamX <adamx.dybkowski@intel.com>; Danilewicz, MarcinX
> <marcinx.danilewicz@intel.com>; Trybula, ArturX <arturx.trybula@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] test/compress: replace test vector
> 
> This patch replaces existing test vector with a new
> one containing C code to fix license issue.
> 
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  

> >
> > This patch replaces existing test vector with a new
> > one containing C code to fix license issue.
> >
> > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Applied to dpdk-next-crypto

Thanks.
  

15/01/2020 16:54, Akhil Goyal:
> > >
> > > This patch replaces existing test vector with a new
> > > one containing C code to fix license issue.
> > >
> > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> Applied to dpdk-next-crypto

This is a terrible idea.
Adding C code in a C project as text, and worst, its own code,
will make grep matching on fake text.

Why do you need so much text to compress?
Why not just opening our own code files as text?

Why stable@dpdk.org is Cc'ed in this email?
What is the license issue?
Should it be backported? If yes, the stable tag is missing.

I drop this patch from -rc1.
  

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Friday, January 17, 2020 9:52 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Trybula, ArturX
> <arturx.trybula@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX
> <marcinx.danilewicz@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-stable] [PATCH] test/compress: replace test vector
> 
> 15/01/2020 16:54, Akhil Goyal:
> > > >
> > > > This patch replaces existing test vector with a new one containing
> > > > C code to fix license issue.
> > > >
> > > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > Applied to dpdk-next-crypto
> 
> This is a terrible idea.
> Adding C code in a C project as text, and worst, its own code, will make
> grep matching on fake text.

Hi,

I don't think this is a valid criticism. The patch replace code in Pascal with some code in C as a compression test. The grep part isn't really relevant, it should be clear to anyone who finds a match.

If you have a strong objection we will replace it with some more public domain text.

> Why do you need so much text to compress?
> Why not just opening our own code files as text?

That probably isn't worth the effort.

> Why stable@dpdk.org is Cc'ed in this email?

Ok. We'll do that.


> What is the license issue?

The issue is that the Pascal code from the Calgary Corpus (a standard body of compression test input) doesn't have a license or explicitly say that it is in the public domain so it isn't clear if we can relicense  it as BSD-3. We are being overly cautious here but we didn't want to run into any potential license issues. 
 
John
  

20/01/2020 14:54, Mcnamara, John:
> From: stable <stable-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > 15/01/2020 16:54, Akhil Goyal:
> > > > >
> > > > > This patch replaces existing test vector with a new one containing
> > > > > C code to fix license issue.
> > > > >
> > > > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > > > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > > Applied to dpdk-next-crypto
> > 
> > This is a terrible idea.
> > Adding C code in a C project as text, and worst, its own code, will make
> > grep matching on fake text.
> 
> Hi,
> 
> I don't think this is a valid criticism. The patch replace code in Pascal with some code in C as a compression test. The grep part isn't really relevant, it should be clear to anyone who finds a match.
> 
> If you have a strong objection we will replace it with some more public domain text.

Yes please, it will be less confusing.

> > Why do you need so much text to compress?

Please why do we need some code at all?

> > Why not just opening our own code files as text?
> 
> That probably isn't worth the effort.
> 
> > Why stable@dpdk.org is Cc'ed in this email?
> 
> Ok. We'll do that.

I say Why? You say Ok :-)

> > What is the license issue?
> 
> The issue is that the Pascal code from the Calgary Corpus (a standard body of compression test input) doesn't have a license or explicitly say that it is in the public domain so it isn't clear if we can relicense  it as BSD-3. We are being overly cautious here but we didn't want to run into any potential license issues.

OK
Please explain in the commit log.
  

Hi Thomas

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, January 20, 2020 2:33 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Trybula, ArturX <arturx.trybula@intel.com>; Mcnamara,
> John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX <marcinx.danilewicz@intel.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-stable] [PATCH] test/compress: replace test vector
> 
> 20/01/2020 14:54, Mcnamara, John:
> > From: stable <stable-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > > 15/01/2020 16:54, Akhil Goyal:
> > > > > >
> > > > > > This patch replaces existing test vector with a new one containing
> > > > > > C code to fix license issue.
> > > > > >
> > > > > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > > > > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > > > Applied to dpdk-next-crypto
> > >
> > > This is a terrible idea.
> > > Adding C code in a C project as text, and worst, its own code, will make
> > > grep matching on fake text.
> >
> > Hi,
> >
> > I don't think this is a valid criticism. The patch replace code in Pascal with some code in C as a
> compression test. The grep part isn't really relevant, it should be clear to anyone who finds a match.
> >
> > If you have a strong objection we will replace it with some more public domain text.
> 
> Yes please, it will be less confusing.
> 
> > > Why do you need so much text to compress?
> 
> Please why do we need some code at all?
[Fiona] compression engines are usually tested with different types of data to represent various use-cases.
So include for example ASCII text, binary chunks, excel files, etc. Compression of code is a typical compression workload - and
as code has lots of patterns may be quite compressible, at different ratios to standard English language text.
That said, it's not so important in DPDK to cover all data types as our focus is not on verifying the compression
engines, but just the path through the API and PMD to them. So we can replace this text if it's less confusing.

> 
> > > Why not just opening our own code files as text?
> >
> > That probably isn't worth the effort.
> >
> > > Why stable@dpdk.org is Cc'ed in this email?
> >
> > Ok. We'll do that.
> 
> I say Why? You say Ok :-)
[Fiona] Simple mistake - sorry 😊
> 
> > > What is the license issue?
> >
> > The issue is that the Pascal code from the Calgary Corpus (a standard body of compression test
> input) doesn't have a license or explicitly say that it is in the public domain so it isn't clear if we can
> relicense  it as BSD-3. We are being overly cautious here but we didn't want to run into any potential
> license issues.
> 
> OK
> Please explain in the commit log.
> 
[Fiona] ok
  

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, January 20, 2020 2:33 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Trybula, ArturX
> <arturx.trybula@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX
> <marcinx.danilewicz@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-stable] [PATCH] test/compress: replace test vector
> 
> 20/01/2020 14:54, Mcnamara, John:
> > From: stable <stable-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > > 15/01/2020 16:54, Akhil Goyal:
> > > > > >
> > > > > > This patch replaces existing test vector with a new one
> > > > > > containing C code to fix license issue.
> > > > > >
> > > > > > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > > > > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > > > Applied to dpdk-next-crypto
> > >
> > > This is a terrible idea.
> > > Adding C code in a C project as text, and worst, its own code, will
> > > make grep matching on fake text.
> >
> > Hi,
> >
> > I don't think this is a valid criticism. The patch replace code in
> Pascal with some code in C as a compression test. The grep part isn't
> really relevant, it should be clear to anyone who finds a match.
> >
> > If you have a strong objection we will replace it with some more public
> domain text.
> 
> Yes please, it will be less confusing.
> 
> > > Why do you need so much text to compress?
> 
> Please why do we need some code at all?
> 
> > > Why not just opening our own code files as text?
> >
> > That probably isn't worth the effort.
> >
> > > Why stable@dpdk.org is Cc'ed in this email?
> >
> > Ok. We'll do that.
> 
> I say Why? You say Ok :-)

I mis-read it. I thought you said it wasn't CCed.

John
  

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Mcnamara, John
> Sent: Monday, January 20, 2020 6:00 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Trahe, Fiona
> <fiona.trahe@intel.com>; Trybula, ArturX <arturx.trybula@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX
> <marcinx.danilewicz@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test
> vector


This patch also needs a BSD SPDX header. Please add that.

John