vhost: fix compile error

Message ID 20191028103443.42346-1-jin.yu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers
Series vhost: fix compile error |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compilation success Compile Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation fail Compilation issues

Commit Message

Jin Yu Oct. 28, 2019, 10:34 a.m. UTC
  Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.

Bugzilla ID: 356
Cc: stable@dpdk.org

Signed-off-by: Jin Yu <jin.yu@intel.com>
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Tiwei Bie Oct. 29, 2019, 1:35 p.m. UTC | #1
On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
> 
> Bugzilla ID: 356
> Cc: stable@dpdk.org

Fixes: 939066d96563 ("vhost/crypto: add public function implementation")

> 
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index 41c463d92..a30accb29 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
>  DEPDIRS-librte_rawdev := librte_eal librte_ethdev
>  DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
>  DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> -			librte_net
> +			librte_net librte_hash

Do we also depend on cryptodev (rte_cryptodev.h)?


>  DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
>  DEPDIRS-librte_hash := librte_eal librte_ring
>  DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> -- 
> 2.17.2
>
  
Jin Yu Oct. 30, 2019, 1:41 a.m. UTC | #2
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Tuesday, October 29, 2019 9:36 PM
> To: Yu, Jin <jin.yu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] vhost: fix compile error
> 
> On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need
> > the librte_hash to be compiled before vhost.
> > Add the DEPDIRs to make sure this.
> >
> > Bugzilla ID: 356
> > Cc: stable@dpdk.org
> 
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Thanks.
> 
> >
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> >  lib/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile index 41c463d92..a30accb29
> > 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) +=
> librte_rawdev
> > DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> >  DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost  DEPDIRS-librte_vhost
> > := librte_eal librte_mempool librte_mbuf librte_ethdev \
> > -			librte_net
> > +			librte_net librte_hash
> 
> Do we also depend on cryptodev (rte_cryptodev.h)?
Yes, but luckily we didn't meet this error, it seems librte_cryptodev  always compile before vhost. Ok, I will add it too.
Thanks.
> 
> >  DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash  DEPDIRS-librte_hash :=
> > librte_eal librte_ring
> >  DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> > --
> > 2.17.2
> >
  

Patch

diff --git a/lib/Makefile b/lib/Makefile
index 41c463d92..a30accb29 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -46,7 +46,7 @@  DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
 DEPDIRS-librte_rawdev := librte_eal librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
 DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
-			librte_net
+			librte_net librte_hash
 DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
 DEPDIRS-librte_hash := librte_eal librte_ring
 DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd