net/mlx4: remove dependency on libmnl in meson
Checks
Commit Message
There is no dependency on this library for mlx4.
Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/mlx4/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
02/10/2019 16:24, David Marchand:
> There is no dependency on this library for mlx4.
>
> Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> Cc: stable@dpdk.org
It seems this dependency was added by mistake.
It was used in mlx5 for TC Flower, and has been dropped recently.
On Wed, Oct 2, 2019 at 5:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 02/10/2019 16:24, David Marchand:
> > There is no dependency on this library for mlx4.
> >
> > Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> > Cc: stable@dpdk.org
>
> It seems this dependency was added by mistake.
> It was used in mlx5 for TC Flower, and has been dropped recently.
Yes, most likely a copy/paste from mlx5 at the time of 1dd7c7e38c19.
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
> Sent: Wednesday, October 2, 2019 5:24 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in
> meson
>
> There is no dependency on this library for mlx4.
>
> Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Raslan Darawsheh <rasland@mellanox.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
@@ -21,7 +21,7 @@ if pmd_dlopen
]
endif
-libnames = [ 'mnl', 'mlx4', 'ibverbs' ]
+libnames = [ 'mlx4', 'ibverbs' ]
libs = []
foreach libname:libnames
lib = dependency('lib' + libname, required:false)