test/event_crypto: change the SEC cipher algo
Checks
Commit Message
The existing code usages NULL as the cipher algo
for testing crypto event adapter.
DPAA1/DPAA2 do not support NULL algo. Hence changing
is to the most common algo AES-CBC, which is supported
by all crypto drivers implementing event crypto adapter.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
app/test/test_event_crypto_adapter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Acked-by: abhinandan.gujjar@intel.com
> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Friday, September 27, 2019 1:46 PM
> To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] test/event_crypto: change the SEC cipher algo
>
> The existing code usages NULL as the cipher algo for testing crypto event
> adapter.
> DPAA1/DPAA2 do not support NULL algo. Hence changing is to the most
> common algo AES-CBC, which is supported by all crypto drivers implementing
> event crypto adapter.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> app/test/test_event_crypto_adapter.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index cff7ad61f..83f3214ca 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -183,7 +183,7 @@ test_op_forward_mode(uint8_t session_less)
> cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> cipher_xform.next = NULL;
>
> - cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> + cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
>
> op = rte_crypto_op_alloc(params.op_mpool,
> @@ -373,7 +373,7 @@ test_op_new_mode(uint8_t session_less)
> cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> cipher_xform.next = NULL;
>
> - cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> + cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
>
> op = rte_crypto_op_alloc(params.op_mpool,
> --
> 2.17.1
On Fri, Sep 27, 2019 at 3:41 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com
Changed to Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and Applied to dpdk-next-eventdev/master. Thanks.
>
>
> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Friday, September 27, 2019 1:46 PM
> > To: dev@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Subject: [PATCH] test/event_crypto: change the SEC cipher algo
> >
> > The existing code usages NULL as the cipher algo for testing crypto event
> > adapter.
> > DPAA1/DPAA2 do not support NULL algo. Hence changing is to the most
> > common algo AES-CBC, which is supported by all crypto drivers implementing
> > event crypto adapter.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> > app/test/test_event_crypto_adapter.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index cff7ad61f..83f3214ca 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -183,7 +183,7 @@ test_op_forward_mode(uint8_t session_less)
> > cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> > cipher_xform.next = NULL;
> >
> > - cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > + cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> > op = rte_crypto_op_alloc(params.op_mpool,
> > @@ -373,7 +373,7 @@ test_op_new_mode(uint8_t session_less)
> > cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> > cipher_xform.next = NULL;
> >
> > - cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > + cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> > op = rte_crypto_op_alloc(params.op_mpool,
> > --
> > 2.17.1
>
@@ -183,7 +183,7 @@ test_op_forward_mode(uint8_t session_less)
cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
cipher_xform.next = NULL;
- cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
+ cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
op = rte_crypto_op_alloc(params.op_mpool,
@@ -373,7 +373,7 @@ test_op_new_mode(uint8_t session_less)
cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
cipher_xform.next = NULL;
- cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
+ cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
op = rte_crypto_op_alloc(params.op_mpool,