diff mbox

[dpdk-dev] i40e:fix an issue in i40e_dev_info_get

Message ID 1432014939-29800-1-git-send-email-jijiang.liu@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Jijiang Liu May 19, 2015, 5:55 a.m. UTC 
  To get device VMDQ info when only i40e VMDQ feature is enabled.

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>

---
 lib/librte_pmd_i40e/i40e_ethdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Zhang, Helin May 21, 2015, 1:15 a.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Tuesday, May 19, 2015 1:56 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e:fix an issue in i40e_dev_info_get
> 
> To get device VMDQ info when only i40e VMDQ feature is enabled.
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

> 
> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 96700e4..1faae83 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1565,7 +1565,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
>  				ETH_TXQ_FLAGS_NOOFFLOADS,
>  	};
> 
> -	if (pf->flags | I40E_FLAG_VMDQ) {
> +	if (pf->flags & I40E_FLAG_VMDQ) {
>  		dev_info->max_vmdq_pools = pf->max_nb_vmdq_vsi;
>  		dev_info->vmdq_queue_base = dev_info->max_rx_queues;
>  		dev_info->vmdq_queue_num = pf->vmdq_nb_qps *
> --
> 1.7.7.6
Chen, Jing D May 21, 2015, 1:50 a.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Tuesday, May 19, 2015 1:56 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e:fix an issue in i40e_dev_info_get
> 
> To get device VMDQ info when only i40e VMDQ feature is enabled.
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> 
> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 96700e4..1faae83 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1565,7 +1565,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>  				ETH_TXQ_FLAGS_NOOFFLOADS,
>  	};
> 
> -	if (pf->flags | I40E_FLAG_VMDQ) {
> +	if (pf->flags & I40E_FLAG_VMDQ) {
>  		dev_info->max_vmdq_pools = pf->max_nb_vmdq_vsi;
>  		dev_info->vmdq_queue_base = dev_info->max_rx_queues;
>  		dev_info->vmdq_queue_num = pf->vmdq_nb_qps *
> --
> 1.7.7.6

Acked-by: Jing Chen <jing.d.chen@intel.com>
Thomas Monjalon May 29, 2015, 6:10 p.m. UTC | #3 
> > To get device VMDQ info when only i40e VMDQ feature is enabled.
> > 
> > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 96700e4..1faae83 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1565,7 +1565,7 @@  i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 				ETH_TXQ_FLAGS_NOOFFLOADS,
 	};
 
-	if (pf->flags | I40E_FLAG_VMDQ) {
+	if (pf->flags & I40E_FLAG_VMDQ) {
 		dev_info->max_vmdq_pools = pf->max_nb_vmdq_vsi;
 		dev_info->vmdq_queue_base = dev_info->max_rx_queues;
 		dev_info->vmdq_queue_num = pf->vmdq_nb_qps *