Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99949/?format=api
{ "id": 99949, "url": "https://patches.dpdk.org/api/patches/99949/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210928194714.365563-2-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210928194714.365563-2-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210928194714.365563-2-dmitry.kozliuk@gmail.com", "date": "2021-09-28T19:47:13", "name": "[v2,1/2] cmdline: make struct cmdline opaque", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "afa6b34def882f8f63ab348b3cfd605069560d12", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210928194714.365563-2-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 19241, "url": "https://patches.dpdk.org/api/series/19241/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19241", "date": "2021-09-28T19:47:12", "name": "cmdline: reduce ABI", "version": 2, "mbox": "https://patches.dpdk.org/series/19241/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99949/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99949/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 606B7A0C43;\n\tTue, 28 Sep 2021 21:47:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0C419410EF;\n\tTue, 28 Sep 2021 21:47:42 +0200 (CEST)", "from mail-lf1-f45.google.com (mail-lf1-f45.google.com\n [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id E871840E3C\n for <dev@dpdk.org>; Tue, 28 Sep 2021 21:47:37 +0200 (CEST)", "by mail-lf1-f45.google.com with SMTP id y26so682799lfa.11\n for <dev@dpdk.org>; Tue, 28 Sep 2021 12:47:37 -0700 (PDT)", "from sovereign.. (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id 8sm1871ljf.39.2021.09.28.12.47.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Sep 2021 12:47:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=u0zBhMPg2UZxqNoTpQSZS/GYKyQB7o4+MX6FZQGLcQU=;\n b=pF+5ChVq1jLhPuyCr3N3uN4Jogx8EfJ5sCf12WHFUsgdZzpijBBnTNPjlg6shgR7BI\n qg5yYsQkjFhue74NWOLzhZ2KZu3g/dt26ihyZ1ABprYMZCFn4qEvO0QrMjpQ2ItsPMJl\n f6oL96aP7Lc5aKhVo1u1k6AXdkiI09IGNC4kUURWViMEY+Ijk5eaiQVBc01zEaGq3puh\n cFgpw4QPjMk1ocahaxmWZsjgoU6l2MbmCCGdKD6NgfV+pusvCh+B0hvHTtqYE/xHBEX7\n /znkpuicinPhBXqPqS7/arS856gKHGqT5AjYpsfcCo+DpWLfgU/YmFnpf8osV/FyLCYf\n dFOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=u0zBhMPg2UZxqNoTpQSZS/GYKyQB7o4+MX6FZQGLcQU=;\n b=3onMK0s5hEl5hdPGUIM7d3cTqRX47sG3OpsSC+lpwVOKtIAxn3/tqpz74VE9BmjDd2\n GqyrYvRRZCuHzpd/VW+YwSpYKWF3tMjPS8syLZDC1ZIbmIPA/vLzyq99l+l/qBJI3LRe\n B6wDw+u3dxb7JwhR4Jqmf+HQXxe0VwYd2LmNQbafktq+U3/8HcZ8oOGJbHhfb3s/FA82\n J45hynZqFoSXJacPiNI+tzFNMESxOzQYTMjD8bCXBuIfreyxvtRSHZXKE9SsfXvJTgZp\n M6EzzzK3hkAxPEg2I8V1k5d4ArtrBpZ9hiNhrERPhqELZ+him3+HIUEdU2S2h5MoQTfE\n FGJg==", "X-Gm-Message-State": "AOAM530HwIQZauNtU6KFaceMvLyQL3VgHb36YyyItBHZgadz64gwDmTD\n MMULE0R3UE9n/pokgAZzxQd8jqHCH0s=", "X-Google-Smtp-Source": "\n ABdhPJynTsg6XeE35dcHQ4eMMyDWu8SHT0XnmPP3VRokZVr+VVTdW1fViFDSZgIsOyyg5xtiktHd/A==", "X-Received": "by 2002:a05:6512:10c3:: with SMTP id\n k3mr5714131lfg.72.1632858457261;\n Tue, 28 Sep 2021 12:47:37 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "David Marchand <david.marchand@redhat.com>,\n Olivier Matz <olivier.matz@6wind.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "Date": "Tue, 28 Sep 2021 22:47:13 +0300", "Message-Id": "<20210928194714.365563-2-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20210928194714.365563-1-dmitry.kozliuk@gmail.com>", "References": "<20210910231639.789066-2-dmitry.kozliuk@gmail.com>\n <20210928194714.365563-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] cmdline: make struct cmdline opaque", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove the definition of `struct cmdline` from public header.\nDeprecation notice:\nhttps://mails.dpdk.org/archives/dev/2020-September/183310.html\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\nAcked-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Olivier Matz <olivier.matz@6wind.com>\n---\n doc/guides/rel_notes/deprecation.rst | 4 ----\n doc/guides/rel_notes/release_21_11.rst | 2 ++\n lib/cmdline/cmdline.h | 19 -------------------\n lib/cmdline/cmdline_private.h | 8 +++++++-\n 4 files changed, 9 insertions(+), 24 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 76a4abfd6b..a404276fa2 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -275,10 +275,6 @@ Deprecation Notices\n * metrics: The function ``rte_metrics_init`` will have a non-void return\n in order to notify errors instead of calling ``rte_exit``.\n \n-* cmdline: ``cmdline`` structure will be made opaque to hide platform-specific\n- content. On Linux and FreeBSD, supported prior to DPDK 20.11,\n- original structure will be kept until DPDK 21.11.\n-\n * security: The functions ``rte_security_set_pkt_metadata`` and\n ``rte_security_get_userdata`` will be made inline functions and additional\n flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.\ndiff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst\nindex b55900936d..18377e5813 100644\n--- a/doc/guides/rel_notes/release_21_11.rst\n+++ b/doc/guides/rel_notes/release_21_11.rst\n@@ -101,6 +101,8 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* cmdline: Made ``cmdline`` structure definition hidden on Linux and FreeBSD.\n+\n \n ABI Changes\n -----------\ndiff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h\nindex c29762ddae..96674dfda2 100644\n--- a/lib/cmdline/cmdline.h\n+++ b/lib/cmdline/cmdline.h\n@@ -7,10 +7,6 @@\n #ifndef _CMDLINE_H_\n #define _CMDLINE_H_\n \n-#ifndef RTE_EXEC_ENV_WINDOWS\n-#include <termios.h>\n-#endif\n-\n #include <rte_common.h>\n #include <rte_compat.h>\n \n@@ -27,23 +23,8 @@\n extern \"C\" {\n #endif\n \n-#ifndef RTE_EXEC_ENV_WINDOWS\n-\n-struct cmdline {\n-\tint s_in;\n-\tint s_out;\n-\tcmdline_parse_ctx_t *ctx;\n-\tstruct rdline rdl;\n-\tchar prompt[RDLINE_PROMPT_SIZE];\n-\tstruct termios oldterm;\n-};\n-\n-#else\n-\n struct cmdline;\n \n-#endif /* RTE_EXEC_ENV_WINDOWS */\n-\n struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out);\n void cmdline_set_prompt(struct cmdline *cl, const char *prompt);\n void cmdline_free(struct cmdline *cl);\ndiff --git a/lib/cmdline/cmdline_private.h b/lib/cmdline/cmdline_private.h\nindex a87c45275c..2e93674c66 100644\n--- a/lib/cmdline/cmdline_private.h\n+++ b/lib/cmdline/cmdline_private.h\n@@ -11,6 +11,8 @@\n #include <rte_os_shim.h>\n #ifdef RTE_EXEC_ENV_WINDOWS\n #include <rte_windows.h>\n+#else\n+#include <termios.h>\n #endif\n \n #include <cmdline.h>\n@@ -22,6 +24,7 @@ struct terminal {\n \tint is_console_input;\n \tint is_console_output;\n };\n+#endif\n \n struct cmdline {\n \tint s_in;\n@@ -29,11 +32,14 @@ struct cmdline {\n \tcmdline_parse_ctx_t *ctx;\n \tstruct rdline rdl;\n \tchar prompt[RDLINE_PROMPT_SIZE];\n+#ifdef RTE_EXEC_ENV_WINDOWS\n \tstruct terminal oldterm;\n \tchar repeated_char;\n \tWORD repeat_count;\n-};\n+#else\n+\tstruct termios oldterm;\n #endif\n+};\n \n /* Disable buffering and echoing, save previous settings to oldterm. */\n void terminal_adjust(struct cmdline *cl);\n", "prefixes": [ "v2", "1/2" ] }