Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99837/?format=api
{ "id": 99837, "url": "https://patches.dpdk.org/api/patches/99837/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210927224834.90837-1-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210927224834.90837-1-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210927224834.90837-1-ajit.khaparde@broadcom.com", "date": "2021-09-27T22:48:35", "name": "net/bnxt: fix tunnel port accounting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7a7c318ba5bf3c6316701f9bed5f72ce2fee1a1e", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210927224834.90837-1-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 19201, "url": "https://patches.dpdk.org/api/series/19201/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19201", "date": "2021-09-27T22:48:35", "name": "net/bnxt: fix tunnel port accounting", "version": 1, "mbox": "https://patches.dpdk.org/series/19201/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99837/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/99837/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6D393A0C46;\n\tTue, 28 Sep 2021 00:48:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CB5CF410E4;\n\tTue, 28 Sep 2021 00:48:56 +0200 (CEST)", "from mail-pg1-f180.google.com (mail-pg1-f180.google.com\n [209.85.215.180])\n by mails.dpdk.org (Postfix) with ESMTP id 0F4F940DF6\n for <dev@dpdk.org>; Tue, 28 Sep 2021 00:48:56 +0200 (CEST)", "by mail-pg1-f180.google.com with SMTP id n18so19153587pgm.12\n for <dev@dpdk.org>; Mon, 27 Sep 2021 15:48:55 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id m11sm7397035pga.27.2021.09.27.15.48.51\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Mon, 27 Sep 2021 15:48:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:mime-version;\n bh=guTWYmOt0wgAZzer0Rvx+Xf6v/U1UEPu3nE6kGGdtxw=;\n b=S56zp/kDu1T9s+e2zius8GytVfl3nCk9uaT/+Cs1U/KCnh9NiRlVIOhO+ePuPmwnrt\n PLfl4rkOKrbiXw/qd7hafbFMidSpEwtGE9RDM/SleB8sr2ir29Btd7yKcuPL0n4pA1z/\n zm5XMU2W6c0TjKgb/m6+emQ1h/oaD3uWIMeLE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version;\n bh=guTWYmOt0wgAZzer0Rvx+Xf6v/U1UEPu3nE6kGGdtxw=;\n b=bIOM9LH4nltjRyFMY44K0dDUxAagyXiVko1k1uoAeUbpUYcSDwqwPFV18Tx+uslBG7\n VM7mZuUy3iRzmwVimiODU0RgBKou0oesrSgXqKukzigaCz6IMHwoZb6NfbOfFN2bOVDN\n GN0ND/fuFqW1+Jmyfhi3dSNFUC0CfzysoSYaSVewCve3y2slT2wW14ymMhgNmSpM9E1H\n Z4uWGrIGcIldqaCz7Pic8HzGF9BEoiko2jwRFHm/fkdEPwrKVf3DAOaS+XhGDSDs7JwO\n O27GrOx3IYgWjkcKLZbMpaBi5Ctj9OL7kSlYVGAhuI+Bec/fVE/JtIJUeXlBy54GcjOy\n WGGg==", "X-Gm-Message-State": "AOAM530UPM5O0fyhmLqrI+OBxAqk7Cxsb28z4WyunPL46d7IcDzvAHye\n 5BDiP9glPvpR1mN8Bd79q3q51SP34fnJ8JclrTXGdXeDD020j9EeMiSjv+2R1ONtmtbmUJJTEOj\n RP8XjtzexXDCxuLxbZrCbMUG6gBmyJrP2EXKP5OHYJ3ZgcTRQjP+GAimtmlO/me0=", "X-Google-Smtp-Source": "\n ABdhPJwYSER91bMP/+HBYzwA86ZCCu9L0cuEXcMjG0onu38FfB+bF4ylcDHQa0lPv464l/Zbq3d32Q==", "X-Received": "by 2002:a63:cc49:: with SMTP id q9mr1706566pgi.463.1632782934524;\n Mon, 27 Sep 2021 15:48:54 -0700 (PDT)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org,\n\tLance Richardson <lance.richardson@broadcom.com>", "Date": "Mon, 27 Sep 2021 15:48:35 -0700", "Message-Id": "<20210927224834.90837-1-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.30.1 (Apple Git-130)", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000d818d605cd01e687\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH] net/bnxt: fix tunnel port accounting", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix the tunnel port counting logic.\nCurrently we are incrementing the port count without checking\nthe if bnxt_hwrm_tunnel_dst_port_alloc would return success or failure.\nModify the logic to increment it only if the firmware returns success.\n\nFixes: 10d074b2022d (\"net/bnxt: support tunneling\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 857da91c9d..aa7e7fdc85 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -2369,7 +2369,6 @@ bnxt_udp_tunnel_port_add_op(struct rte_eth_dev *eth_dev,\n \t\t}\n \t\ttunnel_type =\n \t\t\tHWRM_TUNNEL_DST_PORT_ALLOC_INPUT_TUNNEL_TYPE_VXLAN;\n-\t\tbp->vxlan_port_cnt++;\n \t\tbreak;\n \tcase RTE_TUNNEL_TYPE_GENEVE:\n \t\tif (bp->geneve_port_cnt) {\n@@ -2384,7 +2383,6 @@ bnxt_udp_tunnel_port_add_op(struct rte_eth_dev *eth_dev,\n \t\t}\n \t\ttunnel_type =\n \t\t\tHWRM_TUNNEL_DST_PORT_ALLOC_INPUT_TUNNEL_TYPE_GENEVE;\n-\t\tbp->geneve_port_cnt++;\n \t\tbreak;\n \tdefault:\n \t\tPMD_DRV_LOG(ERR, \"Tunnel type is not supported\\n\");\n@@ -2392,6 +2390,18 @@ bnxt_udp_tunnel_port_add_op(struct rte_eth_dev *eth_dev,\n \t}\n \trc = bnxt_hwrm_tunnel_dst_port_alloc(bp, udp_tunnel->udp_port,\n \t\t\t\t\t tunnel_type);\n+\n+\tif (rc != 0)\n+\t\treturn rc;\n+\n+\tif (tunnel_type ==\n+\t HWRM_TUNNEL_DST_PORT_ALLOC_INPUT_TUNNEL_TYPE_VXLAN)\n+\t\tbp->vxlan_port_cnt++;\n+\n+\tif (tunnel_type ==\n+\t HWRM_TUNNEL_DST_PORT_ALLOC_INPUT_TUNNEL_TYPE_GENEVE)\n+\t\tbp->geneve_port_cnt++;\n+\n \treturn rc;\n }\n \n", "prefixes": [] }