Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99821/?format=api
{ "id": 99821, "url": "https://patches.dpdk.org/api/patches/99821/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210927134231.11177-5-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210927134231.11177-5-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210927134231.11177-5-srikanth.k@oneconvergence.com", "date": "2021-09-27T13:42:24", "name": "[04/11] bus/vmbus: get device resource values using sysctl", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "221819e723c105f3f60913f18fdf348304eb0ccd", "submitter": { "id": 2368, "url": "https://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210927134231.11177-5-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 19194, "url": "https://patches.dpdk.org/api/series/19194/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19194", "date": "2021-09-27T13:42:20", "name": "add FreeBSD support to VMBUS & NetVSC PMDs", "version": 1, "mbox": "https://patches.dpdk.org/series/19194/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99821/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99821/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E879FA0C46;\n\tMon, 27 Sep 2021 17:00:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CD7BC41196;\n\tMon, 27 Sep 2021 16:58:34 +0200 (CEST)", "from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by mails.dpdk.org (Postfix) with ESMTP id 291C6410DD\n for <dev@dpdk.org>; Mon, 27 Sep 2021 15:43:10 +0200 (CEST)", "by mail-pl1-f178.google.com with SMTP id x8so8982333plv.8\n for <dev@dpdk.org>; Mon, 27 Sep 2021 06:43:10 -0700 (PDT)", "from srikanth-ThinkPad-T450.domain.name ([223.178.22.200])\n by smtp.gmail.com with ESMTPSA id b3sm16960665pfo.23.2021.09.27.06.43.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Sep 2021 06:43:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=lHGfUmAGv9M4RA1w8+Uve1rNW3LVrft/ZlIS+myyUWQ=;\n b=grd8h9MZoHfRoPhHuRfrAjDTDUOohU3eXLoiyvQJW7tjgHmZhyzRdFqLGcJcBUveFR\n gCoSf0gqI7MP+THcfVAP6rYaS63EhsfYJpwgwCFQKBC1t+O7Ohg+B4MkucJCn36eb0UH\n 3cwgMA0etHACqYhjLy+k+CyppOh7ECfQ4JIGI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=lHGfUmAGv9M4RA1w8+Uve1rNW3LVrft/ZlIS+myyUWQ=;\n b=ymulQie2LQSCPnN/4S1QZD2qK/5H+vdbT7H/BS9s2fVyVH2Ju6RWoXGVPCAC/o7Yqy\n Dq/nOUE1PIe/uJZf+Vk9dOOHs8m+yAALKW82EJVnEGw92zitdbdTTH7u+3ZcjVSkUU1b\n hgAELAhpm5hVBaECTNNs9RNC3iO+VYIrLAiNzWGdV9iTdreyJGn2HtRWne38Bo0WxNnF\n l5StZuUj156Zw8l5T/uVHLRgFzQf/AUjApehf2im15GbY/j6RMF/oByr3yiOo8jByhnu\n wferZu+MdQM/AsNwqZOcosLCEAPH1Lu8C5FUQfqTJHYu2OdCdua+VSkhjYfjazfzOyXH\n EniA==", "X-Gm-Message-State": "AOAM532w4aQtlFItCWABDBrufypdqNG+QpVQnH8tTZuUi7UvMk2SjsmM\n VhrSTRH8IZwRNTsKD/2mFqLJ7w==", "X-Google-Smtp-Source": "\n ABdhPJxGsHAaQdPtedkrt+r6aEmWG8zuB+tUl8ptmaTYL5ehm6J/IdC/D3m/NOFk7+wcZTfPYQ8kaQ==", "X-Received": "by 2002:a17:90b:4b51:: with SMTP id\n mi17mr22335pjb.120.1632750189293;\n Mon, 27 Sep 2021 06:43:09 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Stephen Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Date": "Mon, 27 Sep 2021 19:12:24 +0530", "Message-Id": "<20210927134231.11177-5-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210927134231.11177-1-srikanth.k@oneconvergence.com>", "References": "<20210927134231.11177-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 27 Sep 2021 16:58:07 +0200", "Subject": "[dpdk-dev] [PATCH 04/11] bus/vmbus: get device resource values\n using sysctl", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The UIO device's relid, monitor id, etc values are retrieved using\nfollowing sysctl variables:\n$ sysctl dev.hv_uio.0\ndev.hv_uio.0.send_buf.gpadl: 925241\ndev.hv_uio.0.send_buf.size: 16777216\ndev.hv_uio.0.recv_buf.gpadl: 925240\ndev.hv_uio.0.recv_buf.size: 32505856\ndev.hv_uio.0.monitor_page.size: 4096\ndev.hv_uio.0.int_page.size: 4096\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/bus/vmbus/freebsd/vmbus_uio.c | 98 ++++++++++++++++++++++-----\n 1 file changed, 81 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/bus/vmbus/freebsd/vmbus_uio.c b/drivers/bus/vmbus/freebsd/vmbus_uio.c\nindex b52ca5bf1d..fdd37dac3a 100644\n--- a/drivers/bus/vmbus/freebsd/vmbus_uio.c\n+++ b/drivers/bus/vmbus/freebsd/vmbus_uio.c\n@@ -10,6 +10,8 @@\n #include <inttypes.h>\n #include <sys/stat.h>\n #include <sys/mman.h>\n+#include <sys/types.h>\n+#include <sys/sysctl.h>\n \n #include <rte_log.h>\n #include <rte_bus.h>\n@@ -24,8 +26,18 @@\n /** Pathname of VMBUS devices directory. */\n #define SYSFS_VMBUS_DEVICES \"/sys/bus/vmbus/devices\"\n \n+const char *driver_name = \"hv_uio\";\n static void *vmbus_map_addr;\n \n+/* Check map names with kernel names */\n+static const char *map_names[VMBUS_MAX_RESOURCE] = {\n+\t[HV_TXRX_RING_MAP] = \"txrx_rings\",\n+\t[HV_INT_PAGE_MAP] = \"int_page\",\n+\t[HV_MON_PAGE_MAP] = \"monitor_page\",\n+\t[HV_RECV_BUF_MAP] = \"recv_buf\",\n+\t[HV_SEND_BUF_MAP] = \"send_buf\",\n+};\n+\n /* Control interrupts */\n void vmbus_uio_irq_control(struct rte_vmbus_device *dev, int32_t onoff)\n {\n@@ -72,14 +84,75 @@ vmbus_uio_free_resource(struct rte_vmbus_device *dev,\n \t}\n }\n \n+static int\n+sysctl_get_vmbus_device_info(struct rte_vmbus_device *dev)\n+{\n+\tchar sysctlBuffer[PATH_MAX];\n+\tchar sysctlVar[PATH_MAX];\n+\tsize_t len = PATH_MAX, sysctl_len;\n+\tunsigned long tmp;\n+\tint i;\n+\n+\tsnprintf(sysctlBuffer, len, \"dev.%s.%d\", driver_name, dev->uio_num);\n+\n+\tsysctl_len = sizeof(unsigned long);\n+\t/* get relid */\n+\tsnprintf(sysctlVar, len, \"%s.channel.ch_id\", sysctlBuffer);\n+\tif (sysctlbyname(sysctlVar, &tmp, &sysctl_len, NULL, 0) < 0) {\n+\t\tVMBUS_LOG(ERR, \"could not read %s\", sysctlVar);\n+\t\tgoto error;\n+\t}\n+\tdev->relid = tmp;\n+\n+\t/* get monitor id */\n+\tsnprintf(sysctlVar, len, \"%s.channel.%u.monitor_id\", sysctlBuffer,\n+\t\t dev->relid);\n+\tif (sysctlbyname(sysctlVar, &tmp, &sysctl_len, NULL, 0) < 0) {\n+\t\tVMBUS_LOG(ERR, \"could not read %s\", sysctlVar);\n+\t\tgoto error;\n+\t}\n+\tdev->monitor_id = tmp;\n+\n+\t/* Extract resource value */\n+\tfor (i = 0; i < VMBUS_MAX_RESOURCE; i++) {\n+\t\tstruct rte_mem_resource *res = &dev->resource[i];\n+\t\tunsigned long size, gpad = 0;\n+\t\tsize_t sizelen = sizeof(len);\n+\n+\t\tsnprintf(sysctlVar, sizeof(sysctlVar), \"%s.%s.size\",\n+\t\t\t sysctlBuffer, map_names[i]);\n+\t\tif (sysctlbyname(sysctlVar, &size, &sizelen, NULL, 0) < 0) {\n+\t\t\tVMBUS_LOG(ERR,\n+\t\t\t\t\"could not read %s\", sysctlVar);\n+\t\t\tgoto error;\n+\t\t}\n+\t\tres->len = size;\n+\n+\t\tif (i == HV_RECV_BUF_MAP || i == HV_SEND_BUF_MAP) {\n+\t\t\tsnprintf(sysctlVar, sizeof(sysctlVar), \"%s.%s.gpadl\",\n+\t\t\t\t sysctlBuffer, map_names[i]);\n+\t\t\tif (sysctlbyname(sysctlVar, &gpad, &sizelen, NULL, 0) < 0) {\n+\t\t\t\tVMBUS_LOG(ERR,\n+\t\t\t\t\t\"could not read %s\", sysctlVar);\n+\t\t\t\tgoto error;\n+\t\t\t}\n+\t\t\t/* put the GPAD value in physical address */\n+\t\t\tres->phys_addr = gpad;\n+\t\t}\n+\t}\n+\treturn 0;\n+error:\n+\treturn -1;\n+}\n+\n int\n vmbus_uio_alloc_resource(struct rte_vmbus_device *dev,\n \t\t\t struct mapped_vmbus_resource **uio_res)\n {\n-\tchar devname[PATH_MAX]; /* contains the /dev/uioX */\n+\tchar devname[PATH_MAX]; /* contains the /dev/hv_uioX */\n \n \t/* save fd if in primary process */\n-\tsnprintf(devname, sizeof(devname), \"/dev/uio%u\", dev->uio_num);\n+\tsnprintf(devname, sizeof(devname), \"/dev/hv_uio%u\", dev->uio_num);\n \tdev->intr_handle.fd = open(devname, O_RDWR);\n \tif (dev->intr_handle.fd < 0) {\n \t\tVMBUS_LOG(ERR, \"Cannot open %s: %s\",\n@@ -98,8 +171,10 @@ vmbus_uio_alloc_resource(struct rte_vmbus_device *dev,\n \tstrlcpy((*uio_res)->path, devname, PATH_MAX);\n \trte_uuid_copy((*uio_res)->id, dev->device_id);\n \n-\treturn 0;\n+\tif (sysctl_get_vmbus_device_info(dev) < 0)\n+\t\tgoto error;\n \n+\treturn 0;\n error:\n \tvmbus_uio_free_resource(dev, *uio_res);\n \treturn -1;\n@@ -338,23 +413,12 @@ static int vmbus_uio_sysfs_read(const char *dir, const char *name,\n \treturn ret;\n }\n \n-static bool vmbus_uio_ring_present(const struct rte_vmbus_device *dev,\n-\t\t\t\t uint32_t relid)\n-{\n-\tchar ring_path[PATH_MAX];\n-\n-\t/* Check if kernel has subchannel sysfs files */\n-\tsnprintf(ring_path, sizeof(ring_path),\n-\t\t \"%s/%s/channels/%u/ring\",\n-\t\t SYSFS_VMBUS_DEVICES, dev->device.name, relid);\n-\n-\treturn access(ring_path, R_OK|W_OK) == 0;\n-}\n-\n bool vmbus_uio_subchannels_supported(const struct rte_vmbus_device *dev,\n \t\t\t\t const struct vmbus_channel *chan)\n {\n-\treturn vmbus_uio_ring_present(dev, chan->relid);\n+\tRTE_SET_USED(dev);\n+\tRTE_SET_USED(chan);\n+\treturn true;\n }\n \n static bool vmbus_isnew_subchannel(struct vmbus_channel *primary,\n", "prefixes": [ "04/11" ] }