Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99755/?format=api
https://patches.dpdk.org/api/patches/99755/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210927051737.18505-1-chenjilei@cmss.chinamobile.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210927051737.18505-1-chenjilei@cmss.chinamobile.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210927051737.18505-1-chenjilei@cmss.chinamobile.com", "date": "2021-09-27T05:17:37", "name": "vdpa/ifc: increase readability in function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "befb16a66ca76905950329287839452929d3d74c", "submitter": { "id": 2374, "url": "https://patches.dpdk.org/api/people/2374/?format=api", "name": "jilei chen", "email": "chenjilei@cmss.chinamobile.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210927051737.18505-1-chenjilei@cmss.chinamobile.com/mbox/", "series": [ { "id": 19185, "url": "https://patches.dpdk.org/api/series/19185/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19185", "date": "2021-09-27T05:17:37", "name": "vdpa/ifc: increase readability in function", "version": 1, "mbox": "https://patches.dpdk.org/series/19185/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99755/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/99755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C148DA0547;\n\tMon, 27 Sep 2021 11:23:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 40D67406A3;\n\tMon, 27 Sep 2021 11:23:12 +0200 (CEST)", "from cmccmta3.chinamobile.com (cmccmta3.chinamobile.com\n [221.176.66.81]) by mails.dpdk.org (Postfix) with ESMTP id 597DA4003D\n for <dev@dpdk.org>; Mon, 27 Sep 2021 07:09:41 +0200 (CEST)", "from spf.mail.chinamobile.com (unknown[172.16.121.89]) by\n rmmx-syy-dmz-app12-12012 (RichMail) with SMTP id 2eec6151520191c-da844;\n Mon, 27 Sep 2021 13:09:23 +0800 (CST)", "from chenjilei.localdomain (unknown[223.112.32.184])\n by rmsmtp-syy-appsvrnew05-12026 (RichMail) with SMTP id\n 2efa615151fa391-7c504;\n Mon, 27 Sep 2021 13:09:23 +0800 (CST)" ], "X-RM-TRANSID": [ "2eec6151520191c-da844", "2efa615151fa391-7c504" ], "X-RM-TagInfo": "emlType=0 ", "X-RM-SPAM-FLAG": "00000000", "From": "jilei chen <chenjilei@cmss.chinamobile.com>", "To": "xiao.w.wang@intel.com", "Cc": "dev@dpdk.org", "Date": "Mon, 27 Sep 2021 13:17:37 +0800", "Message-Id": "<20210927051737.18505-1-chenjilei@cmss.chinamobile.com>", "X-Mailer": "git-send-email 2.12.2", "In-Reply-To": "<20210926164518.8982-1-chenjilei@cmss.chinamobile.com>", "References": "<20210926164518.8982-1-chenjilei@cmss.chinamobile.com>", "X-Mailman-Approved-At": "Mon, 27 Sep 2021 11:23:10 +0200", "Subject": "[dpdk-dev] [PATCH] vdpa/ifc: increase readability in function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Optimize several parameters form order to better readability\n\nSigned-off-by: jilei chen <chenjilei@cmss.chinamobile.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex 1dc813d0a3..365da2a8b9 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -182,7 +182,7 @@ ifcvf_vfio_setup(struct ifcvf_internal *internal)\n }\n \n static int\n-ifcvf_dma_map(struct ifcvf_internal *internal, int do_map)\n+ifcvf_dma_map(struct ifcvf_internal *internal, bool do_map)\n {\n \tuint32_t i;\n \tint ret;\n@@ -538,11 +538,11 @@ update_datapath(struct ifcvf_internal *internal)\n \tif (!rte_atomic32_read(&internal->running) &&\n \t (rte_atomic32_read(&internal->started) &&\n \t rte_atomic32_read(&internal->dev_attached))) {\n-\t\tret = ifcvf_dma_map(internal, 1);\n+\t\tret = ifcvf_dma_map(internal, true);\n \t\tif (ret)\n \t\t\tgoto err;\n \n-\t\tret = vdpa_enable_vfio_intr(internal, 0);\n+\t\tret = vdpa_enable_vfio_intr(internal, false);\n \t\tif (ret)\n \t\t\tgoto err;\n \n@@ -568,7 +568,7 @@ update_datapath(struct ifcvf_internal *internal)\n \t\tif (ret)\n \t\t\tgoto err;\n \n-\t\tret = ifcvf_dma_map(internal, 0);\n+\t\tret = ifcvf_dma_map(internal, false);\n \t\tif (ret)\n \t\t\tgoto err;\n \n@@ -850,7 +850,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal)\n \t\tgoto error;\n \n \t/* set up interrupt for interrupt relay */\n-\tret = vdpa_enable_vfio_intr(internal, 1);\n+\tret = vdpa_enable_vfio_intr(internal, true);\n \tif (ret)\n \t\tgoto unmap;\n \n@@ -875,7 +875,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal)\n unset_intr:\n \tvdpa_disable_vfio_intr(internal);\n unmap:\n-\tifcvf_dma_map(internal, 0);\n+\tifcvf_dma_map(internal, false);\n error:\n \treturn -1;\n }\n@@ -934,7 +934,7 @@ ifcvf_dev_close(int vid)\n \t\tvdpa_disable_vfio_intr(internal);\n \n \t\t/* unset DMA map for guest memory */\n-\t\tifcvf_dma_map(internal, 0);\n+\t\tifcvf_dma_map(internal, false);\n \n \t\tinternal->sw_fallback_running = false;\n \t} else {\n@@ -1130,7 +1130,7 @@ ifcvf_set_vring_state(int vid, int vring, int state)\n \t}\n \n \tif (state && !hw->vring[vring].enable) {\n-\t\tret = vdpa_enable_vfio_intr(internal, 0);\n+\t\tret = vdpa_enable_vfio_intr(internal, false);\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n", "prefixes": [] }{ "id": 99755, "url": "