Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99670/?format=api
{ "id": 99670, "url": "https://patches.dpdk.org/api/patches/99670/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20210926072315.3413652-1-weix.ling@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20210926072315.3413652-1-weix.ling@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20210926072315.3413652-1-weix.ling@intel.com", "date": "2021-09-26T07:23:15", "name": "[V1,2/2] tests/perf_virtio_user_pvp: delete test suite", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dbe0bb06b25e5ef74b34f9c03e6b5f00a0d1c486", "submitter": { "id": 1828, "url": "https://patches.dpdk.org/api/people/1828/?format=api", "name": "Ling, WeiX", "email": "weix.ling@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20210926072315.3413652-1-weix.ling@intel.com/mbox/", "series": [ { "id": 19161, "url": "https://patches.dpdk.org/api/series/19161/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=19161", "date": "2021-09-26T07:22:48", "name": "delete test plan and test suite", "version": 1, "mbox": "https://patches.dpdk.org/series/19161/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99670/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/99670/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB6A2A0547;\n\tSun, 26 Sep 2021 09:30:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C0C8740698;\n\tSun, 26 Sep 2021 09:30:16 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id B081E4003C\n for <dts@dpdk.org>; Sun, 26 Sep 2021 09:30:14 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Sep 2021 00:30:13 -0700", "from unknown (HELO localhost.localdomain) ([10.240.183.222])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Sep 2021 00:30:12 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10118\"; a=\"223967675\"", "E=Sophos;i=\"5.85,323,1624345200\"; d=\"scan'208\";a=\"223967675\"", "E=Sophos;i=\"5.85,323,1624345200\"; d=\"scan'208\";a=\"475607045\"" ], "From": "Wei Ling <weix.ling@intel.com>", "To": "dts@dpdk.org", "Cc": "Wei Ling <weix.ling@intel.com>", "Date": "Sun, 26 Sep 2021 15:23:15 +0800", "Message-Id": "<20210926072315.3413652-1-weix.ling@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dts] [PATCH V1 2/2] tests/perf_virtio_user_pvp: delete test suite", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "Delete test plan and test suite because this testplan and\ntestsuite is include by pvp_multi_paths_performance.\n\nSigned-off-by: Wei Ling <weix.ling@intel.com>\n---\n tests/TestSuite_perf_virtio_user_pvp.py | 389 ------------------------\n 1 file changed, 389 deletions(-)\n delete mode 100644 tests/TestSuite_perf_virtio_user_pvp.py", "diff": "diff --git a/tests/TestSuite_perf_virtio_user_pvp.py b/tests/TestSuite_perf_virtio_user_pvp.py\ndeleted file mode 100644\nindex 344dba5a..00000000\n--- a/tests/TestSuite_perf_virtio_user_pvp.py\n+++ /dev/null\n@@ -1,389 +0,0 @@\n-# BSD LICENSE\n-#\n-# Copyright(c) 2019-2020 Intel Corporation. All rights reserved.\n-# All rights reserved.\n-#\n-# Redistribution and use in source and binary forms, with or without\n-# modification, are permitted provided that the following conditions\n-# are met:\n-#\n-# * Redistributions of source code must retain the above copyright\n-# notice, this list of conditions and the following disclaimer.\n-# * Redistributions in binary form must reproduce the above copyright\n-# notice, this list of conditions and the following disclaimer in\n-# the documentation and/or other materials provided with the\n-# distribution.\n-# * Neither the name of Intel Corporation nor the names of its\n-# contributors may be used to endorse or promote products derived\n-# from this software without specific prior written permission.\n-#\n-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n-# \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n-\n-\"\"\"\n-DPDK Test suite.\n-\"\"\"\n-import utils\n-import json\n-import rst\n-import os\n-import re\n-import time\n-from test_case import TestCase\n-from packet import Packet\n-from settings import UPDATE_EXPECTED, load_global_setting\n-from copy import deepcopy\n-\n-\n-class TestVirtioSingleCorePerf(TestCase):\n-\n- def set_up_all(self):\n- \"\"\"\n- Run at the start of each test suite.\n- \"\"\"\n- # Clean the execution environment\n- self.dut.send_expect(\"rm -rf ./vhost.out\", \"#\")\n- self.frame_sizes = [64, 1518]\n- # Based on h/w type, choose how many ports to use\n- self.number_of_ports = 1\n- self.dut_ports = self.dut.get_ports()\n- self.nb_ports = len(self.dut_ports)\n- self.socket = self.dut.get_numa_id(self.dut_ports[0])\n- # determine if to save test result as a separated file\n- self.save_result_flag = True\n- socket_num = len(set([int(core['socket']) for core in self.dut.cores]))\n- self.socket_mem = ','.join(['1024']*socket_num)\n- self.json_obj = dict()\n-\n- def set_up(self):\n- \"\"\"\n- Run before each test case.\n- It's more convenient to load suite configuration here than\n- set_up_all in debug mode.\n- \"\"\"\n-\n- self.dut.send_expect('rm vhost-net*', '# ')\n- # test parameters include: frames size, descriptor numbers\n- self.test_parameters = self.get_suite_cfg()['test_parameters']\n-\n- # traffic duraion in second\n- self.test_duration = self.get_suite_cfg()['test_duration']\n-\n- # initilize throughput attribution\n- # {'$framesize':{\"$nb_desc\": 'throughput'}\n- self.throughput = {}\n-\n- # Accepted tolerance in Mpps\n- self.gap = self.get_suite_cfg()['accepted_tolerance']\n-\n- # header to print test result table\n- self.table_header = ['Frame Size', 'TXD/RXD', 'Throughput', 'Rate',\n- 'Expected Throughput', 'Throughput Difference']\n- self.test_result = {}\n-\n- def test_perf_pvp_packed_ring_mergeable_path(self):\n- \"\"\"\n- pvp test with packed ring mergeable path .\n- \"\"\"\n- self.test_target = \"packed_1q1c\"\n- self.expected_throughput = self.get_suite_cfg()['expected_throughput'][self.test_target]\n- self.perf_pvp_test(packed=True)\n- self.handle_expected()\n- self.handle_results()\n-\n- def test_perf_virtio_single_core_performance_of_packed_ring_mergeable_path(self):\n- \"\"\"\n- virtio single core performance test with packed ring Mergeable Path.\n- \"\"\"\n- self.test_target = \"packed_virtio_single_core\"\n- self.expected_throughput = self.get_suite_cfg()['expected_throughput'][self.test_target]\n- self.perf_virtio_single_core_test(packed=True)\n- self.handle_expected()\n- self.handle_results()\n-\n- def test_perf_vhost_single_core_performance_of_pakced_ring_mergeable_path(self):\n- \"\"\"\n- vhost single core performance test with packed ring Mergeable Path.\n- \"\"\"\n- self.test_target = \"packed_vhost_single_core\"\n- self.expected_throughput = self.get_suite_cfg()['expected_throughput'][self.test_target]\n- self.perf_vhost_single_core_test(packed=True)\n- self.handle_expected()\n- self.handle_results()\n-\n- def test_perf_pvp_split_ring_mergeble_path(self):\n- \"\"\"\n- Benchmark performance for Vhost PVP Mergeable Path.\n- \"\"\"\n- self.test_target = \"split_1q1c\"\n- self.expected_throughput = self.get_suite_cfg()['expected_throughput'][self.test_target]\n- self.perf_pvp_test(packed=False)\n- self.handle_expected()\n- self.handle_results()\n-\n- def test_perf_virtio_single_core_performance_of_split_ring_mergeable_path(self):\n- \"\"\"\n- virtio single core performance test with split ring Mergeable Path.\n- \"\"\"\n- self.test_target = \"split_virtio_single_core\"\n- self.expected_throughput = self.get_suite_cfg()['expected_throughput'][self.test_target]\n- self.perf_virtio_single_core_test(packed=False)\n- self.handle_expected()\n- self.handle_results()\n-\n- def test_perf_vhost_single_core_performance_of_split_ring_mergeable_path(self):\n- \"\"\"\n- : vhost single core performance test with split ring Mergeable Path.\n- \"\"\"\n- self.test_target = \"split_vhost_single_core\"\n- self.expected_throughput = self.get_suite_cfg()['expected_throughput'][self.test_target]\n- self.perf_vhost_single_core_test(packed=False)\n- self.handle_expected()\n- self.handle_results()\n-\n- def perf_pvp_test(self, packed):\n- core_config = \"1S/4C/1T\"\n- core_list = self.dut.get_core_list(core_config, socket=self.socket)\n- self.verify(len(core_list) >= 4, 'There no enough cores to run this case')\n- self.logger.info(\"Executing Test Using cores: %s\" % core_list)\n- self.core_list_user = core_list[0:2]\n- self.core_list_host = core_list[2:4]\n- nb_desc = self.test_parameters[64][0]\n- self.start_testpmd_as_vhost('mac', nb_desc, False)\n- self.start_testpmd_as_virtio('mac', nb_desc, True, packed)\n- self.send_and_verify_throughput(nb_desc)\n-\n- def perf_virtio_single_core_test(self, packed):\n- \"\"\"\n- Vhost/virtio single core PVP test\n- \"\"\"\n- core_config = \"1S/5C/1T\"\n- core_list = self.dut.get_core_list(core_config, socket=self.socket)\n- self.verify(len(core_list) >= 5, 'There no enough cores to run this case')\n- self.logger.info(\"Executing Test Using cores: %s\" % core_list)\n- self.core_list_user = core_list[0:2]\n- self.core_list_host = core_list[2:5]\n- nb_desc = self.test_parameters[64][0]\n- self.start_testpmd_as_vhost('io', nb_desc, False)\n- self.start_testpmd_as_virtio('mac', nb_desc, True, packed)\n- self.send_and_verify_throughput(nb_desc)\n- \n- def perf_vhost_single_core_test(self, packed):\n- \"\"\"\n- Vhost/virtio vhost single core PVP test\n- \"\"\"\n- core_config = \"1S/5C/1T\"\n- core_list = self.dut.get_core_list(core_config, socket=self.socket)\n- self.verify(len(core_list) >= 5, 'There no enough cores to run this case')\n- self.logger.info(\"Executing Test Using cores: %s\" % core_list)\n- self.core_list_user = core_list[0:3]\n- self.core_list_host = core_list[3:5]\n- nb_desc = self.test_parameters[64][0]\n- self.start_testpmd_as_vhost('mac', nb_desc, True)\n- self.start_testpmd_as_virtio('io', nb_desc, False, packed)\n- self.send_and_verify_throughput(nb_desc)\n-\n- def prepare_stream(self, frame_size):\n- '''\n- create streams for ports, one port two streams, and configure them.\n- '''\n- self.tester.pktgen.clear_streams()\n- stream_ids = []\n- rx_port = self.tester.get_local_port(\n- self.dut_ports[0])\n- tx_port = self.tester.get_local_port(\n- self.dut_ports[0])\n- for port in range(2):\n- destination_mac = self.dut.get_mac_address(\n- self.dut_ports[(port) % self.number_of_ports])\n- pkt = Packet(pkt_type='IP_RAW', pkt_len=frame_size)\n- pkt.config_layer('ether', {'dst': '%s' % '52:00:00:00:00:00'})\n- pkt.config_layer('ipv4', {'dst': '1.1.%d.1' % port, 'src': '1.1.1.2'})\n- pkt.save_pcapfile(self.tester, \"%s/single_core_%d.pcap\" % (self.tester.tmp_file, port))\n- stream_id = self.tester.pktgen.add_stream(tx_port, rx_port,\n- \"%s/single_core_%d.pcap\" % (self.tester.tmp_file, port))\n- stream_option = {\n- 'pcap': \"%s/single_core_%d.pcap\" % (self.tester.tmp_file, port),\n- 'stream_config': {'rate': 100}\n- }\n- self.tester.pktgen.config_stream(stream_id, stream_option)\n- stream_ids.append(stream_id)\n- return stream_ids\n-\n- def handle_expected(self):\n- \"\"\"\n- Update expected numbers to configurate file: conf/$suite_name.cfg\n- \"\"\"\n- if load_global_setting(UPDATE_EXPECTED) == \"yes\":\n- for frame_size in self.test_parameters.keys():\n- for nb_desc in self.test_parameters[frame_size]:\n- self.expected_throughput[frame_size][nb_desc] = round(self.throughput[frame_size][nb_desc], 3)\n-\n- def start_testpmd_as_vhost(self, fwd_mode, nb_desc, no_pci=False):\n- if no_pci:\n- eal_params = self.dut.create_eal_parameters(cores=self.core_list_host,\n- no_pci=True, prefix='vhost')\n- else:\n- eal_params = self.dut.create_eal_parameters(cores=self.core_list_host,\n- ports=[0], prefix='vhost')\n- command_line_client = self.target + \"/app/testpmd %s \" + \\\n- \"--socket-mem 1024,1024 \" \\\n- \"--vdev 'net_vhost0,iface=vhost-net,queues=1' \" + \\\n- \"-- -i --nb-cores=%d --txd=%d --rxd=%d\"\n- command_line_client = command_line_client % (eal_params, len(self.core_list_host)-1,\n- nb_desc, nb_desc)\n- self.dut.send_expect(command_line_client, \"testpmd> \", 120)\n- self.dut.send_expect(\"set fwd %s\" % fwd_mode, \"testpmd> \", 120)\n- self.dut.send_expect(\"start\", \"testpmd> \", 120)\n-\n- def start_testpmd_as_virtio(self, fwd_mode, nb_desc, no_pci=True, packed_ring=False):\n- # launch virtio\n- if no_pci:\n- eal_params = self.dut.create_eal_parameters(cores=self.core_list_user,\n- no_pci=True, prefix='virtio')\n- else:\n- eal_params = self.dut.create_eal_parameters(cores=self.core_list_user,\n- ports=[0], prefix='virtio')\n- \n- command_line_server = self.target + \"/app/testpmd %s \" + \\\n- \"--vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_vq=%d,mrg_rxbuf=1,in_order=0 \" + \\\n- \"-- -i --nb-cores=%d --tx-offloads=0x0 --enable-hw-vlan-strip --txd=%d --rxd=%d\"\n- command_line_server = command_line_server % (eal_params, int(packed_ring),\n- len(self.core_list_user)-1, nb_desc, nb_desc)\n- self.vhost_user = self.dut.new_session(suite=\"user\")\n- self.vhost_user.send_expect(command_line_server, \"testpmd> \", 120)\n- self.vhost_user.send_expect(\"set fwd %s\" % fwd_mode, \"testpmd> \", 120)\n- self.vhost_user.send_expect(\"start\", \"testpmd> \", 120)\n- self.vhost_user.send_expect(\"start\", \"testpmd> \", 120)\n-\n- def send_and_verify_throughput(self, nb_desc):\n- for frame_size in self.frame_sizes:\n- self.throughput[frame_size] = dict()\n- self.logger.info(\"Test running at parameters: \" +\n- \"framesize: {}, rxd/txd: {}\".format(frame_size, nb_desc))\n- stream_ids = self.prepare_stream(frame_size)\n- traffic_opt = {\n- 'method': 'throughput',\n- 'rate': 100,\n- 'duration': 20}\n- _, pps = self.tester.pktgen.measure(stream_ids, traffic_opt)\n- Mpps = pps / 1000000.0\n- self.verify(Mpps > 0, \"%s can not receive packets of frame size %d\" % (self.running_case, frame_size))\n- throughput = Mpps * 100 / \\\n- float(self.wirespeed(self.nic, frame_size, self.number_of_ports))\n- self.throughput[frame_size][nb_desc] = Mpps\n- self.verify(throughput,\n- \"No traffic detected, please check your configuration\")\n- self.logger.info(\"Trouthput of \" +\n- \"framesize: {}, rxd/txd: {} is :{} Mpps\".format(\n- frame_size, nb_desc, Mpps))\n-\n- \n- def handle_results(self):\n- \"\"\"\n- results handled process:\n- 1, save to self.test_results\n- 2, create test results table\n- 3, save to json file for Open Lab\n- \"\"\"\n- header = self.table_header\n- for frame_size in self.test_parameters.keys():\n- wirespeed = self.wirespeed(self.nic, frame_size, self.nb_ports)\n- ret_datas = {}\n- for nb_desc in self.test_parameters[frame_size]:\n- ret_data = {}\n- ret_data[header[0]] = frame_size\n- ret_data[header[1]] = nb_desc\n- ret_data[header[2]] = \"{:.3f} Mpps\".format(\n- self.throughput[frame_size][nb_desc])\n- ret_data[header[3]] = \"{:.3f}%\".format(\n- self.throughput[frame_size][nb_desc] * 100 / wirespeed)\n- ret_data[header[4]] = \"{:.3f} Mpps\".format(\n- self.expected_throughput[frame_size][nb_desc])\n- ret_data[header[5]] = \"{:.3f} Mpps\".format(\n- self.throughput[frame_size][nb_desc] -\n- self.expected_throughput[frame_size][nb_desc])\n- ret_datas[nb_desc] = deepcopy(ret_data)\n- self.test_result[frame_size] = deepcopy(ret_datas)\n- # Create test results table\n- self.result_table_create(header)\n- for frame_size in self.test_parameters.keys():\n- for nb_desc in self.test_parameters[frame_size]:\n- table_row = list()\n- for i in range(len(header)):\n- table_row.append(\n- self.test_result[frame_size][nb_desc][header[i]])\n- self.result_table_add(table_row)\n- # present test results to screen\n- self.result_table_print()\n- # save test results as a file\n- if self.save_result_flag:\n- self.save_result(self.test_result)\n-\n- def save_result(self, data):\n- '''\n- Saves the test results as a separated file named with\n- self.nic+_perf_virtio_user_pvp.json in output folder\n- if self.save_result_flag is True\n- '''\n- case_name = self.running_case\n- self.json_obj[case_name] = list()\n- status_result = []\n- for frame_size in self.test_parameters.keys():\n- for nb_desc in self.test_parameters[frame_size]:\n- row_in = self.test_result[frame_size][nb_desc]\n- row_dict0 = dict()\n- row_dict0['performance'] = list()\n- row_dict0['parameters'] = list()\n- row_dict0['parameters'] = list()\n- result_throughput = float(row_in['Throughput'].split()[0])\n- expected_throughput = float(row_in['Expected Throughput'].split()[0])\n- # delta value and accepted tolerance in percentage\n- delta = result_throughput - expected_throughput\n- gap = expected_throughput * -self.gap * 0.01\n- delta = float(delta)\n- gap = float(gap)\n- self.logger.info(\"Accept tolerance are (Mpps) %f\" % gap)\n- self.logger.info(\"Throughput Difference are (Mpps) %f\" % delta)\n- if result_throughput > expected_throughput + gap:\n- row_dict0['status'] = 'PASS'\n- else:\n- row_dict0['status'] = 'FAIL'\n- row_dict1 = dict(name=\"Throughput\", value=result_throughput, unit=\"Mpps\", delta=delta)\n- row_dict2 = dict(name=\"Txd/Rxd\", value=row_in[\"TXD/RXD\"], unit=\"descriptor\")\n- row_dict3 = dict(name=\"frame_size\", value=row_in[\"Frame Size\"], unit=\"bytes\")\n- row_dict0['performance'].append(row_dict1)\n- row_dict0['parameters'].append(row_dict2)\n- row_dict0['parameters'].append(row_dict3)\n- self.json_obj[case_name].append(row_dict0)\n- status_result.append(row_dict0['status'])\n- with open(os.path.join(rst.path2Result,\n- '{0:s}_{1}.json'.format(\n- self.nic, self.suite_name)), 'w') as fp:\n- json.dump(self.json_obj, fp)\n- self.verify(\"FAIL\" not in status_result, \"Exceeded Gap\")\n-\n- def tear_down(self):\n- \"\"\"\n- Run after each test case.\n- \"\"\"\n- self.dut.send_expect(\"stop\", \"testpmd> \")\n- self.dut.send_expect(\"quit\", \"# \", 30)\n- self.vhost_user.send_expect(\"stop\", \"testpmd> \")\n- self.vhost_user.send_expect(\"quit\", \"# \", 30)\n- self.dut.kill_all()\n-\n- def tear_down_all(self):\n- \"\"\"\n- Run after each test suite.\n- \"\"\"\n- pass\n", "prefixes": [ "V1", "2/2" ] }